https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292008-12-29T17:42:33ZRedmineRedmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=63402008-12-29T17:42:33ZKarl Heinz Marbaise
<ul><li><strong>Start date</strong> deleted (<del><i>2008-12-29</i></del>)</li></ul> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=63412008-12-29T17:51:04ZKarl Heinz Marbaise
<ul></ul><p>Hi,<br />rechecked revision:<br /><pre>$/usr/local/vhosts/redmine # svn info
Path: .
URL: http://redmine.rubyforge.org/svn/branches/0.8-stable
Repository Root: http://redmine.rubyforge.org/svn
Repository UUID: e93f8b46-1217-0410-a6f0-8f06a7374b81
Revision: 2201
Node Kind: directory
Schedule: normal
Last Changed Author: jplang
Last Changed Rev: 2200
Last Changed Date: 2008-12-29 16:50:08 +0100 (Mon, 29 Dec 2008)</pre><br />The same behaviour.</p> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=265772011-03-18T08:49:05ZEtienne Massip
<ul><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=301752011-06-22T18:52:45ZEugene Sypachev
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>This will fix the problem:<br /><pre><code class="rhtml syntaxhl">Index: index.rhtml
===================================================================
--- index.rhtml (revision 6120)
+++ index.rhtml (working copy)
@@ -2,7 +2,7 @@
<span class="cp"><%=</span> <span class="n">link_to</span><span class="p">(</span><span class="n">l</span><span class="p">(</span><span class="ss">:label_news_new</span><span class="p">),</span>
<span class="n">new_project_news_path</span><span class="p">(</span><span class="vi">@project</span><span class="p">),</span>
<span class="ss">:class</span> <span class="o">=></span> <span class="s1">'icon icon-add'</span><span class="p">,</span>
<span class="o">-</span> <span class="ss">:onclick</span> <span class="o">=></span> <span class="s1">'Element.show("add-news"); Form.Element.focus("news_title"); return false;'</span><span class="p">)</span> <span class="k">if</span> <span class="vi">@project</span> <span class="o">&&</span> <span class="no">User</span><span class="p">.</span><span class="nf">current</span><span class="p">.</span><span class="nf">allowed_to?</span><span class="p">(</span><span class="ss">:manage_news</span><span class="p">,</span> <span class="vi">@project</span><span class="p">)</span> <span class="cp">%></span>
+ :onclick => 'Element.show("add-news"); Element.hide("contextual"); Form.Element.focus("news_title"); return false;') if @project <span class="err">&&</span> User.current.allowed_to?(:manage_news, @project) %>
<span class="nt"></div></span>
<span class="nt"><div</span> <span class="na">id=</span><span class="s">"add-news"</span> <span class="na">style=</span><span class="s">"display:none;"</span><span class="nt">></span>
@@ -17,7 +17,7 @@
:update => 'preview',
:with => "Form.serialize('news-form')"
}, :accesskey => accesskey(:preview) %> |
-<span class="cp"><%=</span> <span class="n">link_to</span> <span class="n">l</span><span class="p">(</span><span class="ss">:button_cancel</span><span class="p">),</span> <span class="s2">"#"</span><span class="p">,</span> <span class="ss">:onclick</span> <span class="o">=></span> <span class="s1">'Element.hide("add-news")'</span> <span class="cp">%></span>
+<span class="cp"><%=</span> <span class="n">link_to</span> <span class="n">l</span><span class="p">(</span><span class="ss">:button_cancel</span><span class="p">),</span> <span class="s2">"#"</span><span class="p">,</span> <span class="ss">:onclick</span> <span class="o">=></span> <span class="s1">'Element.hide("add-news"); Element.show("contextual");'</span> <span class="cp">%></span>
<span class="cp"><%</span> <span class="k">end</span> <span class="k">if</span> <span class="vi">@project</span> <span class="cp">%></span>
<span class="nt"><div</span> <span class="na">id=</span><span class="s">"preview"</span> <span class="na">class=</span><span class="s">"wiki"</span><span class="nt">></div></span>
<span class="nt"></div></span>
</code></pre></p>
<p>Sorry, don't found the way to commit changes to SVN repo.</p> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=301832011-06-23T07:14:31ZEtienne Massip
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>New</i></li></ul> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=438112013-01-05T12:59:45ZDaniel Felix
<ul></ul><p>Well, this seems to be fixed in the current version of redmine (trunk and version 2.2).</p>
<p>I think this could be closed, or does anyone else encounter this problem?</p> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=441932013-01-13T10:57:13ZDaniel Felix
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> deleted (<del><i>Candidate for next minor release</i></del>)</li></ul><p>I'm closing it, see my prior comment.</p> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=442552013-01-13T23:41:05ZMischa The Evil
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>This is still an issue IMO. It's about the fact that the "Add news" button is displayed <em>while adding</em> a new news item (thus being on the new news view). This also applies to two other <em>new</em> views: 'New message' and 'New document'.</p>
<p>This can be "reproduced" on *.m.redmine.org (and rm.o) as such. I think we can argue about whether it's a defect or not. The 'Add x'-functionality is not broken in any way, it's just the lone fact that the button is displayed on those views. I think this is more a design-consequence rather than a defect - not completely sure here, so correct me if I'm wrong.<br />More general: I think this is <em>more</em> of a FR to request improvements regarding the consistency of the UI, more specific the mentioned 'New x views'. What do you think?</p> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=442622013-01-14T05:13:08ZDaniel Felix
<ul></ul><p>Oh, yes you're right. The button was just hidden behind an elemente as I tested it on my testsystem.</p>
<p>This relates to <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Useless "edit" link in workflow menu (Closed)" href="https://www.redmine.org/issues/12824">#12824</a>.</p> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=1023632021-05-07T09:05:44ZAlexander Meindl
<ul><li><strong>File</strong> <a href="/attachments/27325">fix_add_news_button.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27325/fix_add_news_button.patch">fix_add_news_button.patch</a> added</li></ul><p>Hi,</p>
<p>I created a new patch to fix the problem. With my solution a user with manage news permissions (in any project) can see the "add news" button on global news index.</p>
<p>Without this patch, everyone can see "add news" button on global news index - even without permissions.</p> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=1025662021-05-25T09:39:46ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul><p>Alexander Meindl wrote:</p>
<blockquote>
<p>I created a new patch to fix the problem. With my solution a user with manage news permissions (in any project) can see the "add news" button on global news index.</p>
<p>Without this patch, everyone can see "add news" button on global news index - even without permissions.</p>
</blockquote>
<p>Thank you for detecting and reporting the issue.</p>
<p>The bug you is a new one in Redmine 4.2.0 (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: "Add news" button in cross-project News tab (Closed)" href="https://www.redmine.org/issues/33167">#33167</a>) and is different from this one. I have opened <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: "Add news" button on global news index is displayed for users without permissions (Closed)" href="https://www.redmine.org/issues/35308">#35308</a> for the bug and attached the patch.</p> Redmine - Defect #2414: 'Add News Button' in 'Add news'https://www.redmine.org/issues/2414?journal_id=1025672021-05-25T09:39:57ZGo MAEDA
<ul><li><strong>Target version</strong> deleted (<del><i>Candidate for next minor release</i></del>)</li></ul>