https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-02-07T00:41:13ZRedmineRedmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=765262017-02-07T00:41:13ZToshi MARUYAMA
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Patch</i></li><li><strong>Category</strong> changed from <i>I18n</i> to <i>Translations</i></li></ul> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=765682017-02-10T01:29:07ZVVD VVD
<ul></ul><p>uk?<br />Why not ua?…</p> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=765692017-02-10T03:21:48ZGo MAEDA
<ul></ul><p>VVD VVD wrote:</p>
<blockquote>
<p>uk?<br />Why not ua?…</p>
</blockquote>
<p>I think 'uk' is right ISO 639-1 code for Ukrainian language.</p>
<p><a class="external" href="https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes">https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes</a><br /><a class="external" href="https://www.loc.gov/standards/iso639-2/php/code_list.php">https://www.loc.gov/standards/iso639-2/php/code_list.php</a></p> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=765712017-02-10T04:53:00ZMischa The Evil
<ul></ul><p>See <a href="https://github.com/svenfuchs/rails-i18n/issues/285" class="external">this</a> issue on rails-i18n which explains <code>uk</code> vs. <code>ua</code> pretty well and see the leading <a href="http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry" class="external">IANA Language Subtag Registry</a>. As such, <code>uk</code> is fine and in line with Rails core.</p>
<a class="user active" href="https://www.redmine.org/users/1933">Anton Gunkin</a> Oslyak: can you provide a patch<sup><a href="#fn1">1</a></sup> against current trunk for this? That would make the life of the committer much prettier.. And can you also translate:
<ul>
<li>the wiki toolbar language file: <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/public/javascripts/jstoolbar/lang/jstoolbar-uk.js">source:/trunk/public/javascripts/jstoolbar/lang/jstoolbar-uk.js</a></li>
<li>the bundled help files: <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/public/help/uk">source:/trunk/public/help/uk</a></li>
</ul>
<p>Ref.: <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/HowTo_translate_Redmine_in_your_own_language">HowTo_translate_Redmine_in_your_own_language</a>.</p>
<p>Thanks for your contribution.</p>
<p id="fn1" class="footnote"><sup>1</sup> see <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/Patch">patch</a> and <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/How_to_create_patch_series_on_Mercurial_and_Git">How_to_create_patch_series_on_Mercurial_and_Git</a> for instructions</p> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=766452017-02-13T23:52:13ZAnton Oslyak
<ul><li><strong>File</strong> <a href="/attachments/17695">ukrainian_localization.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17695/ukrainian_localization.diff">ukrainian_localization.diff</a> added</li><li><strong>File</strong> <a href="/attachments/17694">Ukrainian_localization.zip</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17694/Ukrainian_localization.zip">Ukrainian_localization.zip</a> added</li></ul><p>Done!</p>
<p>URL: <a class="external" href="https://svn.redmine.org/redmine/trunk">https://svn.redmine.org/redmine/trunk</a><br />revision: 16333</p>
<p>Translated files:</p>
<pre>
./config/locales/uk.yml
./public/javascripts/jstoolbar/lang/jstoolbar-uk.js
./public/help/uk/wiki_syntax_markdown.html
./public/help/uk/wiki_syntax_textile.html
./public/help/uk/wiki_syntax_detailed_textile.html
./public/help/uk/wiki_syntax_detailed_markdown.html
</pre> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=766462017-02-14T00:30:14ZAnton Oslyak
<ul></ul><p>Btw,<br />Inside Ukraine everywhere:</p>
<ul>
<li>national domain <strong>.ua</strong></li>
<li>at car number plates, </li>
<li>at the documents, </li>
<li>even in currency sign UAH (Ukrainian hryvnia)</li>
</ul>
<p>Used UA symbols, not UK</p>
<p>But in my international passport.<br /><pre>
Country code: UKR
</pre></p>
<p>Even Google translator <a href="https://translate.google.com/?prev=_t&hl=ru&ie=UTF-8&eotf=1&text=&sl=en&tl=ru#en/uk/UK" class="external">translate UK</a> from English to Ukrainian as Great Britain</p>
<p>So, I think that correct variant is for two chars UA and for three chars UKR</p>
<p>P.S. But I don't think it has really matter.</p> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=766532017-02-14T08:09:13ZMischa The Evil
<ul></ul><p>Anton Oslyak wrote:</p>
<blockquote>
<p>Done!</p>
<p>URL: <a class="external" href="https://svn.redmine.org/redmine/trunk">https://svn.redmine.org/redmine/trunk</a><br />revision: 16333</p>
</blockquote>
<p>It seems something went wrong as your patch is reverting <a class="changeset" title="Extract wiki_syntax_detailed internal style sheets into an external one (#24800). Patch by Misch..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16206">r16206</a>, <a class="changeset" title="Extract wiki_syntax internal style sheets into an external one (#24800). Patch by Mischa The Evil." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16207">r16207</a> and <a class="changeset" title="Remove old and obsolete 'Content-Style-Type' meta tag (#24800). Patch by Mischa The Evil." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16208">r16208</a>. Probably it is not made against current trunk. Can you please fix this?</p>
<p>Anton Oslyak wrote:</p>
<blockquote>
<p>Btw,<br />Inside Ukraine everywhere:</p>
<ul>
<li>national domain <strong>.ua</strong></li>
<li>at car number plates, </li>
<li>at the documents, </li>
<li>even in currency sign UAH (Ukrainian hryvnia)</li>
</ul>
<p>Used UA symbols, not UK</p>
<p>But in my international passport.<br />[Country code: UKR]</p>
<p>Even Google translator <a href="https://translate.google.com/?prev=_t&hl=ru&ie=UTF-8&eotf=1&text=&sl=en&tl=ru#en/uk/UK" class="external">translate UK</a> from English to Ukrainian as Great Britain</p>
<p>So, I think that correct variant is for two chars UA and for three chars UKR</p>
<p>P.S. But I don't think it has really matter.</p>
</blockquote>
<p>Well, the international passport seems to use ISO 639-2 for the country code. <code>UA</code> is the official ISO 3166-1 <em>country</em> code whereas <code>uk</code> is the official ISO 639-1 <em>language</em> code.</p> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=766592017-02-14T12:13:58ZAnton Oslyak
<ul><li><strong>File</strong> <a href="/attachments/17698">ukrainian_localization_without_uk_yml.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17698/ukrainian_localization_without_uk_yml.diff">ukrainian_localization_without_uk_yml.diff</a> added</li></ul><p>Let's break it's in a few steps</p>
<p>First of all I fixed all files exept uk.yml</p>
<p>Please check it</p> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=766672017-02-14T17:49:41ZAnton Oslyak
<ul><li><strong>File</strong> <a href="/attachments/17703">ukrainian_localization_without_uk_yml.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17703/ukrainian_localization_without_uk_yml.patch">ukrainian_localization_without_uk_yml.patch</a> added</li></ul> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=766782017-02-15T09:21:03ZMischa The Evil
<ul></ul><p>Anton Oslyak wrote:</p>
<blockquote>
<ul>
<li><strong>File</strong> ukrainian_localization_without_uk_yml.diff added</li>
<li><strong>File</strong> ukrainian_localization_without_uk_yml.patch added</li>
</ul>
<p>First of all I fixed all files exept uk.yml</p>
<p>Please check it</p>
</blockquote>
<p>Done, both (they are actually equal besides the extension) apply cleanly onto current trunk @ <a class="changeset" title="remove trailing white space from test/unit/setting_test.rb" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16333">r16333</a>. I haven't done (and am unable to do) any substantial review of these patches as I'm not a speaker of the respective language, but they 'structurally' look good.</p> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=766892017-02-15T11:55:19ZAnton Oslyak
<ul></ul><p>Yes, files was identical besides the extension</p>
<p>Why when</p>
<pre>
svn co https://svn.redmine.org/redmine/trunk
</pre>
<p>I don't see my changes???</p>
<p>And last changes in repository<br /><pre>
2017-02-12 16:09:07 +0200
</pre></p> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=773152017-03-16T11:06:06ZToshi MARUYAMA
<ul><li><strong>Target version</strong> set to <i>3.4.0</i></li></ul> Redmine - Patch #25019: Localization for Ukrainian language - completedhttps://www.redmine.org/issues/25019?journal_id=773172017-03-16T12:02:07ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Committed in trunk <a class="changeset" title="Ukrainian translation updated by Anton Oslyak (#25019)" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16410">r16410</a>, thanks.</p>