https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292009-02-02T22:59:06ZRedmineRedmine - Patch #2576: Partially decouple application_helper.rb from Gravatarhttps://www.redmine.org/issues/2576?journal_id=70742009-02-02T22:59:06ZEric Davis
<ul><li><strong>Category</strong> deleted (<del><i>Plugin API</i></del>)</li><li><strong>Estimated time</strong> deleted (<del><i>0.50 h</i></del>)</li></ul><p><code>avatar</code> was used because <code>Gravatar#for</code> looks for the <code>email</code> attribute whereas Redmine uses the <code>mail</code> attribute. With a bit of Ruby you can override <code>ApplicationHelper#avatar</code> to use a local store (or anything else) from within a plugin. Let me know if you need some sample code for this, I have some on GitHub but the site's been slow for me today.</p> Redmine - Patch #2576: Partially decouple application_helper.rb from Gravatarhttps://www.redmine.org/issues/2576?journal_id=70762009-02-02T23:06:41ZBrad Beattie
<ul></ul><p>Eric Davis wrote:</p>
<blockquote>
<p><code>avatar</code> was used because <code>Gravatar#for</code> looks for the <code>email</code> attribute whereas Redmine uses the <code>mail</code> attribute. With a bit of Ruby you can override <code>ApplicationHelper#avatar</code> to use a local store (or anything else) from within a plugin. Let me know if you need some sample code for this, I have some on GitHub but the site's been slow for me today.</p>
</blockquote>
<p>I should be okay throwing it together. What I'd like to see is plugins not directly referenced in base code, and I think I can make the necessary changes to make that happen. I was playing around with it last night and made a bit of progress on this. Will post a patch once it's complete.</p> Redmine - Patch #2576: Partially decouple application_helper.rb from Gravatarhttps://www.redmine.org/issues/2576?journal_id=74372009-02-19T16:18:55ZBrad Beattie
<ul><li><strong>Assignee</strong> set to <i>Eric Davis</i></li></ul> Redmine - Patch #2576: Partially decouple application_helper.rb from Gravatarhttps://www.redmine.org/issues/2576?journal_id=81652009-03-21T00:00:21ZEric Davis
<ul><li><strong>Assignee</strong> deleted (<del><i>Eric Davis</i></del>)</li></ul><p>Any progress on the patch Brad?</p> Redmine - Patch #2576: Partially decouple application_helper.rb from Gravatarhttps://www.redmine.org/issues/2576?journal_id=81672009-03-21T00:01:52ZBrad Beattie
<ul></ul><p>Eric Davis wrote:</p>
<blockquote>
<p>I was playing around with it last night and made a bit of progress on this. Will post a patch once it's complete.</p>
</blockquote>
<p>Eric Davis wrote:</p>
<blockquote>
<p>Any progress on the patch Brad?</p>
</blockquote>
<p>Ah, I thought you were looking at it. If not, I'll look into it when I get a chance in the next few days.</p> Redmine - Patch #2576: Partially decouple application_helper.rb from Gravatarhttps://www.redmine.org/issues/2576?journal_id=82282009-03-24T21:34:08ZBrad Beattie
<ul><li><strong>File</strong> <a href="/attachments/1763">patch.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1763/patch.txt">patch.txt</a> added</li></ul><p>Hrm. Modifying the rest of Redmine was easy enough, but I got stuck at calling the GravatarHelper from the hook I created.</p>