https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-06-08T22:13:51ZRedmineRedmine - Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time viewshttps://www.redmine.org/issues/26125?journal_id=790982017-06-08T22:13:51ZMischa The Evil
<ul><li><strong>File</strong> <a href="/attachments/18491">0001-Fix-HTML-structure-of-query_form-on-calendar-gantt-v.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18491/0001-Fix-HTML-structure-of-query_form-on-calendar-gantt-v.patch">0001-Fix-HTML-structure-of-query_form-on-calendar-gantt-v.patch</a> added</li><li><strong>File</strong> <a href="/attachments/18492">0002-Fix-source-indentation-and-newline-usage.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18492/0002-Fix-source-indentation-and-newline-usage.patch">0002-Fix-source-indentation-and-newline-usage.patch</a> added</li><li><strong>File</strong> <a href="/attachments/18493">0003-Unify-query_form-structure-on-calendar-gantt-views.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18493/0003-Unify-query_form-structure-on-calendar-gantt-views.patch">0003-Unify-query_form-structure-on-calendar-gantt-views.patch</a> added</li><li><strong>File</strong> <a href="/attachments/18494">0004-Add-test-assertions-to-the-four-controller-test-case.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18494/0004-Add-test-assertions-to-the-four-controller-test-case.patch">0004-Add-test-assertions-to-the-four-controller-test-case.patch</a> added</li><li><strong>Description</strong> updated (<a title="View differences" href="/journals/79098/diff?detail_id=62175">diff</a>)</li></ul><p>Edit: seems like using thumbnails in tables causes some issues; replaced with regular image tags.<br />Edit 2: for anyone searching for the visual differences: only the calendar and gantt views are affected by these changes</p>
<p>Also attaching the patches.</p> Redmine - Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time viewshttps://www.redmine.org/issues/26125?journal_id=792972017-06-19T02:55:32ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul><p>Looks good to me. Passed all test.<br />Since we are freezing 3.4.0 now and this issue is a kind of refactoring, I think it would be better to set target version to 3.5.0 instead of 3.4.0.</p> Redmine - Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time viewshttps://www.redmine.org/issues/26125?journal_id=794602017-06-25T15:17:44ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul><p>Patches are committed, thanks!</p> Redmine - Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time viewshttps://www.redmine.org/issues/26125?journal_id=798792017-07-08T16:37:09ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.0.0</i></li></ul> Redmine - Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time viewshttps://www.redmine.org/issues/26125?journal_id=845912018-04-22T08:13:36ZMarius BÄ‚LTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/28602">Patch #28602</a>: Move edit and delete buttons for queries to the buttons section</i> added</li></ul>