https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-08-15T02:34:45ZRedmineRedmine - Patch #26682: URL-escape the ! character in generated markup for dropped uploadshttps://www.redmine.org/issues/26682?journal_id=806382017-08-15T02:34:45ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/19009">26682-before@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19009/26682-before@2x.png">26682-before@2x.png</a> added</li><li><strong>File</strong> <a href="/attachments/19010">26682-after@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19010/26682-after@2x.png">26682-after@2x.png</a> added</li><li><strong>Target version</strong> set to <i>3.4.3</i></li></ul><p>Confirmed the problem. Setting target version to 3.4.3.<br />Thank you for sharing the patch.</p>
<p><strong>Before:</strong><br /><img src="https://www.redmine.org/attachments/download/19009/26682-before@2x.png" srcset="https://www.redmine.org/attachments/download/19009/26682-before@2x.png 2x" style="width: 280px;border: 1px solid #ccc;" alt="" /></p>
<p><strong>After:</strong><br /><img src="https://www.redmine.org/attachments/download/19010/26682-after@2x.png" srcset="https://www.redmine.org/attachments/download/19010/26682-after@2x.png 2x" style="width: 280px;border: 1px solid #ccc;" alt="" /></p> Redmine - Patch #26682: URL-escape the ! character in generated markup for dropped uploadshttps://www.redmine.org/issues/26682?journal_id=806392017-08-15T03:05:44ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/19011">parentheses@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19011/parentheses@2x.png">parentheses@2x.png</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> set to <i>Holger Just</i></li></ul><p>'(' and ')' have to be escaped for Markdown formatter.<br />Holger, would you update the patch to escape those characters?</p>
<p><img src="https://www.redmine.org/attachments/download/19011/parentheses@2x.png" srcset="https://www.redmine.org/attachments/download/19011/parentheses@2x.png 2x" style="width: 167px;border: 1px solid #ccc;" alt="" /></p> Redmine - Patch #26682: URL-escape the ! character in generated markup for dropped uploadshttps://www.redmine.org/issues/26682?journal_id=806472017-08-15T10:11:47ZHolger Just
<ul><li><strong>File</strong> <a href="/attachments/19014">0001-URL-escape-additional-characters-with-special-meanin.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19014/0001-URL-escape-additional-characters-with-special-meanin.patch">0001-URL-escape-additional-characters-with-special-meanin.patch</a> added</li></ul><p>Thank you for the review Maeda-san. I had a look at the Markdown generation but completely missed the parenthesis. In addition to that, it turns out that in my previous patch, only the first instance of an exclamation mark would have been escaped</p>
<p>The attached patch fixes both of these issues. It completely supersedes the previous patch.</p> Redmine - Patch #26682: URL-escape the ! character in generated markup for dropped uploadshttps://www.redmine.org/issues/26682?journal_id=806712017-08-16T02:56:54ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li><li><strong>Assignee</strong> deleted (<del><i>Holger Just</i></del>)</li></ul><p>I have tested the updated patch (<a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: URL-escape the ! character in generated markup for dropped uploads (Closed)" href="https://www.redmine.org/issues/26682#note-3">#26682#note-3</a>). Now it works fine in both Markdown and Textile.<br />Thank you for updating the patch so quickly.</p> Redmine - Patch #26682: URL-escape the ! character in generated markup for dropped uploadshttps://www.redmine.org/issues/26682?journal_id=806722017-08-16T02:57:06ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/26071">Feature #26071</a>: Generate markup for uploaded image dropped into wiki-edit textarea</i> added</li></ul> Redmine - Patch #26682: URL-escape the ! character in generated markup for dropped uploadshttps://www.redmine.org/issues/26682?journal_id=815712017-10-15T11:37:48ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul><p>Patch committed, thanks.</p>