https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-08-17T07:06:48ZRedmineRedmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=806852017-08-17T07:06:48ZToshi MARUYAMA
<ul><li><strong>File</strong> <a href="/attachments/19039">diff.rb.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19039/diff.rb.diff">diff.rb.diff</a> added</li></ul> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=806862017-08-17T07:07:18ZToshi MARUYAMA
<ul><li><strong>File</strong> deleted (<del><i>diff.rb</i></del>)</li></ul> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=806872017-08-17T07:08:31ZToshi MARUYAMA
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/80687/diff?detail_id=63598">diff</a>)</li></ul> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=806882017-08-17T07:11:40ZToshi MARUYAMA
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Patch</i></li><li><strong>Category</strong> changed from <i>Issues</i> to <i>Code cleanup/refactoring</i></li></ul> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=806892017-08-17T07:44:03ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li></ul><p>I think your IssueQuery#versions_for_id is named IssueQuery#version_ids and pluck(:id) is in it for consistency.<br /><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/tags/3.4.2/app/models/issue_query.rb#L310">source:tags/3.4.2/app/models/issue_query.rb#L310</a></p>
<p>Please add ".diff" in your patch file name and remove commented lines from your patch.</p> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=806922017-08-17T21:21:39Zjwjw yy
<ul><li><strong>File</strong> <a href="/attachments/19042">issue_query.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19042/issue_query.diff">issue_query.diff</a> added</li></ul><p>done</p> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=806972017-08-18T03:54:01ZToshi MARUYAMA
<ul><li><strong>File</strong> <a href="/attachments/19043">issue_query.v3.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19043/issue_query.v3.diff">issue_query.v3.diff</a> added</li><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul><p>pluck(:id) in IssueQuery#version_ids is missing.</p> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=807022017-08-18T17:01:36Zjwjw yy
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=807032017-08-18T17:50:28ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>New</i></li></ul> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=862142018-07-15T23:53:38Zjwjw yy
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>Removed advertisement -- <a href="https://www.redmine.org/users/2784" class="external">Holger Just</a></p> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=862212018-07-16T11:52:25ZHolger Just
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>New</i></li></ul> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=924922019-06-20T13:56:18ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.2.0</i></li></ul><p>Need some work to avoid duplicate code with <code>IssueQuery#versions</code>.</p> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=1013042021-03-12T08:38:35ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>4.2.0</i> to <i>Candidate for next major release</i></li></ul> Redmine - Patch #26714: pluck instead of map in issue_queryhttps://www.redmine.org/issues/26714?journal_id=1123532024-01-20T08:39:29ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> deleted (<del><i>Candidate for next major release</i></del>)</li></ul><p>The <code>map</code> was replaced with <code>pluck</code> in <a class="changeset" title="Allow to filter issues by its version status with shared versions (#36824, #30924). Patch by Hol..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21499">r21499</a>.</p>