https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-12-21T10:21:35ZRedmineRedmine - Feature #27831: ATOM Feed for repository changeshttps://www.redmine.org/issues/27831?journal_id=827342017-12-21T10:21:35ZFelix Schäfer
<ul><li><strong>File</strong> <a href="/attachments/19771">27831.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19771/27831.patch">27831.patch</a> added</li></ul><p>The attached patch adds an ATOM feed for the "revisions/changes" view.</p> Redmine - Feature #27831: ATOM Feed for repository changeshttps://www.redmine.org/issues/27831?journal_id=827432017-12-22T01:29:11ZGo MAEDA
<ul><li><strong>Category</strong> set to <i>Feeds</i></li></ul> Redmine - Feature #27831: ATOM Feed for repository changeshttps://www.redmine.org/issues/27831?journal_id=829232018-01-05T03:30:04ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/19828">27831-error-log.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19828/27831-error-log.txt">27831-error-log.txt</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li></ul><p>With the patch applied to the latest trunk <a class="changeset" title="Show default status on trackers/index view (#27219). Patch by Tomomi Yuzuriha." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17140">r17140</a>, I encountered the following error when I opened RepositoriesController#changes page. Could you take a look at it?</p>
<pre>
ActionView::Template::Error (unable to convert unpermitted parameters to hash):
22: <% end %>
23:
24: <% other_formats_links do |f| %>
25: <%= f.link_to 'Atom', :url => params.merge({:key => User.current.rss_key}) %>
26: <% end %>
27:
28: <% html_title(l(:label_change_plural)) -%>
lib/redmine/views/other_formats_builder.rb:26:in `merge'
lib/redmine/views/other_formats_builder.rb:26:in `link_to'
app/views/repositories/changes.html.erb:25:in `block in _app_views_repositories_changes_html_erb___3745583827616173410_70126154703040'
app/helpers/application_helper.rb:526:in `other_formats_links'
app/views/repositories/changes.html.erb:24:in `_app_views_repositories_changes_html_erb___3745583827616173410_70126154703040'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
</pre>
<p>Error log: <a class="attachment" href="https://www.redmine.org/attachments/19828">27831-error-log.txt</a></p> Redmine - Feature #27831: ATOM Feed for repository changeshttps://www.redmine.org/issues/27831?journal_id=829762018-01-08T23:01:10ZFelix Schäfer
<ul><li><strong>File</strong> <a href="/attachments/19850">27831-master.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19850/27831-master.patch">27831-master.patch</a> added</li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>With the patch applied to the latest trunk <a class="changeset" title="Show default status on trackers/index view (#27219). Patch by Tomomi Yuzuriha." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17140">r17140</a>, I encountered the following error when I opened RepositoriesController#changes page. Could you take a look at it?</p>
</blockquote>
<p>I can confirm the error, it seems there have been more changes regarding ATOM feeds in master than I thought. The previous patch I provided should work with current stable, not current trunk/master.</p>
<p>I have adapted the patch for master, please find the patch attached.</p> Redmine - Feature #27831: ATOM Feed for repository changeshttps://www.redmine.org/issues/27831?journal_id=830442018-01-11T06:32:10ZGo MAEDA
<ul></ul><p>Felix, thank you for updating the patch. But I have not got atom feed yet.</p>
<p>I tested the patch with Redmine's bundled test fixtures and repositories. I get "404 The entry or revision was not found in the repository" error when I click "Atom" link on the changes page (e.g. /projects/ecookbook/repository/changes/subversion_test/helloworld.c).</p>
<p>I noticed two things while seeing the log. First, there is a line "Processing by .... as HTML". I think "HTML" should be "ATOM" because I tried to get an Atom feed. Second, the "path" parameter has a strange extension ".c.atom". Probably it should be ".c".</p>
<pre>
Started GET "/projects/ecookbook/repository/changes/subversion_test/helloworld.c
.atom?key=253fb4856f8f7518efd462d9c41a8791be24698b" for 127.0.0.1 at 2018-01-11
05:54:29 +0000
Processing by RepositoriesController#changes as HTML
Parameters: {"key"=>"253fb4856f8f7518efd462d9c41a8791be24698b", "id"=>"ecookbo
ok", "path"=>"subversion_test/helloworld.c.atom"}
.
(snip)
.
Completed 404 Not Found in 137ms (Views: 81.1ms | ActiveRecord: 9.9ms)
</pre> Redmine - Feature #27831: ATOM Feed for repository changeshttps://www.redmine.org/issues/27831?journal_id=955402020-01-07T01:37:51ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/24557">27831-fixed.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24557/27831-fixed.patch">27831-fixed.patch</a> added</li></ul><p>I fixed Felix's patch <a class="attachment" href="https://www.redmine.org/attachments/19850">27831-master.patch</a> (mainly config/routes.rb). I attached a fixed patch.</p>
<p>Go MAEDA wrote:</p>
<blockquote>
<p>I tested the patch with Redmine's bundled test fixtures and repositories. I get "404 The entry or revision was not found in the repository" error when I click "Atom" link on the changes page (e.g. /projects/ecookbook/repository/changes/subversion_test/helloworld.c).</p>
</blockquote>
<p>I did a similar test. The ATOM feed has been output.</p>
<pre>
Started GET "/projects/ecookbook/repository/10/changes/subversion_test/helloworld.c.atom?key=0bff9fd16476ad80fac510da47667ac16c2acb43" for 127.0.0.1 at 2020-01-07 09:37:29 +0900
Processing by RepositoriesController#changes as ATOM
Parameters: {"key"=>"0bff9fd16476ad80fac510da47667ac16c2acb43", "id"=>"ecookbook", "repository_id"=>"10", "path"=>"subversion_test/helloworld.c"}
..
Rendering common/feed.atom.builder
(snip)
Rendered common/feed.atom.builder (19.8ms)
..
Completed 200 OK in 85ms (Views: 21.2ms | ActiveRecord: 4.9ms)
</pre> Redmine - Feature #27831: ATOM Feed for repository changeshttps://www.redmine.org/issues/27831?journal_id=957242020-01-14T10:16:05ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul>