https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-04-17T10:49:10ZRedmineRedmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=845502018-04-17T10:49:10ZGuillermo ML
<ul></ul><p>I can confirm this behaviour on 3.3.1.stable, 3.4.3.stable and 3.4.4.stable<br />The number of blank lines after each note seems to be identical to the number of lines of text in the note.</p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=847482018-04-30T00:40:45ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul><p>Reproducible in the current trunk (<a class="changeset" title="Copy wiki attachments on project copy (#10282). Patch by Mizuki ISHIKAWA." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17315">r17315</a>).</p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=864022018-08-01T02:28:24ZTyler Nguyen
<ul></ul><p>I'm not a professional programmer. Hope someone can help me solve this problem, it is also quite important.</p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=864232018-08-02T05:36:03ZBernhard Rohloff
<ul><li><strong>File</strong> <a href="/attachments/21170">fix_height_of_line_break_in_issue_pdf.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21170/fix_height_of_line_break_in_issue_pdf.diff">fix_height_of_line_break_in_issue_pdf.diff</a> added</li><li><strong>File</strong> <a href="/attachments/21171">ecookbook-2.pdf</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21171/ecookbook-2.pdf">ecookbook-2.pdf</a> added</li></ul><p>The behavior is caused by <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/lib/redmine/export/pdf/issues_pdf_helper.rb#L234">source:trunk/lib/redmine/export/pdf/issues_pdf_helper.rb#L234</a><br />After each comment block the method <code>pdf.ln</code> gets called without an argument. In this case the space height is equal to the last block.<br /><a class="external" href="https://www.rubydoc.info/gems/rbpdf/1.18.3/RBPDF:Ln">https://www.rubydoc.info/gems/rbpdf/1.18.3/RBPDF:Ln</a></p>
<p>I've attached a patch to set the height to what I think is an appropriate value.</p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=864292018-08-02T08:36:17ZBernhard Rohloff
<ul><li><strong>File</strong> <a href="/attachments/21173">fix_height_of_line_break_in_issue_pdf_v2.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21173/fix_height_of_line_break_in_issue_pdf_v2.diff">fix_height_of_line_break_in_issue_pdf_v2.diff</a> added</li></ul><p>I've found the same behavior for associated revisions and comments after journal entries.<br />Attached is a second patch to fix also these whitespace issues.<br />The spacings meet my esthetical reqiurements but feedback on this is hearty welcomed. :-)</p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=865152018-08-07T04:37:02ZBernhard Rohloff
<ul><li><strong>File</strong> <a href="/attachments/21202">pdf_formatting_before_and_after.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21202/pdf_formatting_before_and_after.png">pdf_formatting_before_and_after.png</a> added</li></ul><p>This is the result of my patch but it's quite difficult to show how it looks in a document...<br /><img src="https://www.redmine.org/attachments/download/21202/pdf_formatting_before_and_after.png" alt="" /></p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=865202018-08-07T05:28:06ZMarius BÄ‚LTEANU
<ul></ul><p>LGTM</p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=867012018-08-20T22:51:34ZJun NAITOH
<ul></ul><p>I think this is a problem of rbpdf.<br />Please wait for a while because we are working on correcting it.</p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=867022018-08-21T03:38:40ZBernhard Rohloff
<ul></ul><p>Jun NAITOH wrote:</p>
<blockquote>
<p>I think this is a problem of rbpdf.<br />Please wait for a while because we are working on correcting it.</p>
</blockquote>
<p>Do you think this is a bug or do you want to change the default behavior of the pdf.ln method?<br />Because as I wrote in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: PDF export has too many whitespaces (Closed)" href="https://www.redmine.org/issues/28565#note-6">#28565-6</a> that's the exact default behavior described in the rbpdf documentation.</p>
<blockquote>
<p>... By default, the value equals the height of the last printed cell.</p>
</blockquote> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=867202018-08-22T14:01:43ZJun NAITOH
<ul><li><strong>File</strong> <a href="/attachments/21302">rbpdf_cell.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21302/rbpdf_cell.png">rbpdf_cell.png</a> added</li><li><strong>File</strong> <a href="/attachments/21303">rbpdf_multi_cell.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21303/rbpdf_multi_cell.png">rbpdf_multi_cell.png</a> added</li></ul><p>Bernhard Rohloff wrote:</p>
<blockquote>
<p>Jun NAITOH wrote:</p>
<blockquote>
<p>I think this is a problem of rbpdf.<br />Please wait for a while because we are working on correcting it.</p>
</blockquote>
<p>Do you think this is a bug or do you want to change the default behavior of the pdf.ln method?</p>
</blockquote>
<p>Yes, I think it is a bug in rbpdf.</p>
<blockquote>
<p>Because as I wrote in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: PDF export has too many whitespaces (Closed)" href="https://www.redmine.org/issues/28565#note-6">#28565-6</a> that's the exact default behavior described in the rbpdf documentation.</p>
<blockquote>
<p>... By default, the value equals the height of the last printed cell.</p>
</blockquote></blockquote>
<p>By default, the value is intended to be the height of the last printed cell.<br />However, the current implementation has become the height of the last printed by MultiCell.</p>
<p>This means the height of multiple rows(MultiCell), but the expected specification is the height of one rows (Cell = charactor's hight).</p>
<p><img src="https://www.redmine.org/attachments/download/21302/rbpdf_cell.png" alt="" /></p>
<p><img src="https://www.redmine.org/attachments/download/21303/rbpdf_multi_cell.png" alt="" /></p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=878532018-10-05T23:47:30ZJun NAITOH
<ul><li><strong>File</strong> <a href="/attachments/21576">rbpdf_1_19_5__1_19_6.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21576/rbpdf_1_19_5__1_19_6.png">rbpdf_1_19_5__1_19_6.png</a> added</li><li><strong>File</strong> <a href="/attachments/21577">test-6_rbpdf_1_19_5.pdf</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21577/test-6_rbpdf_1_19_5.pdf">test-6_rbpdf_1_19_5.pdf</a> added</li><li><strong>File</strong> <a href="/attachments/21578">test-6_rbpdf_1_19_6.pdf</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21578/test-6_rbpdf_1_19_6.pdf">test-6_rbpdf_1_19_6.pdf</a> added</li><li><strong>File</strong> <a href="/attachments/21579">Wiki_rbpdf_1_19_5.pdf</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21579/Wiki_rbpdf_1_19_5.pdf">Wiki_rbpdf_1_19_5.pdf</a> added</li><li><strong>File</strong> <a href="/attachments/21580">Wiki_rbpdf_1_19_6.pdf</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21580/Wiki_rbpdf_1_19_6.pdf">Wiki_rbpdf_1_19_6.pdf</a> added</li></ul><p>I'm sorry it takes time to fix it.<br />This problem fixed by rbpdf 1.19.6.<br />please bundle update.</p>
<p>The fixed issues is as follows.</p>
<p><a class="external" href="https://github.com/naitoh/rbpdf/issues/47">https://github.com/naitoh/rbpdf/issues/47</a></p>
<p><img src="https://www.redmine.org/attachments/download/21576/rbpdf_1_19_5__1_19_6.png" alt="" /></p> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=878552018-10-06T00:12:18ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul> Redmine - Defect #28565: PDF export has too many whitespaceshttps://www.redmine.org/issues/28565?journal_id=878562018-10-06T00:23:29ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>PDF export has too many whitespace</i> to <i>PDF export has too many whitespaces</i></li><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>3.3.9</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Updated the Gemfile in the repository. Thank you for working hard on fixing this issue.</p>