https://www.redmine.org/
https://www.redmine.org/favicon.ico?1679302129
2018-06-02T02:14:15Z
Redmine
Redmine - Defect #28931: Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project
https://www.redmine.org/issues/28931?journal_id=85336
2018-06-02T02:14:15Z
Go MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/28933">Patch #28933</a>: Migrate to Rails 5.2</i> added</li></ul>
Redmine - Defect #28931: Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project
https://www.redmine.org/issues/28931?journal_id=85489
2018-06-09T05:01:41Z
Go MAEDA
<ul></ul><p>I think it is better to modify the test to work rather than simply deleting it.</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: test/functional/issues_controller_test.rb
===================================================================
</span><span class="gd">--- test/functional/issues_controller_test.rb (revision 17367)
</span><span class="gi">+++ test/functional/issues_controller_test.rb (working copy)
</span><span class="p">@@ -5967,10 +5967,11 @@</span>
def test_bulk_copy_to_another_project
@request.session[:user_id] = 2
<span class="gd">- assert_difference 'Issue.count', 2 do
</span><span class="gi">+ issue_ids = [1, 2]
+ assert_difference 'Issue.count', issue_ids.size do
</span> assert_no_difference 'Project.find(1).issues.count' do
post :bulk_update, :params => {
<span class="gd">- :ids => [1, 2],
</span><span class="gi">+ :ids => issue_ids,
</span> :issue => {
:project_id => '2'
},
<span class="p">@@ -5980,7 +5981,7 @@</span>
end
assert_redirected_to '/projects/ecookbook/issues'
- copies = Issue.order('id DESC').limit(issues.size)
<span class="gi">+ copies = Issue.order('id DESC').limit(issue_ids.size)
</span> copies.each do |copy|
assert_equal 2, copy.project_id
end
</code></pre>
Redmine - Defect #28931: Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project
https://www.redmine.org/issues/28931?journal_id=85497
2018-06-10T00:18:17Z
Go MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li><li><strong>Subject</strong> changed from <i>[Rails 5.2] fix spec test_bulk_copy_to_another_project</i> to <i>Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Target version</strong> set to <i>4.0.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed in <a class="changeset" title="Fix: Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17372">r17372</a>. Thank you for reporting this issue.</p>
Redmine - Defect #28931: Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project
https://www.redmine.org/issues/28931?journal_id=85498
2018-06-10T00:21:42Z
Go MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul>
Redmine - Defect #28931: Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project
https://www.redmine.org/issues/28931?journal_id=85766
2018-06-23T05:26:14Z
Go MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/23630">Feature #23630</a>: Migrate to Rails 5.2</i> added</li></ul>
Redmine - Defect #28931: Unreachable code in QueriesControllerTest#test_bulk_copy_to_another_project
https://www.redmine.org/issues/28931?journal_id=85769
2018-06-23T05:26:22Z
Go MAEDA
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/28933">Patch #28933</a>: Migrate to Rails 5.2</i>)</li></ul>