https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-06-03T22:49:28ZRedmineRedmine - Patch #28939: replace regexp with casecmphttps://www.redmine.org/issues/28939?journal_id=853592018-06-03T22:49:28ZPavel Rosický
<ul><li><strong>File</strong> <a href="/attachments/20815">nested_set.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20815/nested_set.patch">nested_set.patch</a> added</li></ul> Redmine - Patch #28939: replace regexp with casecmphttps://www.redmine.org/issues/28939?journal_id=853602018-06-03T23:44:51ZGo MAEDA
<ul></ul><p>The proposed patch does not work for MySQL adapter because its name is "Mysql2". I think using exact match against adapter names is not a good solution.</p>
<pre>
irb(main):001:0> ActiveRecord::Base.connection.adapter_name
=> "Mysql2"
</pre> Redmine - Patch #28939: replace regexp with casecmphttps://www.redmine.org/issues/28939?journal_id=853622018-06-04T00:19:36ZPavel Rosický
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>ah, sorry. I totaly forgot about this case. I used match? insted in<br /><a class="external" href="http://www.redmine.org/issues/28940">http://www.redmine.org/issues/28940</a></p>
<p>so the behaviour won't be changed. Closing this one</p> Redmine - Patch #28939: replace regexp with casecmphttps://www.redmine.org/issues/28939?journal_id=853672018-06-04T01:28:31ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/28940">Patch #28940</a>: Use Regexp#match? to reduce allocations of MatchData object</i> added</li></ul> Redmine - Patch #28939: replace regexp with casecmphttps://www.redmine.org/issues/28939?journal_id=853692018-06-04T01:31:07ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Pavel Rosický wrote:</p>
<blockquote>
<p>I used match? insted in<br /><a class="external" href="http://www.redmine.org/issues/28940">http://www.redmine.org/issues/28940</a></p>
</blockquote>
<p>Closing this issue because <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Use Regexp#match? to reduce allocations of MatchData object (Closed)" href="https://www.redmine.org/issues/28940">#28940</a> covers this improvement. Thank you.</p>