https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-06-20T00:33:45ZRedmineRedmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=856692018-06-20T00:33:45ZMizuki ISHIKAWA
<ul></ul><p>I think that you can realize that feature by adding this one line.<br /><pre>
<code class="diff syntaxhl"><span class="gh">diff --git a/app/views/users/_mail_notifications.html.erb b/app/views/users/_mail_notifications.html.erb
index 7d253f7e8d..9dc4355ec4 100644
</span><span class="gd">--- a/app/views/users/_mail_notifications.html.erb
</span><span class="gi">+++ b/app/views/users/_mail_notifications.html.erb
</span><span class="p">@@ -18,6 +18,7 @@</span>
) + ' ' + h(project.name)
)
end %>
<span class="gi">+ <p><%= check_all_links('notified-projects') %></p>
</span> <%= hidden_field_tag 'user[notified_project_ids][]', '' %>
<p><em class="info"><%= l(:text_user_mail_option) %></em></p>
<% end %>
</code><br /></pre></p> Redmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=856702018-06-20T00:36:20ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/20913">screenshot.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20913/screenshot.png">screenshot.png</a> added</li></ul><p>This is a nice feature for those who need to see many projects.<br /><img src="https://www.redmine.org/attachments/download/20913/screenshot.png" style="width: 70%;border: 1px solid #ccc;" alt="" /></p> Redmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=856712018-06-20T01:11:45ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>3.4.7</i></li></ul><p>Mizuki ISHIKAWA wrote:</p>
<blockquote>
<p>I think that you can realize that feature by adding this one line.<br />[...]</p>
</blockquote>
<p>Thank you for posting the patch so quickly.</p>
<p>Setting target version to 3.4.7.</p> Redmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=856732018-06-20T02:31:48ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/20914">projects-fieldset@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20914/projects-fieldset@2x.png">projects-fieldset@2x.png</a> added</li></ul><p>Mizuki ISHIKAWA, maybe it would be better to use a green tick icon which is used on other pages. What do you think about this idea?</p>
<p><img src="https://www.redmine.org/attachments/download/20914/projects-fieldset@2x.png" srcset="https://www.redmine.org/attachments/download/20914/projects-fieldset@2x.png 2x" style="width: 370px;border: 1px solid #ccc;" alt="" /></p> Redmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=856742018-06-20T02:39:19ZMizuki ISHIKAWA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Mizuki ISHIKAWA, maybe it would be better to use a green tick icon which is used on other pages. What do you think about this idea?</p>
</blockquote>
<p>I suggested <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add check/unchek all icon in "Email notifications" section on "My account" page (Closed)" href="https://www.redmine.org/issues/29053#note-1">#29053#note-1</a> because I did not have the idea of enclosing with a fieldset.<br />The green tick icon is used frequently on other screens, so I think that the layout you suggested is better.</p> Redmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=856892018-06-20T23:39:35ZMizuki ISHIKAWA
<ul></ul><p>By applying the following code, <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add check/unchek all icon in "Email notifications" section on "My account" page (Closed)" href="https://www.redmine.org/issues/29053#note-4">#29053#note-4</a> layout can be realized.</p>
<pre>
<code class="diff syntaxhl"><span class="gh">diff --git a/app/views/users/_mail_notifications.html.erb b/app/views/users/_mail_notifications.html.erb
index 7d253f7e8d..96340dc055 100644
</span><span class="gd">--- a/app/views/users/_mail_notifications.html.erb
</span><span class="gi">+++ b/app/views/users/_mail_notifications.html.erb
</span><span class="p">@@ -7,6 +7,7 @@</span>
:onchange => 'if (this.value == "selected") {$("#notified-projects").show();} else {$("#notified-projects").hide();}'
) %>
</p>
<span class="gi">+<fieldset class="box" id="notified-project-ids"><legend><%= toggle_checkboxes_link("#notified-project-ids input[type=checkbox]") %><%=l(:label_project_plural)%></legend>
</span> <%= content_tag 'div', :id => 'notified-projects', :style => (@user.mail_notification == 'selected' ? '' : 'display:none;') do %>
<%= render_project_nested_lists(@user.projects) do |project|
content_tag('label',
<span class="p">@@ -21,6 +22,7 @@</span>
<%= hidden_field_tag 'user[notified_project_ids][]', '' %>
<p><em class="info"><%= l(:text_user_mail_option) %></em></p>
<% end %>
<span class="gi">+</fieldset>
</span>
<%= fields_for :pref, @user.pref do |pref_fields| %>
<p>
</code><br /></pre> Redmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=856952018-06-21T04:23:37ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>3.4.7</i> to <i>4.1.0</i></li></ul><p>I slightly updated the patch in <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add check/unchek all icon in "Email notifications" section on "My account" page (Closed)" href="https://www.redmine.org/issues/29053#note-6">#29053#note-6</a>. The previous patch shows an empty "Projects" box when other than "For any event on the selected projects only..." is selected.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/views/users/_mail_notifications.html.erb b/app/views/users/_mail_notifications.html.erb
index 7d253f7e8..85842de56 100644
</span><span class="gd">--- a/app/views/users/_mail_notifications.html.erb
</span><span class="gi">+++ b/app/views/users/_mail_notifications.html.erb
</span><span class="p">@@ -7,7 +7,8 @@</span>
:onchange => 'if (this.value == "selected") {$("#notified-projects").show();} else {$("#notified-projects").hide();}'
) %>
</p>
<span class="gd">-<%= content_tag 'div', :id => 'notified-projects', :style => (@user.mail_notification == 'selected' ? '' : 'display:none;') do %>
</span><span class="gi">+<%= content_tag 'fieldset', :id => 'notified-projects', :style => (@user.mail_notification == 'selected' ? '' : 'display:none;') do %>
+ <legend><%= toggle_checkboxes_link("#notified-projects input[type=checkbox]") %><%=l(:label_project_plural)%></legend>
</span> <%= render_project_nested_lists(@user.projects) do |project|
content_tag('label',
check_box_tag(
</pre></code></pre> Redmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=857042018-06-21T09:22:52ZGo MAEDA
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/29080">Feature #29080</a>: Add check/uncheck all icon in "Copy" section on copy_project page</i> added</li></ul> Redmine - Feature #29053: Add check/unchek all icon in "Email notifications" section on "My account" pagehttps://www.redmine.org/issues/29053?journal_id=857282018-06-22T03:15:40ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.0.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed. Thank you for improving Redmine.</p>