https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-10-23T09:43:22ZRedmineRedmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=880792018-10-23T09:43:22ZJens Krämerjk@jkraemer.net
<ul><li><strong>File</strong> <i>0002-small-refactoring-moves-the-method-to-find-the-activ.patch</i> added</li></ul><p>updated version of the second patch, better method name to match the setting</p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=880832018-10-24T04:07:34ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=881122018-10-27T02:12:15ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=910572019-04-01T14:28:39ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li></ul><p>The test fails in my environment.</p>
<pre>
Failure:
ChangesetTest#test_ref_keywords_any_with_timelog [test/unit/changeset_test.rb:142]:
Expected false to be truthy.
bin/rails test test/unit/changeset_test.rb:106
</pre> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=939722019-09-27T08:40:53ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>Candidate for next major release</i></li></ul><p>Removing from 4.1.0 because the test fails.</p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=961802020-02-10T09:19:22ZJens Krämerjk@jkraemer.net
<ul></ul><p>I just applied both patches to current master and all changeset tests pass. Could you please retry / post some logs?</p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=961812020-02-10T09:25:37ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0002-small-refactoring-moves-the-method-to-find-the-activ.patch</i></del>)</li></ul> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=961822020-02-10T09:41:18ZMarius BĂLTEANU
<ul></ul><p>Jens Krämer wrote:</p>
<blockquote>
<p>I just applied both patches to current master and all changeset tests pass. Could you please retry / post some logs?</p>
</blockquote>
<p>I've added your patches to my Gitlab CI instance used by me to run the tests and it fails only on MySQL: <a class="external" href="https://gitlab.com/redmine-org/redmine/-/jobs/431381873">https://gitlab.com/redmine-org/redmine/-/jobs/431381873</a><br />Also, the patches introduce a new Rubocop violation that should be fixed: <a class="external" href="https://gitlab.com/redmine-org/redmine/-/jobs/431381872">https://gitlab.com/redmine-org/redmine/-/jobs/431381872</a></p>
<p>You can see the pipeline here: <a class="external" href="https://gitlab.com/redmine-org/redmine/pipelines/116431745">https://gitlab.com/redmine-org/redmine/pipelines/116431745</a></p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=961892020-02-10T13:59:56ZJens Krämerjk@jkraemer.net
<ul></ul><p>thats really interesting as I ran my tests against MySQL (5.6) as well. can i see the exact environment in terms of ruby / mysql version somewhere on gitlab?</p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=961902020-02-10T14:16:20ZMarius BĂLTEANU
<ul></ul><p>Jens Krämer wrote:</p>
<blockquote>
<p>thats really interesting as I ran my tests against MySQL (5.6) as well. can i see the exact environment in terms of ruby / mysql version somewhere on gitlab?</p>
</blockquote>
Yes, you can see in <code>.gitlab-ci.yml</code>:
<ul>
<li>ruby version: <a class="external" href="https://gitlab.com/redmine-org/redmine/-/blob/feature/29838/.gitlab-ci.yml#L1">https://gitlab.com/redmine-org/redmine/-/blob/feature/29838/.gitlab-ci.yml#L1</a></li>
<li>mysql version: <a class="external" href="https://gitlab.com/redmine-org/redmine/-/blob/feature/29838/.gitlab-ci.yml#L18">https://gitlab.com/redmine-org/redmine/-/blob/feature/29838/.gitlab-ci.yml#L18</a></li>
<li>postgres version: <a class="external" href="https://gitlab.com/redmine-org/redmine/-/blob/feature/29838/.gitlab-ci.yml#L26">https://gitlab.com/redmine-org/redmine/-/blob/feature/29838/.gitlab-ci.yml#L26</a></li>
</ul>
<p>I use MySQL 5.7 because the same version is used also by the CI system on redmine.org, see <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/Continuous_integration">Continuous_integration</a>.</p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=962062020-02-11T06:45:56ZJens Krämerjk@jkraemer.net
<ul><li><strong>File</strong> <a href="/attachments/24802">0001-fix-logging-time-via-a-commit-message-for-project-sp.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24802/0001-fix-logging-time-via-a-commit-message-for-project-sp.patch">0001-fix-logging-time-via-a-commit-message-for-project-sp.patch</a> added</li></ul><p>turns out it did not have anything to do with the MySQL version, it was just a race condition in the Changeset test suite due to the <code>commit_logtime_activity_id</code> setting sometimes being set from a previous test case. The attached combined patch fixes that and replaces all previous patches.</p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=962072020-02-11T08:21:14ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/24803">0002-Fix-Rubocop-offense-Rails-FindBy-Use-find_by-instead.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24803/0002-Fix-Rubocop-offense-Rails-FindBy-Use-find_by-instead.patch">0002-Fix-Rubocop-offense-Rails-FindBy-Use-find_by-instead.patch</a> added</li><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.0</i></li></ul><p>Jens Krämer wrote:</p>
<blockquote>
<p>turns out it did not have anything to do with the MySQL version, it was just a race condition in the Changeset test suite due to the <code>commit_logtime_activity_id</code> setting sometimes being set from a previous test case. The attached combined patch fixes that and replaces all previous patches.</p>
</blockquote>
<p>All tests pass now with the attached patch that fixes a Rubocop offense: <a class="external" href="https://gitlab.com/redmine-org/redmine/pipelines/116780713">https://gitlab.com/redmine-org/redmine/pipelines/116780713</a></p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=962082020-02-11T08:22:06ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0002-small-refactoring-moves-the-method-to-find-the-activ.patch</i></del>)</li></ul> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=962092020-02-11T08:22:09ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0001-fix-logging-time-via-a-commit-message-for-project-sp.patch</i></del>)</li></ul> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=962102020-02-11T13:34:00ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul><p>Committed the patches. Thank you for detecting and fixing this issue.</p> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=1014542021-03-18T21:47:26ZMarius BĂLTEANU
<ul><li><strong>Subject</strong> changed from <i>time logging via commit message does not work when the configured activity has been overridden on the project level</i> to <i>Time logging via commit message does not work when the configured activity has been overridden on the project level</i></li></ul> Redmine - Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project levelhttps://www.redmine.org/issues/29838?journal_id=1015742021-03-28T00:09:29ZGo MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul>