https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-11-25T00:04:37ZRedmineRedmine - Patch #30026: macros and textile at pdf export in custom fieldhttps://www.redmine.org/issues/30026?journal_id=884942018-11-25T00:04:37ZDirk Rudolph
<ul><li><strong>File</strong> <a href="/attachments/21865">issues_pdf_helper-redmine-3.4.6.rb.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21865/issues_pdf_helper-redmine-3.4.6.rb.patch">issues_pdf_helper-redmine-3.4.6.rb.patch</a> added</li></ul> Redmine - Patch #30026: macros and textile at pdf export in custom fieldhttps://www.redmine.org/issues/30026?journal_id=884952018-11-25T00:09:15ZDirk Rudolph
<ul><li><strong>File</strong> <a href="/attachments/21866">issues_pdf_helper-redmine-3.4.6_2sec_version.rb</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21866/issues_pdf_helper-redmine-3.4.6_2sec_version.rb">issues_pdf_helper-redmine-3.4.6_2sec_version.rb</a> added</li></ul><p>little optimizations</p> Redmine - Patch #30026: macros and textile at pdf export in custom fieldhttps://www.redmine.org/issues/30026?journal_id=885002018-11-25T04:30:33ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/21871">table-breaks-layout.pdf</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21871/table-breaks-layout.pdf">table-breaks-layout.pdf</a> added</li></ul><p>Thank you for the patch. But I noticed the following points:</p>
<ul>
<li>The values should be textilized only when the <code>text_formatting</code> attribute for the custom field is <code>true</code>. The patch always textilizes the value</li>
<li>Inserting a table breaks the layout. Please see the attached pdf (<a class="attachment" href="https://www.redmine.org/attachments/21871">table-breaks-layout.pdf</a>). Blank lines are inserted after the table</li>
</ul> Redmine - Patch #30026: macros and textile at pdf export in custom fieldhttps://www.redmine.org/issues/30026?journal_id=885052018-11-25T09:30:56ZDirk Rudolph
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<ul>
<li>The values should be textilized only when the <code>text_formatting</code> attribute for the custom field is <code>true</code>. The patch always textilizes the value</li>
</ul>
</blockquote>
<p>No, the used function show_value() seems to check that. I tried out.</p>
<blockquote>
<ul>
<li>Inserting a table breaks the layout. Please see the attached pdf (<a class="attachment" href="https://www.redmine.org/attachments/21871">table-breaks-layout.pdf</a>). Blank lines are inserted after the table</li>
</ul>
</blockquote>
<p>Yes is true. The table cell becomes bigger because the height is calculated over html code in the backround. I think it's better to have a big cell and the content fits into, instead a cell that's to small. But I will trie to optimize.</p> Redmine - Patch #30026: macros and textile at pdf export in custom fieldhttps://www.redmine.org/issues/30026?journal_id=885152018-11-25T13:21:04ZDirk Rudolph
<ul><li><strong>File</strong> <a href="/attachments/21873">issues_pdf_helper.rb-redmine-3.4.6_3rd.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21873/issues_pdf_helper.rb-redmine-3.4.6_3rd.patch">issues_pdf_helper.rb-redmine-3.4.6_3rd.patch</a> added</li></ul><p>Some optimizations for the layout. <br />For the cell height calculation, some html-strings will remove.</p> Redmine - Patch #30026: macros and textile at pdf export in custom fieldhttps://www.redmine.org/issues/30026?journal_id=885162018-11-25T15:40:19ZDirk Rudolph
<ul><li><strong>File</strong> <a href="/attachments/21874">issues_pdf_helper.rb-redmine-3.4.6_4th.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21874/issues_pdf_helper.rb-redmine-3.4.6_4th.patch">issues_pdf_helper.rb-redmine-3.4.6_4th.patch</a> added</li></ul><p>Further optimizations for issues list ...</p> Redmine - Patch #30026: macros and textile at pdf export in custom fieldhttps://www.redmine.org/issues/30026?journal_id=914282019-04-29T11:22:32ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul>