https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-01-15T17:51:11ZRedmineRedmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894172019-01-15T17:51:11ZMarius BĂLTEANU
<ul><li><strong>Subject</strong> changed from <i>Change #main block to a flexbox + additional minor fixer to it's direct children.</i> to <i>Change #main block to a flexbox + additional minor fixes to it's direct children.</i></li></ul> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894312019-01-16T09:11:54ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul><p>It looks nice. Setting the target version to 4.1.0.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894322019-01-16T09:17:29ZMarius BĂLTEANU
<ul></ul><p>Please do not commit because I want to test more these changes. I looked yesterday for few seconds and I saw some problems.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894332019-01-16T09:24:18ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894342019-01-16T09:24:58ZBernhard Rohloff
<ul></ul><p>The patch looks good to me, although I'm not sure if the width is sufficient for the text length of everbody's saved queries. It also wraps the heading of "Custom queries" if you choose German ( it's "Benutzerdefinierte Abfragen" ) as interface language. No big deal to me but I think it's worth mentioning.</p>
<p>Overall, I think the patch is a great improvement.</p>
<p>+1</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894352019-01-16T09:30:06ZAnonymous
<ul></ul><p>I'm also wondering about the nature of this rule, does anybody have idea what it should do? <br /><pre>
* html #content{ width: 75%; padding-left: 0; margin-top: 0px; padding: 6px 10px 10px 10px;}
</pre></p>
<p>because in the default version, just one line above it would already be defined as:</p>
<pre>
#content{ width: 75%; padding-left: 0; margin-top: 0px; padding: 6px 10px 10px 10px;}
</pre>
<p>I have a feeling, Internet Explorer is guilty :)</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894582019-01-16T23:46:12ZMarius BĂLTEANU
<ul></ul><p>In my environment, the #content loads first with 100% width and right after, the sidebar which makes the screen "shakes".</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894622019-01-17T06:46:50ZAnonymous
<ul><li><strong>File</strong> <a href="/attachments/22242">main-block-fixes-no-swap.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22242/main-block-fixes-no-swap.diff">main-block-fixes-no-swap.diff</a> added</li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>In my environment, the #content loads first with 100% width and right after, the sidebar which makes the screen "shake".</p>
</blockquote>
<p>Marius, I looked into it, so I'm attaching alternative patch without element swapping in <strong>base.html.erb</strong> to see if this one will not spawn shaking, the previous patch must be reverted before applying this one.</p>
<p>The alternative method could as well be to set #main a <strong>flow-direction: row;</strong> instead of <strong>row-reverse</strong> and than add <strong>order: 1;</strong> for the #content and <strong>order: 2;</strong> for the #sidebar, but I guess this isn't needed now, because we only have 2 containers, but it could be useful if we re to spawn an additional tile under the sidebar in the future for instance, else in the favor of less rules, it is imho just be simpler to reverse it. :)</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894782019-01-17T20:36:32ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/22253">sidebar.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22253/sidebar.png">sidebar.png</a> added</li></ul><p>Thanks Max for updating the patch, it works well with row-reverse.</p>
<p>I agree with Bernhard, the sidebar width (220px) is too small even for small screens, please see the below screenshot from my 13 inch screen:</p>
<p>1. width: 220px;<br /><img src="https://www.redmine.org/attachments/download/22253/sidebar.png" style="border: 1px solid grey;" alt="" /></p>
<p>What do you think if we keep the existing <code>width: 22%</code> rule and we add a max-width of 280px or 300px?</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=894952019-01-18T09:08:28ZAnonymous
<ul></ul><p>I think <strong>width: 22%</strong> will anyway often exceed it's maximum limitation of max-width, maybe we could try min-width: 220px and max-width: 280px or 300px?<br />In theory sidebar's content should then expand the sidebar in width within these margins a bit depending on what it contains. :)</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=895372019-01-20T13:34:11ZAnonymous
<ul></ul><p>There is a gridbox design suggestion now pending for further discussion, so this ticket will be affected if we will decide to move #main-menu inside #main container, ultimately making this patch obsolete, because it will then become a 3 tiled gridbox instead of a flexbox. Please see <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Move #main-menu outside of the #header to follow directly after the #header insetad (New)" href="https://www.redmine.org/issues/30451#note-6">#30451#note-6</a> for reference.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=895432019-01-21T06:25:44ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li></ul> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=898942019-02-08T23:41:51ZAnonymous
<ul><li><strong>File</strong> <a href="/attachments/22384">main-block-fixes-no-swap-min-max.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22384/main-block-fixes-no-swap-min-max.diff">main-block-fixes-no-swap-min-max.diff</a> added</li></ul><p>I think it will be better to ignore <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Move #main-menu outside of the #header to follow directly after the #header insetad (New)" href="https://www.redmine.org/issues/30451">#30451</a> for now, so attaching the patch with min-width and max-width rules for the sidebar, the content of the sidebar will now expand it up to 340px if contains long elements, if there is no need, it will reduce up to 220px. I think it's the most suitable resolution for everyone.<br />I also removed some redundant rules this time, like:<br /><pre>
* html #sidebar{ width: 22%; }
* html #content{ width: 75%; padding-left: 0; margin-top: 0px; padding: 6px 10px 10px 10px;}
</pre></p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=901272019-02-14T10:28:58ZGo MAEDA
<ul></ul><p>Max Johansson wrote:</p>
<blockquote>
<p>I think it will be better to ignore <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Move #main-menu outside of the #header to follow directly after the #header insetad (New)" href="https://www.redmine.org/issues/30451">#30451</a> for now, so attaching the patch with min-width and max-width rules for the sidebar, the content of the sidebar will now expand it up to 340px if contains long elements, if there is no need, it will reduce up to 220px.</p>
</blockquote>
<p>Thank you for the patch. Narrower sidebar than the current implementation should be nice for many people.</p>
<p>I tried the patch but I found that the sidebar hardly expands even if there is a custom query with a long name and the width of the browser window is around 1800px. With my Firefox, the width of the sidebar is 261px at 1024px window and 271px at 1800px window.</p>
<p>How can I see a sidebar with a width of 340px?</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=901322019-02-14T17:29:28ZBernhard Rohloff
<ul><li><strong>File</strong> <a href="/attachments/22412">main-block-fixes-no-swap-min-max_no_shrink.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22412/main-block-fixes-no-swap-min-max_no_shrink.diff">main-block-fixes-no-swap-min-max_no_shrink.diff</a> added</li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I tried the patch but I found that the sidebar hardly expands even if there is a custom query with a long name and the width of the browser window is around 1800px. With my Firefox, the width of the sidebar is 261px at 1024px window and 271px at 1800px window.</p>
<p>How can I see a sidebar with a width of 340px?</p>
</blockquote>
<p>I can confirm the behavior you described. I think is an issue with the flexbox constraints.<br />Here is a modified version of Max's patch which prevents the sidebar from shrinking. Can you check if it's working now?</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=904092019-02-25T06:28:16ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/22505">30435-screenshot-20190225.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22505/30435-screenshot-20190225.png">30435-screenshot-20190225.png</a> added</li></ul><p>I tested <a class="attachment" href="https://www.redmine.org/attachments/22412">main-block-fixes-no-swap-min-max_no_shrink.diff</a>.</p>
<p>When there is a query with a long name, the sidebar became too large even in small screens and the left side of the page is cropped.</p>
<p><img src="https://www.redmine.org/attachments/download/22505/30435-screenshot-20190225.png" style="border: 1px solid #ccc;" alt="" /></p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=904102019-02-25T08:12:43ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I tested <a class="attachment" href="https://www.redmine.org/attachments/22412">main-block-fixes-no-swap-min-max_no_shrink.diff</a>.</p>
<p>When there is a query with a long name, the sidebar became too large even in small screens and the left side of the page is cropped.</p>
</blockquote>
<p>It is because of the missing <code>width: 22%;</code> rule.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=904112019-02-25T09:50:55ZBernhard Rohloff
<ul></ul><p>The patch sets a min-width of 220px and a max-width of 340px for longer query names as it was constrained by Max in <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Replace float rules with flexbox for content and sidebar block (Closed)" href="https://www.redmine.org/issues/30435#note-13">#30435#note-13</a>.<br />By setting the width to 22% again we're loosing space on higher resolutions as the sidebar grows to its max-width even if there's no need to.<br />It can make a difference up to 120px which can give you an extra column in the issues list or an extra month on the gantt chart.</p>
<p>On the other hand I have to admit that 340px can be too big on small screens (37% @900px). It affects resolutions between 900px and around 1500px.<br />It just slightly affects the higher resolutions e.g. 1377px so should we consider to set the width only for smaller resolutions? What are your thoughts on this?</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=904212019-02-25T23:42:44ZAnonymous
<ul></ul><p>Bernhard Rohloff wrote:</p>
<blockquote>
<p>By setting the width to 22% again we're loosing space on higher resolutions as the sidebar grows to its max-width even if there's no need to.</p>
</blockquote>
<p>What I tried to explain in <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Replace float rules with flexbox for content and sidebar block (Closed)" href="https://www.redmine.org/issues/30435#note-10">#30435#note-10</a>, but thanks for doing it more clearly. :)</p>
<blockquote>
<p>On the other hand I have to admit that 340px can be too big on small screens (37% @900px). It affects resolutions between 900px and around 1500px.<br />It just slightly affects the higher resolutions e.g. 1377px so should we consider to set the width only for smaller resolutions? What are your thoughts on this?</p>
</blockquote>
<p>I propose to either:<br />1. Create adaptive rules then where we d set max width of the sidebar for different screen sizes/resolutions like so:<br /><a class="user active" href="https://www.redmine.org/users/24774">Иван Савенко</a> screen and (min-width: 1400px) {#sidebar{max-width:340px;}<br /><a class="user active" href="https://www.redmine.org/users/24774">Иван Савенко</a> screen and (min-width: 1200px) {#sidebar{max-width:280px;}<br /><a class="user active" href="https://www.redmine.org/users/24774">Иван Савенко</a> screen and (min-width: 1000px) {#sidebar{max-width:220px;}</p>
<p>I don't have different displays at the moment to test this, perhaps I'll have to do it with setting other lower resolutions of my 1920x1080 native display, I will post an update when tests will be done then and post the patch.</p>
<p>2. Limit the length of the names of custom queries instead and then skip all the adaptive rules.<br />3. Or move queries away from the sidebar into a more lucky location and again skip all the adaptiveness, because frankly IMHO sidebar isn't the most successful place for the menu objects which allow for ridiculously ultra-long titles.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=904572019-02-27T10:05:43ZBernhard Rohloff
<ul></ul><p>Max Johansson wrote:</p>
<blockquote>
<p>I propose to either:<br />1. Create adaptive rules then where we d set max width of the sidebar for different screen sizes/resolutions like so:<br /><a class="user active" href="https://www.redmine.org/users/24774">Иван Савенко</a> screen and (min-width: 1400px) {#sidebar{max-width:340px;}<br /><a class="user active" href="https://www.redmine.org/users/24774">Иван Савенко</a> screen and (min-width: 1200px) {#sidebar{max-width:280px;}<br /><a class="user active" href="https://www.redmine.org/users/24774">Иван Савенко</a> screen and (min-width: 1000px) {#sidebar{max-width:220px;}</p>
<p>I don't have different displays at the moment to test this, perhaps I'll have to do it with setting other lower resolutions of my 1920x1080 native display, I will post an update when tests will be done then and post the patch.</p>
</blockquote>
<p>Don't bother with fiddling around in your screen settings. You can test it easily with the builtin dev tools of you browser of choice. Nowadays they all have an option to test multiple screen sizes.<br />This is IMHO my prefered solution.</p>
<blockquote>
<p>2. Limit the length of the names of custom queries instead and then skip all the adaptive rules.</p>
</blockquote>
<p>I think this doesn't meet the requirements.</p>
<blockquote>
<p>3. Or move queries away from the sidebar into a more lucky location and again skip all the adaptiveness, because frankly IMHO sidebar isn't the most successful place for the menu objects which allow for ridiculously ultra-long titles.</p>
</blockquote>
<p>As im not a fan of the sidebar at all this would be my favorite solution. But it requires a lot more effort and discussion so I think this can't be an option for this feature, right now.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=909692019-03-27T22:50:47ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/22708">current.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22708/current.png">current.png</a> added</li><li><strong>File</strong> <a href="/attachments/22709">after.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22709/after.png">after.png</a> added</li><li><strong>File</strong> <a href="/attachments/22710">flex_for_content_and_sidebar.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22710/flex_for_content_and_sidebar.patch">flex_for_content_and_sidebar.patch</a> added</li></ul><p>Let move the discussions about the sidebar width to another ticket and commit the other changes that replace the float rules with flex. In this way, we fix an annoying bug on issue page that reproduces when the sidebar height is greater than the content height.</p>
<p>Current:<br /><img src="https://www.redmine.org/attachments/download/22708/current.png" style="max-width:70%;border: 1px solid grey;" alt="" /></p>
<p>With the patch applied:<br /><img src="https://www.redmine.org/attachments/download/22709/after.png" style="max-width:70%;border: 1px solid grey;" alt="" /></p>
<p>I'm attaching the patch that I would like to be committed, it contains the work done by Max and a small fix for the sidebar padding.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=910732019-04-02T11:04:21ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Change #main block to a flexbox + additional minor fixes to it's direct children.</i> to <i>Change #main block to a flexbox + additional minor fixes to it's direct children</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>In this way, we fix an annoying bug on issue page that reproduces when the sidebar height is greater than the content height.</p>
</blockquote>
<p>Nice. I have been bothered by the bug for years.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=910842019-04-02T23:25:38ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Change #main block to a flexbox + additional minor fixes to it's direct children</i> to <i>Replace float rules with flexbox for content and sidebar block</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul><p>Committed the fix. Thank you for working on this.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=914052019-04-28T10:47:37ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/22902">table-bug@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22902/table-bug@2x.png">table-bug@2x.png</a> added</li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>The change made in <a class="changeset" title="Replace float rules with flexbox for content and sidebar block (#30435). Patch by Max Johansson ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18033">r18033</a> breaks the layout of some pages on medium-sized screens.</p>
<p>To reproduce the problem, open /users page in a 1024px wide browser. The left side of the table is cropped and you cannot see the first name column.</p>
<p><img src="https://www.redmine.org/attachments/download/22902/table-bug@2x.png" srcset="https://www.redmine.org/attachments/download/22902/table-bug@2x.png 2x" style="width: 1008px;border: 1px solid #ccc;" alt="" /></p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=914102019-04-28T20:41:51ZMarius BĂLTEANU
<ul></ul><p>The below patch fixes the problem for me:</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index 09bcd5b..79cf1d0 100644
</span><span class="gd">--- a/public/stylesheets/application.css
</span><span class="gi">+++ b/public/stylesheets/application.css
</span><span class="p">@@ -92,7 +92,7 @@</span> pre, code {font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace;}
#sidebar div.wiki ul {margin:inherit; padding-left:40px;}
#sidebar div.wiki ul li {list-style-type:inherit;}
-#content { flex-grow: 1; background-color: #fff; margin: 0px; padding: 6px 10px 10px 10px; }
<span class="gi">+#content { flex-grow: 1; background-color: #fff; margin: 0px; padding: 6px 10px 10px 10px; overflow-x: auto;}
</span> html>body #content { min-height: 600px; }
* html body #content { height: 600px; } /* IE */
</code></pre>
<p><a class="user active" href="https://www.redmine.org/users/12917">Bernhard Ganslmeier</a>, is it ok for you this fix?</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=916112019-05-08T04:34:07ZYuichi HARADA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>The below patch fixes the problem for me:</p>
<p>[...]</p>
<p><a class="user active" href="https://www.redmine.org/users/12917">Bernhard Ganslmeier</a>, is it ok for you this fix?</p>
</blockquote>
<p>Thank you for sharing the patch.<br />I confirmed that the layout on medium-sized screens( <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Replace float rules with flexbox for content and sidebar block (Closed)" href="https://www.redmine.org/issues/30435#note-24">#30435#note-24</a>, /issues and /time_entries pages) does not break by applying your patch.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=916192019-05-08T07:56:03ZBernhard Rohloff
<ul></ul><p>I also tested the fix and it works for me, too.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=916212019-05-08T08:13:52ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Committed the fix submitted as <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Replace float rules with flexbox for content and sidebar block (Closed)" href="https://www.redmine.org/issues/30435#note-25">#30435#note-25</a> in <a class="changeset" title="Fix layout problem when showing wide tables (#30435). Patch by Marius BALTEANU." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18135">r18135</a>. Thank you.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=935042019-09-04T17:23:12ZAnonymous
<ul><li><strong>File</strong> <a href="/attachments/23779">responsive-multiresolution-sidebar.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23779/responsive-multiresolution-sidebar.patch">responsive-multiresolution-sidebar.patch</a> added</li></ul><p>To conclude the major point behind this issue, which never got resolved back then, here is a patch to try out as a reference to <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Replace float rules with flexbox for content and sidebar block (Closed)" href="https://www.redmine.org/issues/30435#note-19">#30435#note-19</a></p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=935172019-09-05T00:19:50ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=935872019-09-08T09:49:19ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Antonio McDeal wrote:</p>
<blockquote>
<p>To conclude the major point behind this issue, which never got resolved back then, here is a patch to try out as a reference to <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Replace float rules with flexbox for content and sidebar block (Closed)" href="https://www.redmine.org/issues/30435#note-19">#30435#note-19</a></p>
</blockquote>
<p>Thank you for posting the patch. I think the width of the sidebar should be discussed in another issue because the topic is really controversial as we experienced in this issue and it will be difficult to close this issue for a long time. In my opinion, I don't like the sidebar width with the patch applied because the width of the sidebar is wider than the current style at 1024px window width (I usually set the browser width to about 1000px - 1100px).</p>
<p>So, I close this issue. If anyone thinks the sidebar width should be improved with the approach suggested by the patch in <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Replace float rules with flexbox for content and sidebar block (Closed)" href="https://www.redmine.org/issues/30435#note-29">#30435#note-29</a>, please open a new issue.</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=935982019-09-08T16:03:37ZAnonymous
<ul></ul><p>I created a new issue <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Constrain sidebar width on different resolutions (Closed)" href="https://www.redmine.org/issues/32037">#32037</a>, please add it as related to this one, because part of important discussion was started in here. :)</p> Redmine - Patch #30435: Replace float rules with flexbox for content and sidebar blockhttps://www.redmine.org/issues/30435?journal_id=936002019-09-09T00:32:33ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32037">Patch #32037</a>: Constrain sidebar width on different resolutions</i> added</li></ul>