https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-01-20T07:18:18ZRedmineRedmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=895302019-01-20T07:18:18ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>What is the purpose of making the footer sticky? I don't see anything in the footer that needs to be always visible.</p> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=895342019-01-20T10:09:54ZAnonymous
<ul></ul><p>Jean-Philippe, apologies for vague description, what I mean by setting footer sticky, is for it to stick to the bottom of the page, while always expanding the #main block (or a wrapper) in 100% of available vertical height, unless the page's content needs more space.<br />I think it would be better than having footer ending up in the middle of the screen on pages where there is little or no content.<br />For reference please see the <strong>concept-gridbox-version.html</strong> file in the <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Move #main-menu outside of the #header to follow directly after the #header insetad (New)" href="https://www.redmine.org/issues/30451#note-6">#30451#note-6</a> and click "Insert Lorem ipsum" button multiple times while observing the footer to see what I propose :)</p> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=895572019-01-21T20:35:14ZMarius BĂLTEANU
<ul><li><strong>Subject</strong> changed from <i>Set footer sticky</i> to <i>Have footer stick to the bottom on pages with little content</i></li></ul> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=933392019-08-27T11:19:02ZBernhard Rohloff
<ul><li><strong>File</strong> <a href="/attachments/23712">full_height_layout.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23712/full_height_layout.diff">full_height_layout.diff</a> added</li><li><strong>File</strong> <a href="/attachments/23714">original_login_screen.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23714/original_login_screen.png">original_login_screen.png</a> added</li><li><strong>File</strong> <a href="/attachments/23713">patched_login_screen.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23713/patched_login_screen.png">patched_login_screen.png</a> added</li></ul><p>Here is a patch for the base layout to fill the visible space entirely. The footer always sticks to the bottom until the page is bigger than the visible height. It's quite pleasing for my eyes. The footer doesn't jump anymore when changing views.</p>
<p><b>Original login view</b><br /><img src="https://www.redmine.org/attachments/download/23714/original_login_screen.png" style="border: 1px solid #ccc;width: 600px;" alt="" /></p>
<p><b>With the patch applied</b><br /><img src="https://www.redmine.org/attachments/download/23713/patched_login_screen.png" style="border: 1px solid #ccc;width: 600px;" alt="" /></p> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=934672019-09-03T06:56:11ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul><p>Bernhard, I've tested your patch in several browsers (including IE 11 and Edge) and it works very well, nice job.</p>
<p>I would love to see this fixed in <a class="version" href="https://www.redmine.org/versions/127">4.1.0</a> along with <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Replace float rules with flexbox for content and sidebar block (Closed)" href="https://www.redmine.org/issues/30435">#30435</a>. It's very annoying to see the footer and the sidebar ended at 600px when there is not too much content in the page.</p> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=934862019-09-04T05:15:20ZBernhard Rohloff
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul><p>I had a chat with Go and it's OK for him, so LGTM! :-)</p> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=934982019-09-04T07:39:18ZGo MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li><li><strong>Subject</strong> changed from <i>Have footer stick to the bottom on pages with little content</i> to <i>Footer is not placed at the bottom on pages with little content</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you for your contribution.</p> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=936152019-09-09T19:50:20ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>I think it's safer to target the wrapper elements by their id instead of using "starting with":</p>
<pre><code class="diff syntaxhl"><span class="p">Mariuss-MacBook-Pro:redmine mariusbalteanu$ git diff
</span><span class="gh">diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index d5f1762e3..00ca660f0 100644
</span><span class="gd">--- a/public/stylesheets/application.css
</span><span class="gi">+++ b/public/stylesheets/application.css
</span><span class="p">@@ -11,7 +11,7 @@</span> h4 {border-bottom: 1px solid #ccc; font-weight:normal;}
pre, code {font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace;}
/***** Layout *****/
<span class="gd">-div[id^="wrapper"] { min-height: inherit; }
</span><span class="gi">+div#wrapper, div#wrapper2, div#wrapper3 { min-height: inherit; }
</span> #wrapper {background: white;overflow: hidden;}
#wrapper3 { display: flex; flex-direction: column; }
</code></pre>
<p><a class="user active" href="https://www.redmine.org/users/12917">Bernhard Ganslmeier</a>, do you see any problem with this change?</p> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=936402019-09-10T13:07:41ZBernhard Rohloff
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I think it's safer to target the wrapper elements by their id instead of using "starting with":</p>
<p>[...]</p>
<p><a class="user active" href="https://www.redmine.org/users/12917">Bernhard Ganslmeier</a>, do you see any problem with this change?</p>
</blockquote>
<p>No, you're right. wrapper is quite generic and could be used in more places.<br />I think it should be changed this way.</p> Redmine - Defect #30467: Footer is not placed at the bottom on pages with little contenthttps://www.redmine.org/issues/30467?journal_id=936532019-09-11T02:07:12ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I think it's safer to target the wrapper elements by their id instead of using "starting with":</p>
<p>[...]</p>
<p><a class="user active" href="https://www.redmine.org/users/12917">Bernhard Ganslmeier</a>, do you see any problem with this change?</p>
</blockquote>
<p>Committed the fix in <a class="changeset" title="Don't use ^= operator to target the wrapper elements (#30467). Patch by Marius BALTEANU." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18446">r18446</a>. Thanks.</p>