https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-02-21T02:48:41ZRedmineRedmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=903542019-02-21T02:48:41ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Option to parse HTML part of emails first</i> to <i>Option to parse HTML part of multipart (HTML) emails first</i></li></ul> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=903752019-02-22T04:48:26ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/22479">add_settings_incoming_emails.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22479/add_settings_incoming_emails.png">add_settings_incoming_emails.png</a> added</li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>In order to cope with such circumstance, I propose to add an option "Preferred part in HTML emails" to set the parsing order of multipart emails. The setting has two options, "Text" and "HTML". The first option is the default and keeps the current behavior of mail_handler (that means mail_handler tries to get text part first). When Admin chooses the second option "HTML", mail_handler tries to get HTML part first and converts the HTML to plain text. Text part is retrieved only when the email does not have HTML part.</p>
<ul>
<li>Setting name: "Preferred part in HTML emails" </li>
<li>Available options: "Text" (Default), "HTML"</li>
</ul>
</blockquote>
<p>The "Preferred part of multipart (HTML) emails" has been added to [Administration] > [Settings] > [Incoming emails].<br />I attached a patch.</p>
<p><img src="https://www.redmine.org/attachments/download/22479/add_settings_incoming_emails.png" style="width:500px;border:1px solid #ccc;" alt="" /></p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=903762019-02-22T04:52:49ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/22480">30838-preferred-part-multipart-email.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22480/30838-preferred-part-multipart-email.patch">30838-preferred-part-multipart-email.patch</a> added</li></ul><p>I forgot to attach a patch.</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=903862019-02-22T22:05:28ZMarius BĂLTEANU
<ul></ul><p>Do you see any side effect if we switch to HTML part first without adding a new setting?</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=903872019-02-23T08:28:37ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Do you see any side effect if we switch to HTML part first without adding a new setting?</p>
</blockquote>
<p>Maybe it is OK to read an HTML part first by default. It works without a big problem, I think. But I feel anxiety that some users will encounter unexpected behavior of the HTML email parser or some users don't like that converted text has Textile/Markdown markups such as bold, italic, underlines, and headings.</p>
<p>Therefore, I think we had better add an option to control which part is extracted. It does not have to be in the admin GUI. Adding a setting in the configuration.yml file is also OK.</p>
<p>The following is a summary of my post. Marius, what do you think?</p>
<ul>
<li>Reading an HTML part first is OK</li>
<li>We had better have an option to control the preferred part in the admin GUI or configuration.yml.</li>
</ul> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=903882019-02-23T10:06:56ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>The following is a summary of my post. Marius, what do you think?</p>
<ul>
<li>Reading an HTML part first is OK</li>
<li>We had better have an option to control the preferred part in the admin GUI or configuration.yml.</li>
</ul>
</blockquote>
<p>I agree, it is safer.</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=904232019-02-26T02:08:31ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/22519">30838-preferred-part-multipart-email-without-gui.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22519/30838-preferred-part-multipart-email-without-gui.patch">30838-preferred-part-multipart-email-without-gui.patch</a> added</li><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul><p>I modified the patch not to add a setting on the admin page. Instead, it reads the setting from configuration.yml. We can avoid increasing the complexity of the admin page.</p>
<p>I think that this setting should not be changed often or easily, so the configuration.yml may be a good place to put the setting.</p>
<p>We may change the default value to 'html' in the future version of Redmine but I think it is safer to stay in 'plain' in Redmine 4.1 because this unreleased feature is not widely tested and used yet in the production environments. Maybe it is better to mark this feature as "Experimental" like Markdown formatter introduced in Redmine 2.5 (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Markdown formatting (Closed)" href="https://www.redmine.org/issues/15520">#15520</a>).</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=904642019-02-27T23:20:53ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul><p>Setting the target version to 4.1.0.</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=904832019-02-28T17:48:08ZHolger Just
<ul></ul><p>If this setting is supposed to be configureable, I do think that it belongs on the Settings page rather than the <code>configuration.yml</code> file.</p>
<p>When considering the distinction between the "server administrator" who is responsible for the software itself and the Redmine administrator who is responsible for the projects and communication, I don't see this setting in the realm of the server administrator. Instead, i think it should be up to the Redmine administrator to decide based on the emails they receive whether to prefer one or the other option.</p>
<p>As for the feature itself, I'm in favour of seeing it added to Redmine (although I hate that it is apparently necessary in the first place due to broken email senders who abuse perfectly fine technology without any gain)</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=904872019-03-01T01:23:28ZGo MAEDA
<ul></ul><p>Holger Just wrote:</p>
<blockquote>
<p>If this setting is supposed to be configureable, I do think that it belongs on the Settings page rather than the <code>configuration.yml</code> file.</p>
</blockquote>
<p>Thank you for the advice. It makes sense. I attached <a class="attachment" href="https://www.redmine.org/attachments/22519">30838-preferred-part-multipart-email-without-gui.patch</a> to avoid increasing the complexity of the setting page, but now I think the setting should be on the page.</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=905262019-03-03T08:18:20ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you for improving Redmine.</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=905342019-03-03T13:52:34ZGo MAEDA
<ul><li><strong>Category</strong> changed from <i>Email notifications</i> to <i>Email receiving</i></li></ul> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=906562019-03-08T01:42:42ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>The caption of the options for the setting is hardcoded in <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17913/entry/trunk/app/views/settings/_mail_handler.html.erb#L21">source:trunk/app/views/settings/_mail_handler.html.erb@17913#L21</a> and cannot be localized.</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=906752019-03-09T22:32:22ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>We may change the default value to 'html' in the future version of Redmine but I think it is safer to stay in 'plain' in Redmine 4.1 because this unreleased feature is not widely tested and used yet in the production environments. Maybe it is better to mark this feature as "Experimental" like Markdown formatter introduced in Redmine 2.5 (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Markdown formatting (Closed)" href="https://www.redmine.org/issues/15520">#15520</a>).</p>
</blockquote>
<p>I completely agree, let mark this feature as "Experimental".</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=912892019-04-21T14:54:42ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I completely agree, let mark this feature as "Experimental".</p>
</blockquote>
<p>Done in <a class="changeset" title="Remove hard-coded strings (#30838). Patch by Go MAEDA." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18072">r18072</a>.</p> Redmine - Feature #30838: Option to parse HTML part of multipart (HTML) emails firsthttps://www.redmine.org/issues/30838?journal_id=1096362023-04-04T10:06:30ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/38408">Patch #38408</a>: Remove experimental flag from "Preferred part of multipart (HTML) emails" setting</i> added</li></ul>