https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-04-15T20:11:51ZRedmineRedmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=912222019-04-15T20:11:51ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/31147">Patch #31147</a>: Add custom styles for all fields</i> added</li></ul> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=912272019-04-16T07:24:21ZBernhard Rohloff
<ul><li><strong>File</strong> <a href="/attachments/22811">buttons-vs-input-fields.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22811/buttons-vs-input-fields.png">buttons-vs-input-fields.png</a> added</li></ul><p>The patch looks a bit odd in my case, because it sets the font size only for the buttons but not for the other input fields.<br />I think it would be better to set the font-size either for all input fields or for none.<br />Adding a transition to the hover effect would be a nice icing on the cake. :-)</p>
<p><img src="https://www.redmine.org/attachments/download/22811/buttons-vs-input-fields.png" style="width: 50%;border: 1px solid grey;" alt="" /></p> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=912342019-04-17T17:27:57ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/22816">0001-Styles-for-buttons.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22816/0001-Styles-for-buttons.patch">0001-Styles-for-buttons.patch</a> added</li></ul><p>Bernhard Rohloff wrote:</p>
<blockquote>
<p>The patch looks a bit odd in my case, because it sets the font size only for the buttons but not for the other input fields.<br />I think it would be better to set the font-size either for all input fields or for none.<br />Adding a transition to the hover effect would be a nice icing on the cake. :-)</p>
</blockquote>
<p>My bad, sorry for adding the font-size rule. <br />I've updated the patch:<br />- removed the font-size rule<br />- included a basic transition</p>
<p>Bernhard, please feel free to propose improvements to my patch.</p> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=912352019-04-17T17:28:04ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0001-Styles-for-buttons.patch</i></del>)</li></ul> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=912362019-04-17T17:29:39ZMarius BĂLTEANU
<ul></ul><p>Bernhard Rohloff wrote:</p>
<blockquote>
<p>I think it would be better to set the font-size either for all input fields or for none.</p>
</blockquote>
<p>I think it is a good idea to add the font-size to all input elements and remove the hardcoded height added by my patches, but I'll try to do it in the near future.</p> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=912452019-04-18T14:40:53ZBernhard Rohloff
<ul></ul><p>I've tested you changes and I think it looks really great now. LGTM!</p> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=912502019-04-18T16:05:43ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=912802019-04-21T09:28:43ZMarius BĂLTEANU
<ul><li><strong>Subject</strong> changed from <i>Add custom styles to buttons</i> to <i>Add hover styles to buttons</i></li></ul> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=914462019-04-30T07:17:20ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul><p>Thank you for the nice improvement. For me, the background color #ddd is a bit too dark. What do you think if the color is changed to #e4e4e4? This is the same color with the border color of some objects such as div.box, table.list, and fieldset.</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: public/stylesheets/application.css
===================================================================
</span><span class="gd">--- public/stylesheets/application.css (リビジョン 18106)
</span><span class="gi">+++ public/stylesheets/application.css (作業コピー)
</span><span class="p">@@ -461,7 +461,19 @@</span>
padding-right: 20px;
}
input[type="file"] {border: 0; padding-left: 0; padding-right: 0;}
<span class="gd">-input[type="submit"] {-webkit-appearance: button; cursor: pointer; background-color: #fff;}
</span><span class="gi">+input[type="submit"] {
+ -webkit-appearance: button;
+ cursor: pointer;
+ background-color: #fff;
+ height: 28px;
+ -webkit-transition: background-color 100ms linear;
+ -moz-transition: background-color 100ms linear;
+ -o-transition: background-color 100ms linear;
+ transition: background-color 100ms linear;
+}
+input[type="submit"]:hover {
+ background-color: #e4e4e4;
+}
</span> select[multiple=multiple] {background: #fff; padding-right: initial; height: auto;}
fieldset {border: 1px solid #e4e4e4; margin:0; min-width: inherit;}
legend {color: #333;}
</diff></pre></code></pre> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=914482019-04-30T08:02:34ZMarius BĂLTEANU
<ul></ul><p>I'm ok with any option.</p>
<p>I took the '#ddd' from pagination buttons, maybe we should merge the styles in another ticket.</p> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=914492019-04-30T08:08:39ZGo MAEDA
<ul><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I'm ok with any option.</p>
<p>I took the '#ddd' from pagination buttons, maybe we should merge the styles in another ticket.</p>
</blockquote>
<p>Thank you for the clarification. Knowing the reason, I think #ddd is appropriate now.</p> Redmine - Patch #31204: Add hover styles to buttonshttps://www.redmine.org/issues/31204?journal_id=914512019-04-30T08:15:43ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul><p>Committed the patch. Thanks.</p>