https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-05-09T06:57:05ZRedmineRedmine - Defect #31330: Import issues: File content preview block is scrollinghttps://www.redmine.org/issues/31330?journal_id=916562019-05-09T06:57:05ZGo MAEDA
<ul><li><strong>Category</strong> set to <i>UI</i></li></ul><p>Thank you for reporting this issue. Do you know if the issue affects not only the trunk but also 4.0-stable or 3.4-stable?</p> Redmine - Defect #31330: Import issues: File content preview block is scrollinghttps://www.redmine.org/issues/31330?journal_id=917132019-05-13T00:21:25ZYuichi HARADA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Thank you for reporting this issue. Do you know if the issue affects not only the trunk but also 4.0-stable or 3.4-stable?</p>
</blockquote>
<p>I confirmed 3.4-stable and 4.0-stable and trunk. I found the difference between 3.4-stable and 4.0-stable. This difference was also confirmed in trunk.<br /><pre>
$ diff 3.4-stable/public/application.css 4.0-stable/public/stylesheets/application.css
.....
437c453
< fieldset {border: 1px solid #e4e4e4; margin:0;}
---
> fieldset {border: 1px solid #e4e4e4; margin:0; min-width: inherit;}
.....
</pre></p>
<p>Based on this, I rebuilt the CSS settings. This patch is not necessary for 3.4-stable.<br /><pre><code class="diff syntaxhl"><span class="gh">diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index af34a8c88..0b9c62b35 100644
</span><span class="gd">--- a/public/stylesheets/application.css
</span><span class="gi">+++ b/public/stylesheets/application.css
</span><span class="p">@@ -430,6 +430,10 @@</span> span.add_attachment a {padding-left:16px; background: url(../images/bullet_add.p
word-wrap: break-word;
border-radius: 3px;
}
<span class="gi">+#import-form div.autoscroll fieldset.box {
+ min-width: auto; /* Edge */
+ min-width: fit-content;
+}
</span>
div.square {
border: 1px solid #999;
</code></pre></p> Redmine - Defect #31330: Import issues: File content preview block is scrollinghttps://www.redmine.org/issues/31330?journal_id=917142019-05-13T00:54:53ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>4.0.4</i></li></ul><p>Thank you for investigating further. I am setting the target version to 4.0.4.</p> Redmine - Defect #31330: Import issues: File content preview block is scrollinghttps://www.redmine.org/issues/31330?journal_id=917732019-05-15T08:33:43ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> set to <i>Yuichi HARADA</i></li></ul><p>It seems that the fix does not work for Firefox. Could you check the patch again?</p> Redmine - Defect #31330: Import issues: File content preview block is scrollinghttps://www.redmine.org/issues/31330?journal_id=917912019-05-16T02:47:34ZYuichi HARADA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>It seems that the fix does not work for Firefox. Could you check the patch again?</p>
</blockquote>
<p>Sorry, I did not confirm with Firefox.<br />An examination of "fit-content" showed that a vendor prefix is required.<br />I rebuilt a patch.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index 11b9263ba..72660ffdd 100644
</span><span class="gd">--- a/public/stylesheets/application.css
</span><span class="gi">+++ b/public/stylesheets/application.css
</span><span class="p">@@ -430,6 +430,12 @@</span> span.add_attachment a {padding-left:16px; background: url(../images/bullet_add.p
word-wrap: break-word;
border-radius: 3px;
}
<span class="gi">+#import-form div.autoscroll fieldset.box {
+ min-width: auto; /* Edge */
+ min-width: fit-content;
+ min-width: -webkit-fit-content;
+ min-width: -moz-fit-content;
+}
</span>
div.square {
border: 1px solid #999;
</code></pre> Redmine - Defect #31330: Import issues: File content preview block is scrollinghttps://www.redmine.org/issues/31330?journal_id=923052019-06-10T11:34:15ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>Closed</i></li><li><strong>Assignee</strong> changed from <i>Yuichi HARADA</i> to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>The autoscroll div was wrapping the fieldset, this should be fixed by <a class="changeset" title="Import issues: File content preview block is scrolling (#31330)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18243">r18243</a>.</p>