https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-07-02T06:52:01ZRedmineRedmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=927062019-07-02T06:52:01ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>DEPRECATION WARNING: Selenium::WebDriver::Error::***Error is deprecated.</i> to <i>Update capybara (~> 3.25.0)</i></li><li><strong>Category</strong> set to <i>Gems support</i></li><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul><p>Thank you for reporting this issue.</p>
<p>I think it is better to pin the version to the tested one. Unintended update of gems may break test.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/Gemfile b/Gemfile
index 37449f09f..9aa6e66f5 100644
</span><span class="gd">--- a/Gemfile
</span><span class="gi">+++ b/Gemfile
</span><span class="p">@@ -81,7 +81,7 @@</span> group :test do
gem "ffi", platforms: [:mingw, :x64_mingw, :mswin]
# For running system tests
gem 'puma', '~> 3.7'
<span class="gd">- gem "capybara", '~> 2.13'
</span><span class="gi">+ gem "capybara", '~> 3.25.0'
</span> gem "selenium-webdriver"
# RuboCop
gem 'rubocop', '~> 0.72.0'
</code></pre> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=927072019-07-02T08:03:04ZTakenori TAKAKItakenory@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/23446">31657.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23446/31657.patch">31657.patch</a> added</li></ul><p>Thank you for your comment Mr. Maeda.</p>
<p>Go MAEDA wrote:</p>
<blockquote>
<p>I think it is better to pin the version to the tested one. Unintended update of gems may break test.</p>
</blockquote>
<p>I have the same opinion as you.<br />When I ran the test, I needed to fix the test code.<br />So I posted the patch again.</p> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=928382019-07-22T08:22:34ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/23524">failures_test_issue_trackers_description_should_select_tracker.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23524/failures_test_issue_trackers_description_should_select_tracker.png">failures_test_issue_trackers_description_should_select_tracker.png</a> added</li></ul><p>IssuesTest#test_issue_trackers_description_should_select_tracker randomly fails.</p>
<pre>
.........................[Screenshot]: tmp/screenshots/failures_test_issue_trackers_description_should_select_tracker.png
F
Failure:
IssuesTest#test_issue_trackers_description_should_select_tracker [/Users/maeda/redmines/redmine-trunk/test/system/issues_test.rb:350]:
Expected false to be truthy.
bin/rails test test/system/issues_test.rb:344
</pre> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=928432019-07-22T22:46:54ZPavel Rosický
<ul><li><strong>File</strong> <a href="/attachments/23525">issues_test.rb.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23525/issues_test.rb.patch">issues_test.rb.patch</a> added</li></ul><p>Go MAEDA it fails because of scroll animations <a class="external" href="https://github.com/redmine/redmine/blob/master/public/javascripts/application.js#L28">https://github.com/redmine/redmine/blob/master/public/javascripts/application.js#L28</a></p> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=928592019-07-24T09:26:05ZGo MAEDA
<ul></ul><p>Pavel Rosický wrote:</p>
<blockquote>
<p>Go MAEDA it fails because of scroll animations <a class="external" href="https://github.com/redmine/redmine/blob/master/public/javascripts/application.js#L28">https://github.com/redmine/redmine/blob/master/public/javascripts/application.js#L28</a></p>
</blockquote>
<p>No errors are observed after applying your patch. Thanks.</p> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=928602019-07-24T09:48:56ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update capybara (~> 3.25.0)</i> to <i>Update capybara (~> 3.15.1)</i></li></ul><p>Capybara 3.25.0 cannot be used because Redmine 4.1.0 supports Ruby 2.3 but Capybara 3.25.0 does not. The last version of Capybara which supports Ruby 2.3 is 3.15.1.</p> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=928612019-07-24T09:59:06ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update capybara (~> 3.15.1)</i> to <i>Update capybara (~> 3.25.0)</i></li></ul><pre><code class="diff syntaxhl"><span class="gh">Index: Gemfile
===================================================================
</span><span class="gd">--- Gemfile (revision 18329)
</span><span class="gi">+++ Gemfile (working copy)
</span><span class="p">@@ -81,7 +81,7 @@</span>
gem "ffi", platforms: [:mingw, :x64_mingw, :mswin]
# For running system tests
gem 'puma', '~> 3.7'
<span class="gd">- gem "capybara", '~> 2.13'
</span><span class="gi">+ gem "capybara", (RUBY_VERSION < "2.4" ? "~> 3.15.1" : "~> 3.25.0")
</span> gem "selenium-webdriver"
# RuboCop
gem 'rubocop', '~> 0.72.0'
</code></pre> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=928622019-07-24T10:14:45ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you.</p> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=948652019-11-12T04:02:57ZTakenori TAKAKItakenory@gmail.com
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>The latest version of Capybara (3.29.0) has been released, so I updated the gem and re-tested the "test/system".<br />And I confirmed that all tests passed.</p>
<pre><code class="diff syntaxhl"><span class="gh">index 587bdb101..1d7c8fe1c 100644
</span><span class="gd">--- a/Gemfile
</span><span class="gi">+++ b/Gemfile
</span><span class="p">@@ -81,7 +81,7 @@</span> group :test do
gem "ffi", platforms: [:mingw, :x64_mingw, :mswin]
# For running system tests
gem 'puma', '~> 3.7'
<span class="gd">- gem "capybara", (RUBY_VERSION < "2.4" ? "~> 3.15.1" : "~> 3.25.0")
</span><span class="gi">+ gem "capybara", (RUBY_VERSION < "2.4" ? "~> 3.15.1" : "~> 3.29.0")
</span> gem "selenium-webdriver"
# RuboCop
gem 'rubocop', '~> 0.76.0'
</code></pre> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=948672019-11-12T04:54:58ZGo MAEDA
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32453">Patch #32453</a>: Update capybara (~> 3.31.0)</i> added</li></ul> Redmine - Defect #31657: Update capybara (~> 3.25.0)https://www.redmine.org/issues/31657?journal_id=948692019-11-12T04:57:06ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Takenori TAKAKI wrote:</p>
<blockquote>
<p>The latest version of Capybara (3.29.0) has been released, so I updated the gem and re-tested the "test/system".<br />And I confirmed that all tests passed.</p>
</blockquote>
<p>Thank you for testing the latest version of Capybara. But 4.1-stable branch has been created and Redmine 4.1.0 is about to be released, so I have opened a new issue <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Update capybara (~> 3.31.0) (Closed)" href="https://www.redmine.org/issues/32453">#32453</a> for Redmine 4.2.0.</p>