https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-12-25T01:32:51ZRedmineRedmine - Defect #32664: Adding an empty reply to a forum message does not show any errorhttps://www.redmine.org/issues/32664?journal_id=954262019-12-25T01:32:51ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/24505">show_any_error_when_reply.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24505/show_any_error_when_reply.png">show_any_error_when_reply.png</a> added</li><li><strong>File</strong> <a href="/attachments/24506">32664_show_errormsg_submitting_reply.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24506/32664_show_errormsg_submitting_reply.patch">32664_show_errormsg_submitting_reply.patch</a> added</li></ul><p>Show any error message when submitting a reply. I attached a patch.<br />However, I'm worried that if the number of replies increases, the error message, and the reply input fields will be separated.</p>
<p><img src="https://www.redmine.org/attachments/download/24505/show_any_error_when_reply.png" style="width:600px;border:1px solid #ccc;" alt="" /></p> Redmine - Defect #32664: Adding an empty reply to a forum message does not show any errorhttps://www.redmine.org/issues/32664?journal_id=954822020-01-04T05:13:07ZGo MAEDA
<ul></ul><p>Yuichi HARADA wrote:</p>
<blockquote>
<p>However, I'm worried that if the number of replies increases, the error message, and the reply input fields will be separated.</p>
</blockquote>
<p>You are right. Thank you for pointing it out.</p>
<p>And I found that the behavior that showing an error is not consistent with issues. When updating issues, no error is shown even if note is empty. Its behavior is similar to forums but the only difference is the behavior when adding attachments with an empty note. In the case, attachments are added to the issue.</p>
<p>I think the following behavior is better for forums. It is consistent with the behavior of issues.</p>
<ul>
<li>Empty message <em>without</em> attachments: Almost the same behavior with the current behavior but "Successful update" message should not be shown</li>
<li>empty message <em>with</em> attachments: Attach the files instead of discarding them</li>
</ul> Redmine - Defect #32664: Adding an empty reply to a forum message does not show any errorhttps://www.redmine.org/issues/32664?journal_id=957512020-01-16T05:09:41ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/24620">32664_show_errormsg_submitting_reply-v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24620/32664_show_errormsg_submitting_reply-v2.patch">32664_show_errormsg_submitting_reply-v2.patch</a> added</li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I think the following behavior is better for forums. It is consistent with the behavior of issues.</p>
<ul>
<li>Empty message <em>without</em> attachments: Almost the same behavior with the current behavior but "Successful update" message should not be shown</li>
<li>empty message <em>with</em> attachments: Attach the files instead of discarding them</li>
</ul>
</blockquote>
<p>Thank you for pointing it out. I attached a patch that incorporates the above behaviors.</p> Redmine - Defect #32664: Adding an empty reply to a forum message does not show any errorhttps://www.redmine.org/issues/32664?journal_id=960852020-02-04T09:33:24ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul>