https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-04-16T13:00:23ZRedmineRedmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=972982020-04-16T13:00:23ZMischa The Evil
<ul></ul>+1 for the integration of this proposal. A few notes nevertheless:
<ul>
<li>Wouldn't such default custom queries be useful also for the other <code>Query</code> subclasses?</li>
<li>Regarding your comment that <cite>"[...] Currently, it is a bit difficult for beginners to find the feature. "Save" button is the only way to find it [...]"</cite>: what about the documentation? It may be rudimentary, but it is clearly explained in <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineIssueList#Applying-and-saving-filters">RedmineIssueList#Applying-and-saving-filters</a> that filters can be saved. I agree though that this is not (yet) the case for <code>Query</code> subclasses other than <code>IssueQuery</code>.</li>
<li>On a more general note: I wouldn't suggest to run <em>redmine:load_default_data</em> while provisioning a new Redmine instance in a (corporate) production environment in the first place, but this depends heavily on the scale of the deployment and the kind of environment it's deployed in, so, YMMV.</li>
</ul> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=972992020-04-16T15:37:09ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul><p>Nice idea.</p>
<p>Maybe it's a good idea to add some default queries on a fresh install and not only as default data?</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=973202020-04-18T07:40:10ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/25216">load_default_query.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25216/load_default_query.patch">load_default_query.patch</a> added</li></ul><p>Updated the patch. Now the rake task adds project queries and time entry queries.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=973242020-04-18T10:13:41ZMischa The Evil
<ul></ul><p>I'll combine my response on two notes:</p>
<p>Marius BALTEANU wrote in <a href="#note-2">#note-2</a>:</p>
<blockquote>
<p>Maybe it's a good idea to add some default queries on a fresh install and not only as default data?</p>
</blockquote>
<p>Do you mean via (a) Rails migration(s) or somehow programatically?</p>
<p>Go MAEDA wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Updated the patch. Now the rake task adds project queries and time entry queries.</p>
</blockquote>
<p>The patch file seems to miss the time entry queries changes.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=973252020-04-18T10:17:53ZMarius BĂLTEANU
<ul></ul><p>Mischa The Evil wrote:</p>
<blockquote>
<p>I'll combine my response on two notes:</p>
<p>Marius BALTEANU wrote in <a href="#note-2">#note-2</a>:</p>
<blockquote>
<p>Maybe it's a good idea to add some default queries on a fresh install and not only as default data?</p>
</blockquote>
<p>Do you mean via (a) Rails migration(s) or somehow programatically?</p>
</blockquote>
<p>Yes, via a migration that should run only when the queries table has no entries. But it's just an idea :)</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=973392020-04-19T04:20:28ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/25226">load_default_query.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25226/load_default_query.patch">load_default_query.patch</a> added</li></ul><p>Mischa The Evil wrote:</p>
<blockquote>
<p>Go MAEDA wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Updated the patch. Now the rake task adds project queries and time entry queries.</p>
</blockquote>
<p>The patch file seems to miss the time entry queries changes.</p>
</blockquote>
<p>Sorry, here is the latest patch.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=973402020-04-19T04:36:06ZGo MAEDA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote><blockquote>
<p>Marius BALTEANU wrote in <a href="#note-2">#note-2</a>:</p>
<blockquote>
<p>Maybe it's a good idea to add some default queries on a fresh install and not only as default data?</p>
</blockquote>
<p>Do you mean via (a) Rails migration(s) or somehow programatically?</p>
</blockquote>
<p>Yes, via a migration that should run only when the queries table has no entries. But it's just an idea :)</p>
</blockquote>
<p>Since only JPL can add new migrations, I think the way will take a longer time to be implemented. On the other hand, updating lib/redmine/default_data/loader.rb is much easier to implement.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=973462020-04-19T07:11:09ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.0</i></li></ul><p>Let’s do it then.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=974212020-04-21T12:45:03ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Load default issue queries when runnning redmine:load_default_data rake task</i> to <i>Load default custom queries when runnning redmine:load_default_data rake task</i></li><li><strong>Category</strong> changed from <i>Issues list</i> to <i>Filters</i></li></ul> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=974242020-04-21T19:15:41ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>I confirm that this should not be done in migrations. It's generally a bad idea to use models in migrations and we should avoid this whenever it's possible.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=975602020-04-28T07:11:08ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Load default custom queries when runnning redmine:load_default_data rake task</i> to <i>Load default custom queries when running redmine:load_default_data rake task</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=975682020-04-28T14:53:11ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=975832020-04-29T07:04:22ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p><a class="changeset" title="Load default custom queries when running redmine:load_default_data rake task (#33296). Patch by ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/19731">r19731</a> caused test failures.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=975842020-04-29T08:00:38ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p><a class="changeset" title="Load default custom queries when running redmine:load_default_data rake task (#33296). Patch by ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/19731">r19731</a> caused test failures.</p>
</blockquote>
<p>Fixed in <a class="changeset" title="Fix test failures due to r19731 (#33296)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/19733">r19733</a>.</p> Redmine - Feature #33296: Load default custom queries when running redmine:load_default_data rake taskhttps://www.redmine.org/issues/33296?journal_id=1099372023-05-05T08:29:46ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/10142">Feature #10142</a>: Add quick filter "Assigned to me" to saved issue filters</i> added</li></ul>