https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-05-02T14:20:07ZRedmineRedmine - Defect #33392: Fix invalid selector in function displayTabsButtons()https://www.redmine.org/issues/33392?journal_id=976322020-05-02T14:20:07ZMarius BĂLTEANU
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/97632/diff?detail_id=79176">diff</a>)</li><li><strong>Target version</strong> changed from <i>4.2.0</i> to <i>4.0.8</i></li><li><strong>Affected version</strong> set to <i>4.0.0</i></li></ul> Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons()https://www.redmine.org/issues/33392?journal_id=976342020-05-02T14:21:13ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/33383">Feature #33383</a>: Update jQuery to 3.5.1</i> added</li></ul> Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons()https://www.redmine.org/issues/33392?journal_id=976352020-05-02T16:56:56ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> changed from <i>4.0.8</i> to <i>4.2.0</i></li></ul> Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons()https://www.redmine.org/issues/33392?journal_id=976442020-05-03T00:20:10ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/25345">different-behavior-before.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25345/different-behavior-before.png">different-behavior-before.png</a> added</li><li><strong>File</strong> <a href="/attachments/25346">different-behavior-after.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25346/different-behavior-after.png">different-behavior-after.png</a> added</li></ul><p>I found that the patch changes the behavior of the button.</p>
<p>After applying the patch, the buttons show up even when there are no hidden tabs.</p>
<p><strong>Before:</strong><br /><img src="https://www.redmine.org/attachments/download/25345/different-behavior-before.png" style="width: 1014px;border: 1px solid grey;" alt="" /></p>
<p><strong>After:</strong><br /><img src="https://www.redmine.org/attachments/download/25346/different-behavior-after.png" style="width: 1014px;border: 1px solid grey;" alt="" /></p> Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons()https://www.redmine.org/issues/33392?journal_id=976502020-05-03T06:33:01ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0001-Fix-invalid-selector-in-displayTabsButtons-function.patch</i></del>)</li></ul> Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons()https://www.redmine.org/issues/33392?journal_id=976522020-05-03T06:42:49ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/25350">0001-Fix-invalid-selector-in-displayTabsButtons-function_v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25350/0001-Fix-invalid-selector-in-displayTabsButtons-function_v2.patch">0001-Fix-invalid-selector-in-displayTabsButtons-function_v2.patch</a> added</li><li><strong>File</strong> <a href="/attachments/25352">1120.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25352/1120.png">1120.png</a> added</li><li><strong>File</strong> <a href="/attachments/25353">1141.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25353/1141.png">1141.png</a> added</li></ul><p>I've removed from the patch the changes related to the "hidden" class because are irrelevant. Please retest it because on my environment I cannot reproduce the problem on all resolutions.</p>
<p>The problem that you say reproduces only on widths between 1120px - 1140px:<br />1120px Tab buttons appear:<br /><img src="https://www.redmine.org/attachments/download/25352/1120.png" style="border: 1px solid grey;" alt="" /></p>
<p>1141px Tab buttons disappear :<br /><img src="https://www.redmine.org/attachments/download/25353/1141.png" style="border: 1px solid grey;" alt="" /></p>
<p>Is it correct?</p> Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons()https://www.redmine.org/issues/33392?journal_id=976602020-05-03T23:18:12ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you.</p> Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons()https://www.redmine.org/issues/33392?journal_id=976702020-05-04T08:18:53ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Committed the patch. Thank you.</p>
</blockquote>
<p>Thanks for committing this. FTR, we can easily fix the issue with those 20px, but working on it, I've found multiple issues, for example: resize the window, navigate to right until "+" and "Overview" tabs are hidden, then expand the window to the maximum. Observe that the hidden tabs are not automatically displayed even if it's enough space. I decided to try to find a better solution, but it'll take some time.</p>