https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-05-28T15:51:08ZRedmineRedmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=979852020-05-28T15:51:08ZMarius BĂLTEANU
<ul></ul><p>All tests pass: <a class="external" href="https://gitlab.com/redmine-org/redmine/pipelines/150020738">https://gitlab.com/redmine-org/redmine/pipelines/150020738</a></p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=980282020-06-02T12:35:47ZGo MAEDA
<ul></ul><p>Would you tell me the steps to cause a validation error through the context menu? Since the context menu only shows valid options, I could not find a way to cause a validation error.</p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=981832020-06-13T16:40:10ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Would you tell me the steps to cause a validation error through the context menu? Since the context menu only shows valid options, I could not find a way to cause a validation error.</p>
</blockquote>
Yes, please follow these steps using the default data:
<ol>
<li>Make "Description" field mandatory for "In progress" status</li>
<li>Find an issue in status "New" without "Description" filled in</li>
<li>Using the context menu, try to change the issue status to in "In progress" </li>
<li>You should receive the validation error and you can observe that the Description field is not available in the page.</li>
</ol> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=981862020-06-14T02:13:19ZGo MAEDA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Go MAEDA wrote:</p>
<blockquote>
<p>Would you tell me the steps to cause a validation error through the context menu? Since the context menu only shows valid options, I could not find a way to cause a validation error.</p>
</blockquote>
Yes, please follow these steps using the default data:
<ol>
<li>Make "Description" field mandatory for "In progress" status</li>
<li>Find an issue in status "New" without "Description" filled in</li>
<li>Using the context menu, try to change the issue status to in "In progress" </li>
<li>You should receive the validation error and you can observe that the Description field is not available in the page.</li>
</ol>
</blockquote>
<p>Thank you, confirmed the issue.</p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=993522020-10-05T20:41:56ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.0</i></li></ul> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1015032021-03-23T20:40:57ZMarius BĂLTEANU
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Target version</strong> changed from <i>4.2.0</i> to <i>5.0.0</i></li></ul> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1031132021-07-04T15:31:56ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/27692">0001-Use-issue-path-instead-of-bulk-update-issues-path-wh.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27692/0001-Use-issue-path-instead-of-bulk-update-issues-path-wh.patch">0001-Use-issue-path-instead-of-bulk-update-issues-path-wh.patch</a> added</li></ul><p>Updated the patch.</p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1033462021-07-26T21:47:00ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Patch committed.</p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1034902021-08-02T01:04:57ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Due to <a class="changeset" title="Use issue path instead of bulk update issues path when only one issue is selected in the context ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21089">r21089</a>, you are no longer able to change the issue status via the context menu. The error is as follows:</p>
<pre>
Started POST "/issues/1?back_url=%2Fprojects%2Fecookbook%2Fissues&ids%5B%5D=1&issue%5Bstatus_id%5D=5" for 127.0.0.1 at 2021-08-02 09:55:03 +0900
ActionController::RoutingError (No route matches [POST] "/issues/1"):
</pre> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1034912021-08-02T02:41:33ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/27816">0001-Fix-status-update-path-on-the-context-menu.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27816/0001-Fix-status-update-path-on-the-context-menu.patch">0001-Fix-status-update-path-on-the-context-menu.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27815">0002-Change-custom-field-value-update-path-on-the-context.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27815/0002-Change-custom-field-value-update-path-on-the-context.patch">0002-Change-custom-field-value-update-path-on-the-context.patch</a> added</li></ul><p>I have attached two patches.</p>
<ul>
<li>0001-Fix-status-update-path-on-the-context-menu.patch<br />The cause of <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Use issue path instead of bulk update issues path when using the context menu with only one issue... (Closed)" href="https://www.redmine.org/issues/33521#note-9">#33521#note-9</a> is that the data method of the link to update the status was still post instead of patch.<br />This is a patch that adds data-method fixes and tests.</li>
</ul>
<ul>
<li>0002-Change-custom-field-value-update-path-on-the-context.patch<br />Change ContextMenusHelper#bulk_update_custom_field_context_menu_link( <a class="external" href="https://www.redmine.org/projects/redmine/repository/revisions/20846/entry/trunk/app/helpers/context_menus_helper.rb#L37">https://www.redmine.org/projects/redmine/repository/revisions/20846/entry/trunk/app/helpers/context_menus_helper.rb#L37</a> ) in the same way as <a class="changeset" title="Use issue path instead of bulk update issues path when only one issue is selected in the context ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21089">r21089</a>.</li>
</ul> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1035352021-08-03T20:26:51ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul><p>Both patches committed, thank you for working on this.</p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1035362021-08-04T05:20:57ZMizuki ISHIKAWA
<ul></ul><p>I found another problem caused by the impact of this change.</p>
<p>When changing the category to none from the context menu:<br />[Expected result] "Category deleted (Printing)" is displayed in the issue history.<br />[Actual result] "Category changed from Printing to 0" is displayed in the issue history.</p>
<p>This can be reproduced with attributes other than category_id.</p>
<p>When I pass the parameter {category_id:'none'}, bulk_update converts it to {category_id:''} by the parse_params_for_bulk_update method, but update doesn't.<br /><a class="external" href="https://redmine.org/projects/redmine/repository/revisions/21012/entry/trunk/app/controllers/application_controller.rb#L416">https://redmine.org/projects/redmine/repository/revisions/21012/entry/trunk/app/controllers/application_controller.rb#L416</a></p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1035372021-08-04T07:23:25ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1035412021-08-04T08:54:08ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/27834">diff.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27834/diff.patch">diff.patch</a> added</li></ul><p>I have attached a patch to fix <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Use issue path instead of bulk update issues path when using the context menu with only one issue... (Closed)" href="https://www.redmine.org/issues/33521#note-12">#33521#note-12</a>.</p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1035662021-08-05T23:41:58ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Mizuki ISHIKAWA wrote:</p>
<blockquote>
<p>I have attached a patch to fix <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Use issue path instead of bulk update issues path when using the context menu with only one issue... (Closed)" href="https://www.redmine.org/issues/33521#note-12">#33521#note-12</a>.</p>
</blockquote>
<p>Patch committed with small changes, thank you for reporting and fixing the issue.</p> Redmine - Defect #33521: Use issue path instead of bulk update issues path when using the context menu with only one issue selectedhttps://www.redmine.org/issues/33521?journal_id=1035672021-08-05T23:49:20ZMizuki ISHIKAWA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Mizuki ISHIKAWA wrote:</p>
<blockquote>
<p>I have attached a patch to fix <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Use issue path instead of bulk update issues path when using the context menu with only one issue... (Closed)" href="https://www.redmine.org/issues/33521#note-12">#33521#note-12</a>.</p>
</blockquote>
<p>Patch committed with small changes, thank you for reporting and fixing the issue.</p>
</blockquote>
<p>Thank you for reviewing and committing.</p>