https://www.redmine.org/
https://www.redmine.org/favicon.ico?1679302129
2020-09-01T03:11:03Z
Redmine
Redmine - Patch #33938: Add missing fixtures to IssueNestedSetTest
https://www.redmine.org/issues/33938?journal_id=99017
2020-09-01T03:11:03Z
Yuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/25903">fixed-33938.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25903/fixed-33938.patch">fixed-33938.patch</a> added</li></ul><p>I think that because of the fixtures are not enough.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/test/unit/issue_nested_set_test.rb b/test/unit/issue_nested_set_test.rb
index 3c6f46adf..c79ff48cc 100644
</span><span class="gd">--- a/test/unit/issue_nested_set_test.rb
</span><span class="gi">+++ b/test/unit/issue_nested_set_test.rb
</span><span class="p">@@ -24,7 +24,7 @@</span> class IssueNestedSetTest < ActiveSupport::TestCase
:trackers, :projects_trackers,
:issue_statuses, :issue_categories, :issue_relations,
:enumerations,
<span class="gd">- :issues
</span><span class="gi">+ :issues, :journals, :journal_details
</span>
def setup
User.current = nil
</code></pre>
Redmine - Patch #33938: Add missing fixtures to IssueNestedSetTest
https://www.redmine.org/issues/33938?journal_id=99143
2020-09-12T08:16:12Z
Go MAEDA
<ul></ul><p>I cannot reproduce the problem.</p>
<pre>
$ RAILS_ENV=test bin/rake db:reset
$ ruby test/unit/issue_nested_set_test.rb
Run options: --seed 59495
# Running:
.......................
Finished in 7.030327s, 3.2715 runs/s, 8.9612 assertions/s.
23 runs, 63 assertions, 0 failures, 0 errors, 0 skips
</pre>
Redmine - Patch #33938: Add missing fixtures to IssueNestedSetTest
https://www.redmine.org/issues/33938?journal_id=99164
2020-09-14T00:20:51Z
Yuichi HARADA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I cannot reproduce the problem.</p>
<p>[...]</p>
</blockquote>
<p>You can reproduce it by testing as follows. I think it's because of the order in which the tests are run.</p>
<pre>
$ RAILS_ENV=test bundle exec rake db:migrate:reset
$ RAILS_ENV=test bundle exec rake test TESTOPTS="--seed 43474"
Run options: --seed 43474
# Running:
....F
Failure:
IssueNestedSetTest#test_destroy_should_destroy_children [/Users/harada/_work_/redmine/git/dev-trunk/test/unit/issue_nested_set_test.rb:225]:
"JournalDetail.count" didn't change by -1.
Expected: 7
Actual: 6
bin/rails test test/unit/issue_nested_set_test.rb:216
..........F
Failure:
IssueNestedSetTest#test_destroy_child_issue_with_children [/Users/harada/_work_/redmine/git/dev-trunk/test/unit/issue_nested_set_test.rb:270]:
"JournalDetail.count" didn't change by -1.
Expected: 7
Actual: 6
bin/rails test test/unit/issue_nested_set_test.rb:262
.............
Finished in 405.463254s, 12.4031 runs/s, 57.2555 assertions/s.
5029 runs, 23215 assertions, 2 failures, 0 errors, 7 skips
</pre>