https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292021-04-01T01:31:44ZRedmineRedmine - Defect #34998: Cannot open journal dropdown menu after editing notehttps://www.redmine.org/issues/34998?journal_id=1017042021-04-01T01:31:44ZMizuki ISHIKAWA
<ul></ul><p>The following changes will resolve the issue.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/public/javascripts/application.js b/public/javascripts/application.js
index e60425cae..4bb9d9551 100644
</span><span class="gd">--- a/public/javascripts/application.js
</span><span class="gi">+++ b/public/javascripts/application.js
</span><span class="p">@@ -722,7 +722,7 @@</span> $(document).ready(function(){
// This variable is used to focus selected project
var selected;
<span class="gd">- $(".drdn-trigger").click(function(e){
</span><span class="gi">+ $('#content, #header').on('click', '.drdn-trigger', function(e){
</span> var drdn = $(this).closest(".drdn");
if (drdn.hasClass("expanded")) {
drdn.removeClass("expanded");
</code></pre> Redmine - Defect #34998: Cannot open journal dropdown menu after editing notehttps://www.redmine.org/issues/34998?journal_id=1017072021-04-01T05:21:35ZMarius BÄ‚LTEANU
<ul></ul><p>Mizuki, one question, why not binding directly on document?</p> Redmine - Defect #34998: Cannot open journal dropdown menu after editing notehttps://www.redmine.org/issues/34998?journal_id=1017082021-04-01T05:21:53ZMarius BÄ‚LTEANU
<ul><li><strong>Target version</strong> set to <i>4.2.1</i></li></ul> Redmine - Defect #34998: Cannot open journal dropdown menu after editing notehttps://www.redmine.org/issues/34998?journal_id=1018482021-04-06T00:04:27ZMizuki ISHIKAWA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Mizuki, one question, why not binding directly on document?</p>
</blockquote>
<p>I used "#content, #header" because I thought it was better to narrow down the selector as much as possible.<br />However, since $("#content, #header") contains almost all elements of Redmine, I think it makes no difference to change $("#content, #header") to $(document).</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/public/javascripts/application.js b/public/javascripts/application.js
index e60425cae..1bc228236 100644
</span><span class="gd">--- a/public/javascripts/application.js
</span><span class="gi">+++ b/public/javascripts/application.js
</span><span class="p">@@ -722,7 +722,7 @@</span> $(document).ready(function(){
// This variable is used to focus selected project
var selected;
<span class="gd">- $(".drdn-trigger").click(function(e){
</span><span class="gi">+ $(document).on('click', '.drdn-trigger', function(e){
</span> var drdn = $(this).closest(".drdn");
if (drdn.hasClass("expanded")) {
drdn.removeClass("expanded");
</code></pre> Redmine - Defect #34998: Cannot open journal dropdown menu after editing notehttps://www.redmine.org/issues/34998?journal_id=1018522021-04-06T05:49:08ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the fix. Thank you.</p>