https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292022-04-08T11:28:25ZRedmineRedmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1063172022-04-08T11:28:25ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li><li><strong>Target version</strong> set to <i>5.0.1</i></li></ul> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1065122022-04-26T19:45:52ZFernando Hartmann
<ul></ul>The same happens with attachments.<br />Steps
<ol>
<li>Edit ticket </li>
<li>Select a file to attach <br /> The file appears at Files section</li>
<li>Change issue status to other state</li>
</ol>
<p>Right after the status change, the file listed at Files section, is removed, and the error above is printed on browser console.</p> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1065132022-04-26T20:06:03ZFernando Hartmann
<ul></ul><p>Is there a patch ready for this ?</p> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1065422022-04-27T21:39:06ZMarius BĂLTEANU
<ul></ul><p>Thanks for reporting this!</p>
<p>Can you test the following patch?<br /><pre><code class="patch syntaxhl"><span class="gh">diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 1dfa26cb2..031273d44 100644
</span><span class="gd">--- a/app/helpers/application_helper.rb
</span><span class="gi">+++ b/app/helpers/application_helper.rb
</span><span class="p">@@ -1831,9 +1831,7 @@</span> module ApplicationHelper
def update_data_sources_for_auto_complete(data_sources)
javascript_tag(
<span class="gd">- "const currentDataSources = rm.AutoComplete.dataSources;" \
- "const newDataSources = JSON.parse('#{data_sources.to_json}'); " \
- "rm.AutoComplete.dataSources = Object.assign(currentDataSources, newDataSources);"
</span><span class="gi">+ "rm.AutoComplete.dataSources = Object.assign(rm.AutoComplete.dataSources, JSON.parse('#{data_sources.to_json}'));"
</span> )
end
</code></pre></p>
<p>This patch fixes only the console error.</p> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1065432022-04-27T21:44:32ZMarius BĂLTEANU
<ul></ul><p>Fernando Hartmann wrote:</p>
<blockquote>
The same happens with attachments.<br />Steps
<ol>
<li>Edit ticket </li>
<li>Select a file to attach <br />The file appears at Files section</li>
<li>Change issue status to other state</li>
</ol>
<p>Right after the status change, the file listed at Files section, is removed, and the error above is printed on browser console.</p>
</blockquote>
<p>This is a different error and it's generated by the change from <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: When editing an issue, the Log time and/or Add notes does not show or hide dynamically (Closed)" href="https://www.redmine.org/issues/34641">#34641</a>. Until a proper fix is ready, you can try reverting the changes from <code>app/views/issues/edit.js.erb</code> and <code>app/views/issues/edit.js.erb</code>.</p> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1065482022-04-28T05:45:43ZMarius BĂLTEANU
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/37053">Defect #37053</a>: Attachments are lost when the status of the ticket is changed</i> added</li></ul> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1065502022-04-28T05:46:15ZMarius BĂLTEANU
<ul></ul><p>Created a new issue (<a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Attachments are lost when the status of the ticket is changed (Closed)" href="https://www.redmine.org/issues/37053">#37053</a>) for the second issue.</p> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1066192022-05-06T13:05:57ZCyrill A
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Thanks for reporting this!</p>
<p>Can you test the following patch?<br />[...]</p>
<p>This patch fixes only the console error.</p>
</blockquote>
<p>worked for me with same issue. thank you</p> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1066632022-05-11T20:11:55ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/13919">Feature #13919</a>: Mention user on issues and wiki pages using @user with autocomplete</i> added</li></ul> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1066652022-05-11T20:29:30ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Resolved</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Fixed committed with a test.</p> Redmine - Defect #36909: Mentions not working if status is changedhttps://www.redmine.org/issues/36909?journal_id=1066702022-05-12T05:48:37ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>