https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292023-01-20T02:36:14ZRedmineRedmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1091362023-01-20T02:36:14ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/31485">Patch #31485</a>: Add support for :sql ActiveRecord::Base.schema_format in redmine:plugins:migrate</i> added</li></ul> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1091382023-01-20T02:39:28ZGo MAEDA
<ul><li><strong>Category</strong> set to <i>Rails support</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li></ul><p>Steps to reproduce:<br /><pre>
$ echo 'config.active_record.schema_format = :sql' >> config/additional_environment.rb
$ bin/rake redmine:plugins:migrate
</pre></p> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1091392023-01-20T02:47:21ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/30126">31485.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/30126/31485.patch">31485.patch</a> added</li><li><strong>Target version</strong> set to <i>5.0.5</i></li></ul><p>Setting the target version to 5.0.5.</p> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1091412023-01-20T08:27:08ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Using `bin/rails db:structure:dump` is deprecated and will be removed in Rails 7.0.</i> to <i>Fix "DEPRECATION WARNING: Using `bin/rails db:structure:dump`" when migrating plugins using sql schema format</i></li></ul> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1091442023-01-20T15:19:50ZDmitry Makurin
<ul><li><strong>File</strong> <a href="/attachments/30128">38199_v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/30128/38199_v2.patch">38199_v2.patch</a> added</li></ul><p>I guess we need to provide backward compatibility for Rails 6.1.<br /><code>db:structure:dump</code> will be removed only in Rails 7.0 but the current trunk works on 6.1+.<br />Attaching a new patch <a class="attachment" href="https://www.redmine.org/attachments/30128">38199_v2.patch</a>.</p> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1091462023-01-21T03:26:30ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>5.0.5</i> to <i>5.1.0</i></li></ul> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1091472023-01-21T03:34:56ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>5.1.0</i> to <i>5.0.5</i></li></ul> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1091482023-01-21T03:40:54ZGo MAEDA
<ul></ul><p>Dmitry Makurin wrote:</p>
<blockquote>
<p>I guess we need to provide backward compatibility for Rails 6.1.<br /><code>db:structure:dump</code> will be removed only in Rails 7.0 but the current trunk works on 6.1+.<br />Attaching a new patch <a class="attachment" href="https://www.redmine.org/attachments/30128">38199_v2.patch</a>.</p>
</blockquote>
<p>I think the first patch work with Rails 6.1. It seems that <code>db:schema:dump</code> generates db/structure.sql also with Rails 6.1.</p>
<pre>
$ rm db/structure.sql
ls db/structure.sql
ls: db/structure.sql: No such file or directory
$ bin/rake redmine:plugins:migrate
$ ls db/structure.sql
db/structure.sql
</pre> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1092412023-02-01T07:54:09ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Fix "DEPRECATION WARNING: Using `bin/rails db:structure:dump`" when migrating plugins using sql schema format</i> to <i>Fix deprecation warning for db:structure:dump in db:migrate when using sql schema format</i></li><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the fix. Thank you.</p> Redmine - Defect #38199: Fix deprecation warning for db:structure:dump in db:migrate when using sql schema formathttps://www.redmine.org/issues/38199?journal_id=1092542023-02-03T01:03:41ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>