https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292009-11-30T12:14:57ZRedmineRedmine - Defect #4311: Settings default language not (really) usedhttps://www.redmine.org/issues/4311?journal_id=125852009-11-30T12:14:57ZThomas Lecavelier
<ul><li><strong>File</strong> <a href="/attachments/2857">0001-Redmine-default-locale-used-before-browser-locale.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2857/0001-Redmine-default-locale-used-before-browser-locale.patch">0001-Redmine-default-locale-used-before-browser-locale.patch</a> added</li></ul><p>Here the minor change needed to integrate that need written counter <a class="changeset" title="Remove duplicate validation." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/3110">r3110</a>.</p> Redmine - Defect #4311: Settings default language not (really) usedhttps://www.redmine.org/issues/4311?journal_id=125862009-11-30T12:54:18ZHenrik Ammer
<ul></ul><p>Thomas Lecavelier wrote:</p>
<blockquote>
<p>Here the minor change needed to integrate that need written counter <a class="changeset" title="Remove duplicate validation." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/3110">r3110</a>.</p>
</blockquote>
<p>But if Redmine sets the language shown to the default language of Redmine it should not be needed to check for accepted languages from the user since it will never happen since Redmine always has a default language.<br />Therefor row 99-104 is obsolete.</p>
<p>Maybe a setting is better then removing the functionality?</p> Redmine - Defect #4311: Settings default language not (really) usedhttps://www.redmine.org/issues/4311?journal_id=126042009-12-01T07:52:18ZThomas Lecavelier
<ul><li><strong>File</strong> <a href="/attachments/2860">0001-Redmine-default-locale-used-before-browser-locale-en.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2860/0001-Redmine-default-locale-used-before-browser-locale-en.patch">0001-Redmine-default-locale-used-before-browser-locale-en.patch</a> added</li></ul><p>Henrik Jönsson wrote:</p>
<blockquote>
<p>Maybe a setting is better then removing the functionality?</p>
</blockquote>
<p>That's the setting ;)</p>
<p>I enabled the auto in this patch, and change the language.nil? for a language.blank? that do the work: if you leave it to "auto", the HTTP_ACEPT_LANGUAGE is required.</p> Redmine - Defect #4311: Settings default language not (really) usedhttps://www.redmine.org/issues/4311?journal_id=126312009-12-02T17:56:13ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>The default language setting is also used in a few places. We just can't leave it blank.<br />Instead, a setting to enable/disable browser language recognition should be added.</p> Redmine - Defect #4311: Settings default language not (really) usedhttps://www.redmine.org/issues/4311?journal_id=126322009-12-02T17:58:44ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Duplicate</i></li></ul><p>Actually, it was already discussed in <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Option to disable automated language-guessing based on HTTP_ACCEPT_LANGUAGE HTTP-header (Closed)" href="https://www.redmine.org/issues/2691">#2691</a>.</p>