https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-07-12T19:40:00ZRedmineRedmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=182482010-07-12T19:40:00ZFelix Schäfer
<ul><li><strong>File</strong> <a href="/attachments/4105">add_link_to_edit_associated_wiki_page_to_version_show.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4105/add_link_to_edit_associated_wiki_page_to_version_show.patch">add_link_to_edit_associated_wiki_page_to_version_show.patch</a> added</li><li><strong>Category</strong> set to <i>UI</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>7</i></li><li><strong>Assignee</strong> set to <i>Felix Schäfer</i></li></ul><p>Here my proposed patch.</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=183332010-07-14T21:47:23ZMischa The Evil
<ul></ul><p>Felix Schäfer wrote:</p>
<blockquote>
<p>Here my proposed patch.</p>
</blockquote>
<p>Great! It's a small but time-saving change which might be targetted to Redmine <a class="version" href="https://www.redmine.org/versions/21">1.0.1</a>??</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=204352010-09-17T17:41:38ZFelix Schäfer
<ul><li><strong>Assignee</strong> changed from <i>Felix Schäfer</i> to <i>Jean-Baptiste Barth</i></li></ul><p>I've updated the patch so it merges correctly (the locales fail to merge, the code works ok though), the commit can be found here: <a class="external" href="http://github.com/thegcat/redmine/commit/f1a8ca801f728d9ed6ed40467fd0c73ecc768219">http://github.com/thegcat/redmine/commit/f1a8ca801f728d9ed6ed40467fd0c73ecc768219</a></p>
<p><a class="user active" href="https://www.redmine.org/users/10100">jb grenot</a>: this one's for you :-)</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=204652010-09-18T17:28:24ZJean-Baptiste Barth
<ul><li><strong>Status</strong> changed from <i>7</i> to <i>Resolved</i></li><li><strong>Target version</strong> set to <i>1.0.2</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Thanks, committed in <a class="changeset" title="Adds a link to edit the associated wiki page on the version view. #4416 Contributed by Felix Sch..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4101">r4101</a> (I added french translation, I presume Azamat will deal with other locales).</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=204732010-09-19T15:39:21ZMischa The Evil
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>7</i></li><li><strong>Resolution</strong> deleted (<del><i>Fixed</i></del>)</li></ul><p><a class="user active" href="https://www.redmine.org/users/113251">Артем Малахов</a>, JBB,</p>
<p><a class="changeset" title="Adds a link to edit the associated wiki page on the version view. #4416 Contributed by Felix Sch..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4101">r4101</a> misses the <code>:id</code> parameter in the URL. This leads to incorrect links to the designated wiki-pages (in my case it led to an edit-link linking to the correct-page in wrong projects (since it uses the <code>version_id</code> as the <code>project_id</code>)).</p>
<p>This can be fixed easily by applying the following patch:</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: app/views/versions/show.rhtml
===================================================================
</span><span class="gd">--- app/views/versions/show.rhtml (revision 4101)
</span><span class="gi">+++ app/views/versions/show.rhtml (working copy)
</span><span class="p">@@ -1,6 +1,6 @@</span>
<div class="contextual">
<%= link_to_if_authorized l(:button_edit), {:controller => 'versions', :action => 'edit', :id => @version}, :class => 'icon icon-edit' %>
<span class="gd">-<%= link_to_if_authorized(l(:button_edit_associated_wikipage, :page_title => @version.wiki_page_title), {:controller => 'wiki', :action => 'edit', :page => Wiki.titleize(@version.wiki_page_title)}, :class => 'icon icon-edit') unless @version.wiki_page_title.blank? || @project.wiki.nil? %>
</span><span class="gi">+<%= link_to_if_authorized(l(:button_edit_associated_wikipage, :page_title => @version.wiki_page_title), {:controller => 'wiki', :action => 'edit', :id => @project, :page => Wiki.titleize(@version.wiki_page_title)}, :class => 'icon icon-edit') unless @version.wiki_page_title.blank? || @project.wiki.nil? %>
</span> <%= call_hook(:view_versions_show_contextual, { :version => @version, :project => @project }) %>
</div>
</code></pre> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=204782010-09-19T20:03:40ZJean-Baptiste Barth
<ul></ul><p>Thanks Mischa, I'll have a look at it.</p>
<p>Is there any reason why links in "Roadmap" section and "Settings" section are not the same ? The first ones are scoped under the project, the second ones not. Maybe it should be unified too.</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=204812010-09-20T02:18:52ZMischa The Evil
<ul></ul><p>Jean-Baptiste Barth wrote:</p>
<blockquote>
<p>Is there any reason why links in "Roadmap" section and "Settings" section are not the same ? The first ones are scoped under the project, the second ones not. Maybe it should be unified too.</p>
</blockquote>
<p>Hmm, not sure but I guess it's mainly due to historical design-choices by JPL which may have been obsoleted/changed in time. Limited by my current skills/time I'm not able to say whether it should/could be unified...</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=204862010-09-20T03:25:29ZEric Davis
<ul><li><strong>Target version</strong> deleted (<del><i>1.0.2</i></del>)</li></ul><p>Let me know when this is ready for 1.0.2 and I'll merge <a class="changeset" title="Adds a link to edit the associated wiki page on the version view. #4416 Contributed by Felix Sch..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4101">r4101</a> along with the fix.</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=209142010-10-01T22:46:54ZMischa The Evil
<ul></ul><p>JBB,</p>
<p>Could you also take a look at the related issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Links to wikipages bound to versions do not respect version-sharing in Settings -> Versions (Closed)" href="https://www.redmine.org/issues/6435">#6435</a>?</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=209172010-10-01T23:18:49ZEric Davis
<ul><li><strong>Target version</strong> set to <i>1.0.3</i></li></ul> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=218502010-10-27T18:05:04ZFelix Schäfer
<ul></ul><p>Ok, just adapted Mischa's patch to trunk and used the same link in the project settings > versions. The idea for the later was to only show the title instead of the link to the wiki page if the user doesn't have the permission to view it, but <code>link_to_if_authorized</code> doesn't seem to get it correctly, I suppose that's a problem with <code>link_to_if_authorized</code> rather than with the changes here though.</p>
<p>See <a class="external" href="http://github.com/thegcat/redmine/commit/45dd6cf75fefdae756e82c305231d59814d4260c">http://github.com/thegcat/redmine/commit/45dd6cf75fefdae756e82c305231d59814d4260c</a> (also fixes <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Links to wikipages bound to versions do not respect version-sharing in Settings -> Versions (Closed)" href="https://www.redmine.org/issues/6435">#6435</a>)</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=219512010-10-29T22:34:03ZJean-Baptiste Barth
<ul><li><strong>Status</strong> changed from <i>7</i> to <i>Resolved</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Have you investigated the problem with <code>link_to_if_authorized</code> ? Anyway, I applied the patch in <a class="changeset" title="Fix wikilinks in project > settings > versions and version view. #6435 #4416 Contributed by Misc..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4307">r4307</a> for 1.0.3 release (Eric: don't forget to merge <a class="changeset" title="Adds a link to edit the associated wiki page on the version view. #4416 Contributed by Felix Sch..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4101">r4101</a> too), hoping we could simplify those statements soon.</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=219532010-10-29T22:42:48ZFelix Schäfer
<ul></ul><p>Jean-Baptiste Barth wrote:</p>
<blockquote>
<p>Have you investigated the problem with <code>link_to_if_authorized</code> ?</p>
</blockquote>
<p>No, and I have other more important stuff to tackle before that. Opened <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Weird link_to_if_authorized behavior (Closed)" href="https://www.redmine.org/issues/6776">#6776</a> to remember to investigate that.</p> Redmine - Feature #4416: Link from version details page to edit the wiki.https://www.redmine.org/issues/4416?journal_id=220082010-11-01T00:22:50ZEric Davis
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged into 1.0-stable for release in 1.0.3</p>