https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-03-16T14:27:14ZRedmineRedmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=151902010-03-16T14:27:14ZToshi MARUYAMA
<ul></ul><p>Please see <a class="external" href="http://www.redmine.org/issues/4773#note-14">http://www.redmine.org/issues/4773#note-14</a> and try patch of <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Redmine+Git+PostgresSQL 8.4 fails with linux kernel tree (encoding) (Closed)" href="https://www.redmine.org/issues/4773">#4773</a>.</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=151912010-03-16T14:54:00ZVladimir Babchuk
<ul></ul><p>Toshi Maruyama wrote:</p>
<blockquote>
<p>Please see <a class="external" href="http://www.redmine.org/issues/4773#note-14">http://www.redmine.org/issues/4773#note-14</a> and try patch of <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Redmine+Git+PostgresSQL 8.4 fails with linux kernel tree (encoding) (Closed)" href="https://www.redmine.org/issues/4773">#4773</a>.</p>
</blockquote>
<p>Patches didn't help.. (First patch was already in release, second - didn't help).<br />It seems that code hungs at call to shellout function:<br />Mongrel::TimeoutError (Mongrel timed out this thread: shutdown):<br /> lib/redmine/scm/adapters/abstract_adapter.rb:191:in `shellout'<br /> lib/redmine/scm/adapters/abstract_adapter.rb:177:in `shellout'<br /> lib/redmine/scm/adapters/git_adapter.rb:92:in `lastrev'<br /> lib/redmine/scm/adapters/git_adapter.rb:78<br /> lib/redmine/scm/adapters/git_adapter.rb:66:in `each_line'<br /> lib/redmine/scm/adapters/git_adapter.rb:66<br /> lib/redmine/scm/adapters/abstract_adapter.rb:193:in `call'<br /> lib/redmine/scm/adapters/abstract_adapter.rb:193:in `shellout'<br /> lib/redmine/scm/adapters/abstract_adapter.rb:191:in `popen'<br /> lib/redmine/scm/adapters/abstract_adapter.rb:191:in `shellout'<br /> lib/redmine/scm/adapters/abstract_adapter.rb:177:in `shellout'<br /> lib/redmine/scm/adapters/git_adapter.rb:65:in `entries'<br /> app/models/repository.rb:63:in `entries'<br /> app/controllers/repositories_controller.rb:72:in `show'</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=151922010-03-16T14:57:13ZToshi MARUYAMA
<ul></ul><p>Vladimir Babchuk wrote:</p>
<blockquote>
<p>Patches didn't help.. (First patch was already in release, second - didn't help).</p>
</blockquote>
<p>Sorry, patch is <a class="external" href="http://www.redmine.org/attachments/3272/git-fast-browse.patch">http://www.redmine.org/attachments/3272/git-fast-browse.patch</a> .</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=151932010-03-16T15:13:31ZVladimir Babchuk
<ul></ul><p>Toshi Maruyama wrote:</p>
<blockquote>
<p>Vladimir Babchuk wrote:</p>
<blockquote>
<p>Patches didn't help.. (First patch was already in release, second - didn't help).</p>
</blockquote>
<p>Sorry, patch is <a class="external" href="http://www.redmine.org/attachments/3272/git-fast-browse.patch">http://www.redmine.org/attachments/3272/git-fast-browse.patch</a> .</p>
</blockquote>
<p>Thanks! That patch helped me. <br />But... it like a hack (now I can't see revision, comment and etc. in repo browser). So problem is still remained. <br />Any thoughts how to fix it right? I can tree it in free time, but i can't realize what is causes it.<br />If execute commands that executes <code>shellout</code> by hand - git exits instantly. <br />By default git uses <code>less</code> to page results, but I disabled it. What else can cause thread lockup?</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=151942010-03-16T15:25:52ZToshi MARUYAMA
<ul></ul><p>Vladimir Babchuk wrote:</p>
<blockquote>
<p>Thanks! That patch helped me. <br />But... it like a hack (now I can't see revision, comment and etc. in repo browser). So problem is still remained. <br />Any thoughts how to fix it right? I can tree it in free time, but i can't realize what is causes it.<br />If execute commands that executes <code>shellout</code> by hand - git exits instantly. <br />By default git uses <code>less</code> to page results, but I disabled it. What else can cause thread lockup?</p>
</blockquote>
<p><a class="external" href="http://www.redmine.org/issues/4773#note-12">http://www.redmine.org/issues/4773#note-12</a></p>
<blockquote>
<p>Actually, what is really slow when browsing a git repository is to get information about last change on each file using git log -n 1. When removing this, browsing is pretty fast. Maybe we should disable this.</p>
</blockquote> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=151952010-03-16T15:30:28ZVladimir Babchuk
<ul></ul><p>Toshi Maruyama wrote:</p>
<blockquote>
<p>Actually, what is really slow when browsing a git repository is to get information about last change on each file using git log -n 1. When removing this, browsing is pretty fast. Maybe we should disable this.</p>
</blockquote>
<p>Yes, I see. But in my repository only near ~15 files and ~10 commits. It can't be parsed so long! I think - there are other cause of this problem.</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=184502010-07-19T19:41:37ZMitch Pirtle
<ul></ul><p>I'm having the same performance problems related to git repositories. First the obligatory ENV schtuff:</p>
<ul>
<li>Redmine 0.9.2.devel.3437 (MySQL)</li>
<li>ruby 1.8.7 (2009-06-12 patchlevel 174) [x86_64-linux]</li>
<li>Rails 2.3.5</li>
<li>mysql Ver 14.12 Distrib 5.0.51a, for debian-linux-gnu (x86_64) using readline 5.2</li>
</ul>
<p>Info about repo:</p>
<ul>
<li>git version 1.5.6.5</li>
<li>400 commits</li>
<li>< 5,000 files</li>
</ul>
<p>Troubling for me is how redmine completely blocks until this view is rendered, and we're talking several minutes.</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=184762010-07-19T21:12:00ZFelix Schäfer
<ul></ul><p>Mitch Pirtle wrote:</p>
<blockquote>
<ul>
<li>Redmine 0.9.2.devel.3437 (MySQL)</li>
</ul>
</blockquote>
<p>Which has known performance issue with git, I don't they have been backported to 0.9.x, but definitely are in 1.0.x and trunk.</p>
<blockquote>
<p>Troubling for me is how redmine completely blocks until this view is rendered, and we're talking several minutes.</p>
</blockquote>
<p>What rails server do you use? If it's a single webrick or mongrel, that happens because multi-threading/multiple incoming connections are handled by spinning up more instances, which neither of both does on itself.</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=184842010-07-19T21:42:18ZMitch Pirtle
<ul></ul><p>Thanks for the explanation Felix.</p>
<p>This is a dev server running lighttpd, which probably explains the blocking.</p>
<p>Will update to trunk when I get the chance, as we could really use some relief.</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=224482010-11-16T08:17:25ZToshi MARUYAMA
<ul></ul><p>Redmine git adapter use "io.gets" at <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/tags/1.0.3/lib/redmine/scm/adapters/git_adapter.rb#L94">source:tags/1.0.3/lib/redmine/scm/adapters/git_adapter.rb#L94</a> .<br />It seems there is same problem with <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: svn: Write error: Broken pipe when browsing repository (Closed)" href="https://www.redmine.org/issues/6860">#6860</a>.<br />It maybe we should use "io.each_line" instead of "io.gets".</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=226352010-11-23T08:37:09ZToshi MARUYAMA
<ul><li><strong>File</strong> <a href="/attachments/4890">git-io-gets.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4890/git-io-gets.diff">git-io-gets.diff</a> added</li><li><strong>% Done</strong> changed from <i>0</i> to <i>50</i></li></ul><p>I create a patch replacing "io.gets" and I attach it.</p> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=236422011-01-03T11:14:17ZToshi MARUYAMA
<ul><li><strong>Assignee</strong> set to <i>Toshi MARUYAMA</i></li><li><strong>Target version</strong> set to <i>1.1.0</i></li></ul> Redmine - Defect #5096: Redmine hangs up while browsing Git repositoryhttps://www.redmine.org/issues/5096?journal_id=236442011-01-03T11:18:15ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>This issue's original problem seems to io.gets() problem.<br />I committed <a class="changeset" title="repository: git: change io.gets to io.readlines (#5404, #5096)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4624">r4624</a> in svn trunk and <a class="changeset" title="Merged r4624 from trunk." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4627">r4627</a> in 1.1.<br />Git browsing performance issue is <a class="issue tracker-1 status-1 priority-3 priority-lowest" title="Defect: Git adapter very slow when a commit modifies a lot of files (New)" href="https://www.redmine.org/issues/7047">#7047</a>.<br />I close this issue.</p>