https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-06-04T15:06:45ZRedmineRedmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=171482010-06-04T15:06:45ZHolger Just
<ul><li><strong>File</strong> <a href="/attachments/3910">5329_add_year_of_week_to_time_entries.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3910/5329_add_year_of_week_to_time_entries.diff">5329_add_year_of_week_to_time_entries.diff</a> added</li></ul><p>The attached patch fixes the edge case.</p>
<p>It introduces a new field named <code>twyear</code> to the time entries. It contains the year of the week of the entry. So for the above example, its content for both entries would be <code>2009</code>. That way, it is possible to properly group based on weeks.</p>
<p>The included tests run in a current trunk.</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=174582010-06-19T16:43:28ZHolger Just
<ul></ul><p>Just verified that patch again on a current trunk.</p>
<p>It is clean and does what it advertises. I'm just not 100% sure if I managed to find all usages of the week stuff in time_entries. But I'm rather confident, I did.</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=175042010-06-19T22:08:42ZHolger Just
<ul></ul><p>Okay, after thinking a bit more about it (and fixing some other bugs :)), I conclude that the whole concept of denormalizing the week into the database for grouping can not properly work.</p>
<p>This is because the week boundaries expected by a user are actually not fixed but depend on her settings. So the actual data set in a group depends on user settings. To always show the correct result, we would have to</p>
<ul>
<li>either save at least two variants of the tweek + twyear (for week starting sunday or monday)</li>
<li>or calculate the week using SQL-functions.</li>
</ul>
<p>I would prefer the second method. Unfortunately, these functions are not fully standardized, so there would be a differentiation needed for different database engines.</p>
<p>Until then, the attached patch fixes the behavior for the standard commercial week starting on Mondays.</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=443072013-01-14T15:04:49ZDaniel Felix
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li><li><strong>Affected version (unused)</strong> deleted (<del><i>devel</i></del>)</li></ul><p>This is another issue regarding the timelog. Someone who can confirm this is still able to reproduce in trunk?</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=446462013-01-18T06:38:42ZAlexey Verin
<ul></ul><p>Please, update patch for version 2.2.1.<br />My Ruby skill is not enough for this (</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=446822013-01-19T03:58:31ZMischa The Evil
<ul></ul><p>Daniel Felix wrote:</p>
<blockquote>
<p>[...] Someone who can confirm this is still able to reproduce in trunk?</p>
</blockquote>
<p>I can't remember any changes that fixes this issue specifically, though I'm unable to test this on current trunk.</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=446882013-01-19T07:53:10ZDaniel Felix
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>Confirmed</i></li></ul><p>Alexey already encountered this big again. (See linked ticket) <br />This is the confirmation for this issue.</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=459022013-02-19T17:18:29ZFilou Centrinov
<ul></ul><p>Duplicate: <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Spent Time report - Column Total different for week (Closed)" href="https://www.redmine.org/issues/13159">#13159</a></p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=459562013-02-21T23:08:35ZFilou Centrinov
<ul><li><strong>File</strong> <a href="/attachments/9137">time_report.rb.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/9137/time_report.rb.patch">time_report.rb.patch</a> added</li></ul><p>I fixed this issue with a patch. Could we add this to Redmine 2.3?<br />I verfied my solution for different weeks constellations: Years with 52 and 53 weeks or first week that starts in last year and those which don't. Everthing works fine.</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=459592013-02-22T01:24:33ZFilou Centrinov
<ul><li><strong>File</strong> <a href="/attachments/9138">time_report.rb.2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/9138/time_report.rb.2.patch">time_report.rb.2.patch</a> added</li></ul> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=459622013-02-22T10:54:50ZDaniel Felix
<ul></ul><p>The patch works on my testsystem too. Thanks for providing this patch!</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=459632013-02-22T12:16:10ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=460222013-02-24T12:19:40ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>2.3.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Patch committed in <a class="changeset" title="Fixed that time entries report by week breaks on edge cases (#5329)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/11471">r11471</a> with a test, thanks.</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=463132013-03-03T23:04:45ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Group-by week of time entries breaks on edge cases</i> to <i>Time entries report broken on first week of year</i></li></ul> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=464802013-03-09T09:15:53ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged.</p> Redmine - Defect #5329: Time entries report broken on first week of yearhttps://www.redmine.org/issues/5329?journal_id=472322013-03-21T09:40:34ZPavel Potcheptsovektos.net@gmail.com
<ul></ul><p>Hello, I've updated to 2.3.0.<br />Is it all right with:<br />Project -> Overview -> Report -> Details: Days, Add: User ?<br />What Days it should display?<br />In my case it displays days from 2012 year and not the last days, when time was logged in 2013.</p>