https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292011-02-05T12:56:07ZRedmineRedmine - Defect #6090: Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows serverhttps://www.redmine.org/issues/6090?journal_id=248612011-02-05T12:56:07ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>7</i></li><li><strong>Assignee</strong> set to <i>Toshi MARUYAMA</i></li><li><strong>Priority</strong> changed from <i>High</i> to <i>Normal</i></li></ul> Redmine - Defect #6090: Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows serverhttps://www.redmine.org/issues/6090?journal_id=248982011-02-07T11:02:57ZToshi MARUYAMA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li></ul> Redmine - Defect #6090: Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows serverhttps://www.redmine.org/issues/6090?journal_id=250592011-02-09T23:49:13ZToshi MARUYAMA
<ul><li><strong>File</strong> <a href="/attachments/5351">cvs-cat-bin.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5351/cvs-cat-bin.diff">cvs-cat-bin.diff</a> added</li></ul><p>Gareth, Could you try this patch?<br />And where can I download Windows CVS 1.12 binary?</p> Redmine - Defect #6090: Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows serverhttps://www.redmine.org/issues/6090?journal_id=250662011-02-10T08:46:25ZGareth Sylvester-Bradley
<ul></ul><p>Maruyama-san,</p>
<blockquote>
<p>Gareth, Could you try this patch?</p>
</blockquote>
<p>Your patch works great on my system, thanks.</p>
<p>You probably spotted that my original patch was flawed, since some of the other calls to shellout() need to be opened using "r+" instead of "r+b"; since submitting my original one, I modified it locally to pass the mode as an argument with a default of "r+".</p>
<p>Your solution is neater!</p>
<blockquote>
<p>And where can I download Windows CVS 1.12 binary?</p>
</blockquote>
<p>My CVS servers are running CVS 1.11 (stable), although I'd like CVS 1.12 for the enhanced directory listing. At the moment, I'm relying on patch <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Directory listing with CVS v1.11 patch (Closed)" href="https://www.redmine.org/issues/4113">#4113</a>.</p>
<p>My Redmine server seems to have very old CVSNT 2.5.03 client.</p>
Links:
<ul>
<li><a class="external" href="http://ftp.gnu.org/non-gnu/cvs/binary/stable/x86-woe/">http://ftp.gnu.org/non-gnu/cvs/binary/stable/x86-woe/</a> (Windows CVS 1.11)</li>
<li><a class="external" href="http://ftp.gnu.org/non-gnu/cvs/binary/feature/x86-woe/">http://ftp.gnu.org/non-gnu/cvs/binary/feature/x86-woe/</a> (Windows CVS 1.12)</li>
<li><a class="external" href="http://www.cvsnt.org/">http://www.cvsnt.org/</a></li>
</ul>
<p>Thanks,<br />Gareth</p> Redmine - Defect #6090: Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows serverhttps://www.redmine.org/issues/6090?journal_id=251042011-02-11T08:29:40ZToshi MARUYAMA
<ul><li><strong>Target version</strong> set to <i>1.1.2</i></li><li><strong>Affected version (unused)</strong> set to <i>1.1.1</i></li><li><strong>Affected version</strong> set to <i>1.1.1</i></li></ul> Redmine - Defect #6090: Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows serverhttps://www.redmine.org/issues/6090?journal_id=251472011-02-12T12:02:11ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>7</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>I commited trunk <a class="changeset" title="scm: cvs: fix most binary files become corrupted on Windows (#6090)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4815">r4815</a> and 1.1 stable <a class="changeset" title="Merged r4815 from trunk. scm: cvs: fix most binary files become corrupted on Windows." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4818">r4818</a>.</p>
<p>Thanks.</p>