https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292008-03-10T02:55:42ZRedmineRedmine - Patch #821: Patch for #791 (Search for all projects issues)https://www.redmine.org/issues/821?journal_id=17352008-03-10T02:55:42ZAngel Sciortino
<ul></ul><p>Also patch for <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: search in all project wikis simultanously (Closed)" href="https://www.redmine.org/issues/379">#379</a> (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Search for all projects issues (Closed)" href="https://www.redmine.org/issues/791">#791</a> is a duplicate)</p> Redmine - Patch #821: Patch for #791 (Search for all projects issues)https://www.redmine.org/issues/821?journal_id=18392008-03-16T01:16:27ZW Snyder
<ul><li><strong>File</strong> <a href="/attachments/331">311_search_all_projects_default.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/331/311_search_all_projects_default.patch">311_search_all_projects_default.patch</a> added</li></ul><p>This updates the patch to work with revision <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: 在生成PDF文件时,中文出现乱码 (Closed)" href="https://www.redmine.org/issues/1249">#1249</a>, and also makes all_projects be the default when inside a project.</p>
<p>IMHO having a single search dialog that always works the same is far more intuitive (people expect Google behavior), and so I'm going to modify it slightly so the outside-a-project search also searches all projects. But, that seems beyond the intent of the original patch, so this is not included in my mod.</p> Redmine - Patch #821: Patch for #791 (Search for all projects issues)https://www.redmine.org/issues/821?journal_id=18572008-03-16T17:07:18ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Category</strong> set to <i>Search engine</i></li><li><strong>Target version</strong> set to <i>0.8</i></li></ul><p>This is definitely a must-have feature.<br />But with this patch, the number of queries will grow with the total number of projects. I would prefer a solution where a single query is executed for each kind of object (as it's done for the cross-project activity view). I'll work on it.</p>
<p>By the way, there's a small bug in the <code>object_types_and_scope</code> method: the <a class="user active" href="https://www.redmine.org/users/11497">Herve Harster</a> instance variable is used instead of the argument.</p> Redmine - Patch #821: Patch for #791 (Search for all projects issues)https://www.redmine.org/issues/821?journal_id=27922008-05-16T23:53:49ZPeter Van den Bosch
<ul><li><strong>File</strong> <a href="/attachments/532">search_all_projects.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/532/search_all_projects.png">search_all_projects.png</a> added</li><li><strong>File</strong> <a href="/attachments/533">search_all_projects_from_home.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/533/search_all_projects_from_home.png">search_all_projects_from_home.png</a> added</li><li><strong>File</strong> <a href="/attachments/534">search_all_projects_one_query.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/534/search_all_projects_one_query.patch">search_all_projects_one_query.patch</a> added</li></ul><p>Hi, I wrote a patch which does it in a single query per object while limiting the scope to only projects for which the user has the necessary permissions.<br />Included some screenies too.</p>
<p>The behavior of the patch is as follows:</p>
When not inside a project:
<ul>
<li>searches all projects including project names</li>
<li>only checkboxes for categories where a user has a right to in some project are rendered</li>
<li>the automatic redirect to a project if only one result has been removed</li>
</ul>
When inside a project:
<ul>
<li>defaults to search inside the project only</li>
<li>a checkbox is present to search in all projects (maybe this should be the default?)</li>
<li>does not search in project names (maybe should be present as a greyed out option when 'search all projects' is unchecked)</li>
</ul>
<p>Could you give feedback on this patch? I'd like to make it ready for inclusion.</p>
<p>btw, it still has some problems with anonymous users and non-members when searching all projects. This is because User.allowed_to? returns false for :global instead of checking anonymous and non-member roles.</p> Redmine - Patch #821: Patch for #791 (Search for all projects issues)https://www.redmine.org/issues/821?journal_id=28082008-05-18T16:18:37ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Functionality added in <a class="changeset" title="Ability to search all projects or the projects the user belongs to (#791)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/1435">r1435</a>.<br />Peter: your patch looks to work fine but I used a different approach that should be a bit more efficient when there are many public projects. Thanks.<br />Also, I added the ability to search 'My projects' only.</p> Redmine - Patch #821: Patch for #791 (Search for all projects issues)https://www.redmine.org/issues/821?journal_id=38082008-07-09T12:41:37ZJosé Campos
<ul></ul><p>Please, help me understand this: Is it a desired feature that a user can see issues from projects he does not belongs to?<br />When I search outside a project, I can see in the search results issues belonging to projects that are supposed to be restricted to me...</p>