https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292011-07-07T05:50:49ZRedmineRedmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=305552011-07-07T05:50:49ZAlex Shulgin
<ul><li><strong>File</strong> <a href="/attachments/6248">0001-Fixed-setting-issue-attributes-by-mail-use-only-the-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6248/0001-Fixed-setting-issue-attributes-by-mail-use-only-the-.patch">0001-Fixed-setting-issue-attributes-by-mail-use-only-the-.patch</a> added</li></ul><p>Confirmed with git:1.2-stable.</p>
<p>Attached is a fix to this problem. The fix makes it search for the first match of <code>/^attr: value$/</code> and ignore the rest of the mail body.</p> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=305592011-07-07T09:26:15ZEtienne Massip
<ul><li><strong>Category</strong> set to <i>Email receiving</i></li></ul> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=305752011-07-07T19:10:17ZEtienne Massip
<ul><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=316962011-08-23T19:32:46ZDrew Keller
<ul></ul><p>I noticed this same problem. I used Alex's fix to get it working properly. Redmine 1.2.1</p> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=317052011-08-24T07:34:07ZEtienne Massip
<ul></ul><p>The fix should be to use <code>cleaned_up_text_body</code> instead of <code>plain_text_body</code> in call to <code>#extract_keyword!</code> (<a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/app/models/mail_handler.rb#L229">source:/trunk/app/models/mail_handler.rb#L229</a> as of <a class="changeset" title="Fixes mail handler for when there's no attachments (#8651)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/6325">r6325</a>), isn't it?</p> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=317132011-08-24T11:05:05ZAlex Shulgin
<ul></ul><p>Etienne Massip wrote:</p>
<blockquote>
<p>The fix should be to use <code>cleaned_up_text_body</code> instead of <code>plain_text_body</code> in call to <code>#extract_keyword!</code> (<a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/app/models/mail_handler.rb#L229">source:/trunk/app/models/mail_handler.rb#L229</a> as of <a class="changeset" title="Fixes mail handler for when there's no attachments (#8651)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/6325">r6325</a>), isn't it?</p>
</blockquote>
<p>Yeah, but <code>Setting.mail_handler_body_delimiters</code> is blank by default, so this isn't really going to work.</p> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=317202011-08-24T13:58:00ZEtienne Massip
<ul></ul><p>Right, both fixes should be committed.</p>
<p>BTW, adding a line "--- Please reply ABOVE THIS LINE to respond to this issue ---" requires a bit of tweaking, already?</p>
<p>Maybe that the first delimiter /^>\s*--.*$/ could be considered by default as a reply separator?</p> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=317212011-08-24T14:31:08ZAlex Shulgin
<ul></ul><p>Etienne Massip wrote:</p>
<blockquote>
<p>Right, both fixes should be committed.</p>
<p>BTW, adding a line "--- Please reply ABOVE THIS LINE to respond to this issue ---" requires a bit of tweaking, already?</p>
</blockquote>
<p>Well, yes, and adding that line as a email-truncation pattern makes sense, once you add it to the email header.</p>
<blockquote>
<p>Maybe that the first delimiter /^>\s*--.*$/ could be considered by default as a reply separator?</p>
</blockquote>
<p>I wouldn't vote for that. Imagine someone forwarding some mail or adding redmine address in reply, so that the quoted text isn't coming from the ticket history. If we were to cut the mail at the above pattern, we might be missing valuable information intended to be included in the ticket history.</p> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=573412014-07-06T12:59:19ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>2.6.0</i></li></ul> Redmine - Defect #8758: Ignore email keywords after delimiterhttps://www.redmine.org/issues/8758?journal_id=587732014-09-20T07:53:36ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Parsing of variables for incoming emails</i> to <i>Ignore email keywords after delimiter</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Fixed in <a class="changeset" title="Ignore email keywords after truncation line (#8758)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13413">r13413</a>.</p>