Project

General

Profile

Actions

Feature #34787

closed

Ability to set default value for "I don't want to be notified of changes that I make myself"

Added by Pierre DEPREY over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Email notifications
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Hello,

I search many possibilites to change the default value of no_self_notified when creating a new user.
Actually default is true.

line 54 to 56 in /app/models/user_preference.rb

unless attributes && attributes.key?(:no_self_notified)
  self.no_self_notified = true
end

might be :

unless attributes && attributes.key?(:no_self_notified)
  self.no_self_notified = Setting.default_users_no_self_notified
end

and add in config/settings.yml

default_users_no_self_notified:
  default: true

With this change, we can modify the default value without changing source code of Redmine.

this may be implemented in a future release ?

Regards,

Pierre


Files

settings.png (53.3 KB) settings.png Go MAEDA, 2021-02-23 14:49
34787.patch (2.23 KB) 34787.patch Go MAEDA, 2021-02-23 15:03

Related issues

Related to Redmine - Feature #14574: "I don't want to be notified of changes that I make myself" as Default for all UserClosedJean-Philippe Lang

Actions
Has duplicate Redmine - Feature #24629: Add option to decide default value for "I don't want to be notified of changes that I make myself"Closed

Actions
Actions #1

Updated by Go MAEDA over 3 years ago

  • Related to Feature #14574: "I don't want to be notified of changes that I make myself" as Default for all User added
Actions #2

Updated by Go MAEDA over 3 years ago

Here is a patch to implement the feature. Admin > Settings > Users will have "I don't want to be notified of changes that I make myself" checkbox.

Actions #3

Updated by Pierre DEPREY over 3 years ago

  • Status changed from New to Resolved

Thank you, this patch is exactly what i've needed.

Actions #4

Updated by Marius BĂLTEANU over 3 years ago

  • Status changed from Resolved to New

We should keep this ticket in "New" until the patch is committed.

Actions #5

Updated by Marius BĂLTEANU over 3 years ago

  • Target version set to Candidate for next major release
Actions #6

Updated by Go MAEDA over 3 years ago

  • Subject changed from ability to set default value for no_self_notified in config/settings.yml to Ability to set default value for "I don't want to be notified of changes that I make myself"
  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

Actions #7

Updated by Go MAEDA over 3 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Actions #8

Updated by Go MAEDA over 3 years ago

  • Has duplicate Feature #24629: Add option to decide default value for "I don't want to be notified of changes that I make myself" added
Actions

Also available in: Atom PDF