Code Review Plugin

Added by Haruyuki Iida over 10 years ago

Hi. Let me announce to you My "Code Review Plugin" .It makes you can write code reviews of committed source code on Redmine's "Diff" page of repository browser.

like this...

Adding review.

Adding rview

Showing reviews.

Showing reviews

I tested this plugin on Redmine 0.8.3 and current trunk.
I hope you will like this plugin. Thanks.

add_review.png - Adding rview (21.4 KB)

show_reviews.png - Showing reviews (45 KB)

Replies (118)

RE: Code Review Plugin - Added by Haruyuki Iida over 10 years ago

Thanks Tohmas, Muhamed.

Well, maybe this plugin needs a code review:,-(

Please try this one. I added some debug messages.
http://r-labs.googlecode.com/files/redmine_code_review-0.1.3.2.zip

Try to add a new review. And if you find any errors, show me.

RE: Code Review Plugin - Added by Muhamed niyas over 10 years ago

Hi Haru,

I tried the new version and i am getting a different error now.
i am attaching the screenshots of the repository file difference and
the 'code review' window.

diff_error.jpg (94.5 KB)

code_review.jpg (37.5 KB)

RE: Code Review Plugin - Added by Haruyuki Iida over 10 years ago

Thanks Muhamed.

Maybe problem is resolved. Try redmine_code_review-0.1.3.3.zip.

RE: Code Review Plugin - Added by Thomas M over 10 years ago

Hi Haru !

The last 1.3.3 is working fine !

I was spending a little time adding debug messages on top of 1.3.2 and spotted the "non-root" repository access when you just posted the new version.

Thanks a lot.

May I ask if you really plan to implement my view of reviewing code ?
One more time : Thanks !

RE: Code Review Plugin - Added by Muhamed niyas over 10 years ago

Haru Iida wrote:

Thanks Muhamed.

Maybe problem is resolved. Try redmine_code_review-0.1.3.3.zip.

Hi Haru,

Thanks.. My problem solved. This tool is very promising.
I have some suggestions in code review module.

1. It would be better if we can show a report with recently committed files and from that report
an option to assign a person to review the code.

Once again thanks for ur help...

Code Review Plugin 0.1.4 Released. - Added by Haruyuki Iida over 10 years ago

I released Code Review Plugin 0.1.4

http://code.google.com/p/r-labs/downloads/list

  • feature
    • e-mail notification
  • fixed bug
    • When you close review, initial review on activity page is removed.
  • todo
    • "My page" block with code reviews
    • use different image for closed reviews
    • show a report with recently committed files

RE: Code Review Plugin - Added by Haruyuki Iida over 10 years ago

Thomas M wrote:

May I ask if you really plan to implement my view of reviewing code ?

I think if you use this tool in a company, your idea is very useful.
On the other side, Like a open source project, there are may developers in the world over the Internet. I think your idea is a bit complicated for them. How do you think ?

RE: Code Review Plugin - Added by Jens Goldhammer over 10 years ago

I don´t think that it is too complicated for os projects. Maybe you can implement a beginners and an expert mode, where the export mode offers more support for enterprise users. In our company there is also a need for an easy code review tool. Each developer should review the code of another developer within a certain timespan. In my eyes, it would make sense to select a timespan for a new code review and define different sets for each developer. Developer A reviews code changes of developer B, developer B and D review code of Developer C and so on.

I would be very happy if you implement such a feature.
Thanks,
Jens

RE: Code Review Plugin - Added by Thomas M over 10 years ago

Haru Iida wrote:

I think if you use this tool in a company, your idea is very useful.
On the other side, Like a open source project, there are may developers in the world over the Internet. I think your idea is a bit complicated for them. How do you think ?

Even if it fits entreprise needs I don't think that it is targeted only to companies.

Regarding CodeReview tools available freely out there there is Google Code reviewing tools (you must know it : you're using google code hosting) and Reviewboard (Python / Django). They are both plainly available for free and they fit the opensource developping schemes.

I think that reviewing code is not browsing for fun the source code and writing some Notes. Reviewing is clearly a part of the coding process and it may involve in a structured way people that are part of the project.

I really think that you've done the hardest job, you're able to add/edit/close/remove a comment on a file/revision/line basis. What's missing are the upstream concept of roles and set of files.

One more time thanks for the job done, I will test the latest 0.1.4 on Monday ;)

RE: Code Review Plugin - Added by Vinicius Diniz over 10 years ago

I'm trying to use this plugin but doesn't work... can anyone help me?

Error:

 Showing layouts/base.rhtml where line # 17 raised:

You have a nil object when you didn't expect it!
The error occurred while evaluating nil.action_name

Extracted source (around line # 17):

14:       body {behavior: url(<%= stylesheet_path "csshover.htc" %>);}
15:     </style>
16: <![endif]-->
17: <%= call_hook :view_layouts_base_html_head %>
18: <!-- page specific tags -->
19: <%= yield :header_tags -%>
20: </head>

RE: Code Review Plugin - Added by Haruyuki Iida about 10 years ago

Vinicius Diniz wrote:

I'm trying to use this plugin but doesn't work... can anyone help me?

Hi Vinicius. Can you show me a full stack trace ?

RE: Code Review Plugin - Added by Haruyuki Iida about 10 years ago

Jens, Thomas, Thank you.

I start from the first using another review tools. And I will consider what should I do. It might be a next big step for this plugin. But I think I should do implement some basic functions before.

I am glad to hear your opinions. Thanks.

RE: Code Review Plugin - Added by Vinicius Diniz about 10 years ago

Haru,

This is the full stack trace:

vendor/plugins/redmine_code_review/lib/code_review_application_hooks.rb:23:in `view_layouts_base_html_head'
lib/redmine/hook.rb:60:in `send'
lib/redmine/hook.rb:60:in `call_hook'
lib/redmine/hook.rb:59:in `each'
lib/redmine/hook.rb:59:in `call_hook'
lib/redmine/hook.rb:104:in `call_hook'
app/views/layouts/base.rhtml:17:in `_run_erb_47app47views47layouts47base46rhtml'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/base.rb:342:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/base.rb:342:in `execute'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/template_handlers/compilable.rb:29:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/template_handlers/compilable.rb:29:in `render'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/template.rb:35:in `render'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/template.rb:22:in `render_template'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_view/base.rb:248:in `render_file'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/layout.rb:257:in `render_without_benchmark'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:51:in `render'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/core_ext/benchmark.rb:8:in `realtime'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:51:in `render'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:1161:in `default_render'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:1167:in `perform_action_without_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:579:in `call_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:572:in `perform_action_without_benchmark'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
/usr/lib/ruby/1.8/benchmark.rb:293:in `measure'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/rescue.rb:201:in `perform_action_without_caching'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/caching/sql_cache.rb:13:in `perform_action'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/connection_adapters/abstract/query_cache.rb:33:in `cache'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/query_cache.rb:8:in `cache'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/caching/sql_cache.rb:12:in `perform_action'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:529:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:529:in `process_without_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:568:in `process_without_session_management_support'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/session_management.rb:130:in `process'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:389:in `process'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:149:in `handle_request'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:107:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:104:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:104:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:120:in `dispatch_cgi'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:35:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/webrick_server.rb:112:in `handle_dispatch'
/usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/webrick_server.rb:78:in `service'
/usr/lib/ruby/1.8/webrick/httpserver.rb:104:in `service'
/usr/lib/ruby/1.8/webrick/httpserver.rb:65:in `run'
/usr/lib/ruby/1.8/webrick/server.rb:173:in `start_thread'
/usr/lib/ruby/1.8/webrick/server.rb:162:in `start'
/usr/lib/ruby/1.8/webrick/server.rb:162:in `start_thread'
/usr/lib/ruby/1.8/webrick/server.rb:95:in `start'
/usr/lib/ruby/1.8/webrick/server.rb:92:in `each'
/usr/lib/ruby/1.8/webrick/server.rb:92:in `start'
/usr/lib/ruby/1.8/webrick/server.rb:23:in `start'
/usr/lib/ruby/1.8/webrick/server.rb:82:in `start'
/usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/webrick_server.rb:62:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/commands/servers/webrick.rb:66
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/dependencies.rb:510:in `require'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/dependencies.rb:355:in `new_constants_in'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.1.2/lib/active_support/dependencies.rb:510:in `require'
/usr/lib/ruby/gems/1.8/gems/rails-2.1.2/lib/commands/server.rb:39
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
script/server:3
-e:4:in `load'
-e:4

I'm using wrong version of ruby (ruby 1.8.6 (2007-09-24 patchlevel 111)) or rails (Rails 2.1.2)?

RE: Code Review Plugin - Added by Haruyuki Iida about 10 years ago

Vinicius,

Thanks. Two more questions.

  • What version of redmine?
  • Does redmine runs in production mode or development mode?

RE: Code Review Plugin - Added by Michael Diederich about 10 years ago

Great plugin. Where could I contribute the missing translations?

RE: Code Review Plugin - Added by Haruyuki Iida about 10 years ago

Michael Diederich wrote:

Great plugin. Where could I contribute the missing translations?

Thank you. Please attach here.

RE: Code Review Plugin - Added by Michael Diederich about 10 years ago

Here you are!

de.yml Magnifier - German Translation for Code Review Plugin (637 Bytes)

RE: Code Review Plugin - Added by Vinicius Diniz about 10 years ago

Haru,

Redmine: 0.8.0
Environment: Development mode

RE: Code Review Plugin - Added by Haruyuki Iida about 10 years ago

Vinicius Diniz wrote:

Redmine: 0.8.0
Environment: Development mode

Sorry, your Redmine is too old.
This plugin needs changes of r2429 and r2522.

Can you upgrade to 0.8.4?
Or if you can't, replace redmine-0.8.0/lib/redmine/hook.rb with source:/branches/0.8-stable/lib/redmine/hook.rb, and it will be works.

One more thing. Sometimes this plugin does not work with development mode. I don't know why. Please run with production mode.

Thank you.

RE: Code Review Plugin - Added by Haruyuki Iida about 10 years ago

Michael Diederich wrote:

Here you are!

Thanks. But I gotta problem. I installed your file in my Redmine. Then error occurs on boot up. Any ideas?

=> Booting WEBrick...

C:/tmp/redmine-0.8.4/vendor/plugins/gloc-1.1.0/lib/gloc.rb:190:in `iconv': "fnen" (Iconv::IllegalSequence)
        from C:/tmp/redmine-0.8.4/vendor/plugins/gloc-1.1.0/lib/gloc.rb:190:in `load_localized_strings'
        from C:/tmp/redmine-0.8.4/vendor/plugins/gloc-1.1.0/lib/gloc.rb:189:in `each'
        from C:/tmp/redmine-0.8.4/vendor/plugins/gloc-1.1.0/lib/gloc.rb:189:in `load_localized_strings'
        from C:/tmp/redmine-0.8.4/vendor/plugins/gloc-1.1.0/lib/gloc.rb:188:in `open'
        from C:/tmp/redmine-0.8.4/vendor/plugins/gloc-1.1.0/lib/gloc.rb:188:in `load_localized_strings'
        from C:/tmp/redmine-0.8.4/vendor/plugins/gloc-1.1.0/lib/gloc.rb:175:in `each'
        from C:/tmp/redmine-0.8.4/vendor/plugins/gloc-1.1.0/lib/gloc.rb:175:in `load_localized_strings'
        from C:/tmp/redmine-0.8.4/config/initializers/30-redmine.rb:4
         ... 22 levels...
        from C:/tmp/redmine-0.8.4/vendor/rails/railties/lib/commands/server.rb:39
        from C:/ruby/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
        from C:/ruby/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
        from script/server:3

RE: Code Review Plugin - Added by Jens Goldhammer about 10 years ago

Wrong encoding. I have changed it to UTF-8...

de.yml Magnifier (640 Bytes)

RE: Code Review Plugin - Added by Michael Diederich about 10 years ago

Should I edit the file with UTF-8 mode or so? it should be "öffnen"..

Code Review Plugin 0.1.4.1 Released. - Added by Haruyuki Iida about 10 years ago

Thanks Michael, Jens.

I just released redmine_code_review-0.1.4.1.
http://r-labs.googlecode.com/files/redmine_code_review-0.1.4.1.zip

  • feature
    • German translation added.
  • todo
    • "My page" block with code reviews
    • use different image for closed reviews
    • show a report with recently committed files
    • expert mode

RE: Code Review Plugin - Added by Muhamed niyas about 10 years ago

How can i delete a code review task assigned to a person?
Pls see the attached image. Those records are wrongly created
due to some issue in the early version of the code review plugin.
If i clcik on the link i got the following error.

 TypeError in Code reviewController#show

can't convert nil into String

RAILS_ROOT: /home/niyas/redmine-0.8.3
Application Trace | Framework Trace | Full Trace

vendor/plugins/redmine_code_review/app/controllers/code_review_controller.rb:117:in `+'
vendor/plugins/redmine_code_review/app/controllers/code_review_controller.rb:117:in `show'
vendor/rails/actionpack/lib/action_controller/base.rb:1166:in `send'
vendor/rails/actionpack/lib/action_controller/base.rb:1166:in `perform_action_without_filters'
vendor/rails/actionpack/lib/action_controller/filters.rb:579:in `call_filters'
vendor/rails/actionpack/lib/action_controller/filters.rb:572:in `perform_action_without_benchmark'
vendor/rails/actionpack/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
/usr/lib/ruby/1.8/benchmark.rb:293:in `measure'
vendor/rails/actionpack/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
vendor/rails/actionpack/lib/action_controller/rescue.rb:201:in `perform_action_without_caching'
vendor/rails/actionpack/lib/action_controller/caching/sql_cache.rb:13:in `perform_action'
vendor/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:33:in `cache'
vendor/rails/activerecord/lib/active_record/query_cache.rb:8:in `cache'
vendor/rails/actionpack/lib/action_controller/caching/sql_cache.rb:12:in `perform_action'
vendor/rails/actionpack/lib/action_controller/base.rb:529:in `send'
vendor/rails/actionpack/lib/action_controller/base.rb:529:in `process_without_filters'
vendor/rails/actionpack/lib/action_controller/filters.rb:568:in `process_without_session_management_support'
vendor/rails/actionpack/lib/action_controller/session_management.rb:130:in `process'
vendor/rails/actionpack/lib/action_controller/base.rb:389:in `process'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:149:in `handle_request'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:107:in `dispatch'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:104:in `synchronize'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:104:in `dispatch'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:120:in `dispatch_cgi'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:35:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:76:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:74:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:74:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:159:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:282:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:281:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:281:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/mongrel_rails:128:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/command.rb:212:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/mongrel_rails:281
vendor/rails/activesupport/lib/active_support/dependencies.rb:503:in `load'
vendor/rails/activesupport/lib/active_support/dependencies.rb:503:in `load'
vendor/rails/activesupport/lib/active_support/dependencies.rb:355:in `new_constants_in'
vendor/rails/activesupport/lib/active_support/dependencies.rb:503:in `load'
vendor/rails/railties/lib/commands/servers/mongrel.rb:64
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
vendor/rails/activesupport/lib/active_support/dependencies.rb:510:in `require'
vendor/rails/activesupport/lib/active_support/dependencies.rb:355:in `new_constants_in'
vendor/rails/activesupport/lib/active_support/dependencies.rb:510:in `require'
vendor/rails/railties/lib/commands/server.rb:39
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
script/server:3

vendor/plugins/redmine_code_review/app/controllers/code_review_controller.rb:117:in `+'
vendor/plugins/redmine_code_review/app/controllers/code_review_controller.rb:117:in `show'
vendor/rails/actionpack/lib/action_controller/base.rb:1166:in `send'
vendor/rails/actionpack/lib/action_controller/base.rb:1166:in `perform_action_without_filters'
vendor/rails/actionpack/lib/action_controller/filters.rb:579:in `call_filters'
vendor/rails/actionpack/lib/action_controller/filters.rb:572:in `perform_action_without_benchmark'
vendor/rails/actionpack/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
/usr/lib/ruby/1.8/benchmark.rb:293:in `measure'
vendor/rails/actionpack/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
vendor/rails/actionpack/lib/action_controller/rescue.rb:201:in `perform_action_without_caching'
vendor/rails/actionpack/lib/action_controller/caching/sql_cache.rb:13:in `perform_action'
vendor/rails/activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb:33:in `cache'
vendor/rails/activerecord/lib/active_record/query_cache.rb:8:in `cache'
vendor/rails/actionpack/lib/action_controller/caching/sql_cache.rb:12:in `perform_action'
vendor/rails/actionpack/lib/action_controller/base.rb:529:in `send'
vendor/rails/actionpack/lib/action_controller/base.rb:529:in `process_without_filters'
vendor/rails/actionpack/lib/action_controller/filters.rb:568:in `process_without_session_management_support'
vendor/rails/actionpack/lib/action_controller/session_management.rb:130:in `process'
vendor/rails/actionpack/lib/action_controller/base.rb:389:in `process'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:149:in `handle_request'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:107:in `dispatch'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:104:in `synchronize'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:104:in `dispatch'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:120:in `dispatch_cgi'
vendor/rails/actionpack/lib/action_controller/dispatcher.rb:35:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:76:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:74:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/rails.rb:74:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:159:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:282:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:281:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/configurator.rb:281:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/mongrel_rails:128:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel/command.rb:212:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/mongrel_rails:281
vendor/rails/activesupport/lib/active_support/dependencies.rb:503:in `load'
vendor/rails/activesupport/lib/active_support/dependencies.rb:503:in `load'
vendor/rails/activesupport/lib/active_support/dependencies.rb:355:in `new_constants_in'
vendor/rails/activesupport/lib/active_support/dependencies.rb:503:in `load'
vendor/rails/railties/lib/commands/servers/mongrel.rb:64
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
vendor/rails/activesupport/lib/active_support/dependencies.rb:510:in `require'
vendor/rails/activesupport/lib/active_support/dependencies.rb:355:in `new_constants_in'
vendor/rails/activesupport/lib/active_support/dependencies.rb:510:in `require'
vendor/rails/railties/lib/commands/server.rb:39
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
/usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
script/server:3

Request

Parameters:

{"id"=>"traacs",
 "review_id"=>"10"}

Show session dump

--- 
code_reviewindex_sort: 
  :key: id
  :order: desc
:user_id: 3
flash: !map:ActionController::Flash::FlashHash {}

Response

Headers:

{"cookie"=>[],
 "Cache-Control"=>"no-cache"}

code_review.jpg (48.7 KB)

RE: Code Review Plugin - Added by Haruyuki Iida about 10 years ago

Muhamed,

If you can use any SQL client tool, connect to database and execute SQL below.

delete from code_reviews where id in (#, #, #...);

1 2 3 4 5 (26-50/118)