Defect #11511

Confirmation page has broken HTML when a project folding sub project is deleted

Added by Haruka Yoshihara over 5 years ago. Updated over 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Projects
Target version:2.0.4
Resolution:Fixed Affected version:

Description

I created a new project in Redmine (In "Home" page, I clicked [Administration], next [Projects], third [New Project]. I filled the necessary fields in "New project" page and clicked [Create] button finally).
This new project is "PARENT-PROJECT".
I also created a new sub project of "PARENT-PROJECT", named "SUB-PROJECT".
When I created "SUB-PROJECT", I selected "PARENT-PROJECT" in "Subproject of" drop-down list.
So I will delete the "PARENT-PROJECT" (In "Home" page, I clicked [Administration], next [Projects], finally [Delete] on right side of "PARENT-PROJECT" column),
but "Confirmation" page has broken HTML.

<p><strong>PARENT-PROJECT</strong><br />
Are you sure you want to delete this project and related data?

<br />Its subproject(s): &lt;strong&gt;SUB-PROJECT&lt;/strong&gt; will be also deleted.
</p>

Open <strong> tag and close </strong> tag are escaped around "SUB-PROJECT".

For example:

Before:
PARENT-PROJECT
Are you sure you want to delete this project and related data?
Its subproject(s): <strong>SUB-PROJECT</strong> will be also deleted.

After:
PARENT-PROJECT
Are you sure you want to delete this project and related data?
Its subproject(s): SUB-PROJECT will be also deleted.

The strong tags put stronger emphasis on "SUB-PROJECT" string. This case, "Confirmation" page has broken HTML.
I use ruby 1.9.3 and Rails 3.2.6.

0001-Fix-too-escaped-strong-in-confirmation-page.diff Magnifier (660 Bytes) Haruka Yoshihara, 2012-07-26 07:02

Associated revisions

Revision 10083
Added by Toshi MARUYAMA over 5 years ago

fix confirmation page has broken HTML when a project folding sub project is deleted (#11511)

Contributed by Haruka Yoshihara.

Revision 10084
Added by Toshi MARUYAMA over 5 years ago

Merged r10083 from trunk to 2.0-stable (#11511)

fix confirmation page has broken HTML when a project folding sub project is deleted.

Contributed by Haruka Yoshihara.

History

#1 Updated by Haruka Yoshihara over 5 years ago

I attach a path for this issue.

#2 Updated by Toshi MARUYAMA over 5 years ago

  • Category set to Projects
  • Status changed from New to Confirmed

#3 Updated by Toshi MARUYAMA over 5 years ago

  • Target version set to 2.0.4

#4 Updated by Toshi MARUYAMA over 5 years ago

  • Status changed from Confirmed to Closed
  • Resolution set to Fixed

Committed in trunk r10083 and 2.0-stable r10084, thanks.

Also available in: Atom PDF