Non ASCII filename downloaded from repo is broken on Internet Explorer.
|Assignee:||Toshi MARUYAMA||% Done:|
On Internet Explorer, a filename downloded from repository is broken, because that filename is consist of multibyte characters. But, that is absolutely normal on Chrome.
In addition, attached files in the Redmine "files" page have no problem.
I think that this code has no problem,
./controllers/attachments_controller.rb: send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
... and this code has a problem.
./controllers/repositories_controller.rb: send_data @content, :filename => @path.split('/').last
I test that modification like below, and it seems successful!
send_data @content, :filename => filename_for_content_disposition(@path.split('/').last)
In my opinion, some of other
send_datas can have similar problems.
#4 Updated by Kesarr B over 8 years ago
- File redmine_repository_download_original.png added
- File redmine_repository_download_modified.png added
Toshi MARUYAMA wrote:
Subversion stored paths as Unicode.
Can you paste a path and attach a image?
#9 Updated by Toshi MARUYAMA over 8 years ago
- File ie-before.png added
- File ie-after.png added
- Status changed from New to Closed
- Resolution set to Fixed
These are images on my Japanese Windows Vista and IE 8.
"send_data" at source:trunk/app/controllers/repositories_controller.rb@4817#L164 is revision and it is ASCII.