Defect #9832

Revision graph height should depend on height of rows in revisions table

Added by Jakob Skjerning almost 6 years ago. Updated almost 6 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:1.3.1
Resolution:Fixed Affected version:1.3.0

Description

The new revision graph from #5501 is nice and looks fine - at least on the default theme. However, it doesn't behave well when displayed using many of the existing third party themes.

At the very least the graph should adapt to the actual height of the rows of the revisions list instead of blindly assuming a hardcoded value of 20 pixels.

The attached patch fixes this.

get_height_from_rows.diff Magnifier (562 Bytes) Jakob Skjerning, 2011-12-18 11:55

1.3-stable-r8781.png (15.4 KB) Toshi MARUYAMA, 2012-02-06 05:36

1.3-stable-r8796.png (17.7 KB) Toshi MARUYAMA, 2012-02-06 05:36

theme-simple.diff Magnifier (601 Bytes) Toshi MARUYAMA, 2012-02-06 05:36


Related issues

Duplicated by Redmine - Feature #9846: Provide the way for theme developers to set the row heigh... Closed

Associated revisions

Revision 8795
Added by Toshi MARUYAMA almost 6 years ago

scm: fix revision graph height is hard-coded (#9832)

Contributed by Jakob Skjerning.

Revision 8796
Added by Toshi MARUYAMA almost 6 years ago

Merged r8795 from trunk (#9832)

scm: fix revision graph height is hard-coded.

Contributed by Jakob Skjerning.

History

#1 Updated by Jakob Skjerning almost 6 years ago

Redmine version: Redmine 1.3.0.devel.8277 (MySQL)

Output from script/about:

About your application's environment
Ruby version 1.8.7 (i686-darwin10.8.0)
RubyGems version 1.3.7
Rack version 1.1.2
Rails version 2.3.14
Active Record version 2.3.14
Active Resource version 2.3.14
Action Mailer version 2.3.14
Active Support version 2.3.14
Application root /Users/jakob/Projects/OpenSource/redmine/redmine-trunk
Environment development
Database adapter mysql
Database schema version 20111201201315

#2 Updated by Toshi MARUYAMA almost 6 years ago

  • Category changed from UI to SCM

#3 Updated by Toshi MARUYAMA almost 6 years ago

  • Affected version (unused) changed from devel to 1.3.0
  • Affected version set to 1.3.0

#4 Updated by Toshi MARUYAMA almost 6 years ago

  • Target version set to 1.3.1

#5 Updated by Toshi MARUYAMA almost 6 years ago

These are images with attachment theme.

Also available in: Atom PDF