Code Review Plugin 0.2.0 Released.

Added by Haruyuki Iida about 8 years ago

I've just released a new version of Code Review Plugin.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.0.zip

features:
  • Integrated code reviews with issues.So you can set work flow, spent time, due date, auto close with commit, and more...
    • You can convert old review records to new records on setting page. But I recommend you to backup the data brefore convert them.
  • Added Traditional Chinese translation.

Thanks.

Replies (71)

RE: Code Review Plugin 0.2.0 Released. - Added by Ammler _ about 8 years ago

It is very hard to follow your process, is there somewhere a translation?
http://code.google.com/p/r-labs/source/list

Greets
Marcel

RE: Code Review Plugin 0.2.0 Released. - Added by Ammler _ about 8 years ago

I miss the tag 0.2.0, I assume it is trunk?

RE: Code Review Plugin 0.2.0 Released. - Added by Ammler _ about 8 years ago

(I really miss the edit link here. ;-)

Linking to issue tracker is awesome, many thanks. :-) But now, I would like to hide the Review Tag, the settings could be accessed from the project admin tab, imo.

Anyway, one of the best plugins, ever. :-)

Greets
Marcel

Code Review Plugin 0.2.1 Released. - Added by Haruyuki Iida about 8 years ago

Marcel Gmür wrote:

Linking to issue tracker is awesome, many thanks. :-) But now, I would like to hide the Review Tag, the settings could be accessed from the project admin tab, imo.

Code Review Plugin 0.2.1 Released.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.1.zip

Features:

  • Hide Code Reviews tab option
  • Russian translation

Code reveiws setting menu moved into Project settings page.

setting.jpg (21.8 KB)

RE: Code Review Plugin 0.2.0 Released. - Added by Thomas M about 8 years ago

Hi Haru,
in case you've missed the point you're developping one major enhancement to Redmine !

This is really becoming a great piece of software (looking forward to '#35' ... I'm kidding ;)).

I will test the 2.x series as soon as I go back to my office (next week).

Regards,
Arpel.

RE: Code Review Plugin 0.2.0 Released. - Added by Daniel Sovino about 8 years ago

Hi, I;m getting trouble while doing the plugin migration with rake.

My enviroment is Oracle 10g and Mercurial on Server2003

Thanx in advance.

The error trace:

C:\WINDOWS\ruby\apps\redmine-0.8.4>rake db:migrate_plugins RAILS_ENV=production --trace
(in C:/WINDOWS/ruby/apps/redmine-0.8.4)
  • Invoke db:migrate_plugins (first_time)
  • Invoke environment (first_time)
  • Execute environment
  • Execute db:migrate_plugins
    Migrating engines...
    Migrating Graphs...
    Migrating actionwebservice...
    Migrating acts_as_activity_provider...
    Migrating acts_as_attachable...
    Migrating acts_as_customizable...
    Migrating acts_as_event...
    Migrating acts_as_list...
    Migrating acts_as_searchable...
    Migrating acts_as_tree...
    Migrating acts_as_versioned...
    Migrating acts_as_watchable...
    Migrating classic_pagination...
    Migrating coderay-0.7.6.227...
    Migrating gloc-1.1.0...
    Migrating gravatar...
    Migrating redmine_code_review...
    1 CreateCodeReviews: migrating ===========================================
    -- create_table(:code_reviews)
    rake aborted!
    OCIError: ORA-00904: : identificador no vßlido: CREATE TABLE code_reviews (id NUMBER NOT NULL PRIMARY KEY, project_id NUMBER, parent_id NUMBER, change_id NUMBER, created_at TIMESTAMP, updated_at TIMESTAMP, user_id NUMBER, comment CLOB, status NUMBER, line NUMBER)
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:147:in `log'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/activerecord-oracle_enhanced-adapter-1.1.8/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb:423:in `execute'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:108:in `create_table'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/activerecord-oracle_enhanced-adapter-1.1.8/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb:639:in `create_table'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:346:in `send'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:346:in `method_missing'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:326:in `say_with_time'
    C:/WINDOWS/ruby/lib/ruby/1.8/benchmark.rb:293:in `measure'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:326:in `say_with_time'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:342:in `method_missing'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/plugins/redmine_code_review/db/migrate/0001_create_code_reviews.rb:20:in `up_without_benchmarks'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:280:in `send'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:280:in `migrate'
    C:/WINDOWS/ruby/lib/ruby/1.8/benchmark.rb:293:in `measure'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:280:in `migrate'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:455:in `migrate'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:445:in `each'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:445:in `migrate'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:373:in `up'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/rails/activerecord/lib/active_record/migration.rb:356:in `migrate'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/vendor/plugins/engines/lib/engines/plugin/migrator.rb:23:in `migrate_plugin'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/config/../vendor/plugins/engines/lib/engines/plugin.rb:122:in `migrate'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/lib/tasks/migrate_plugins.rake:8
    C:/WINDOWS/ruby/apps/redmine-0.8.4/lib/tasks/migrate_plugins.rake:5:in `each'
    C:/WINDOWS/ruby/apps/redmine-0.8.4/lib/tasks/migrate_plugins.rake:5
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:in `call'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:636:in `execute'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:in `each'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:631:in `execute'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:597:in `invoke_with_call_chain'
    C:/WINDOWS/ruby/lib/ruby/1.8/monitor.rb:242:in `synchronize'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:590:in `invoke_with_call_chain'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:583:in `invoke'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2051:in `invoke_task'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `top_level'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `each'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2029:in `top_level'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2023:in `top_level'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2001:in `run'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake.rb:1998:in `run'
    C:/WINDOWS/ruby/lib/ruby/gems/1.8/gems/rake-0.8.7/bin/rake:31
    C:/WINDOWS/ruby/bin/rake:16:in `load'
    C:/WINDOWS/ruby/bin/rake:16

RE: Code Review Plugin 0.2.0 Released. - Added by Haruyuki Iida about 8 years ago

Hi Daniel.

I'm sorry, I tested only with MySQL and SQlite. and I have no idea about any other databases.

Code Review Plugin 0.2.2 Released. - Added by Haruyuki Iida about 8 years ago

Code Review Plugin 0.2.2 was released.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.2.zip

features:
  • You can add the code reviews on the entry view or annotate view. not only on the diff view.

  • Displays review summary in the Repository view.

  • Displays the list of reviews in the Revision view.

Thanks.

entry.jpg (37.5 KB)

annotate.jpg (42.9 KB)

repository.jpg (91.7 KB)

revision.jpg (25 KB)

RE: Code Review Plugin 0.2.0 Released. - Added by Thomas M about 8 years ago

Hi Haru,
after some tests here is my feedback on the latest 2.2 :

  • Integration with the tracker is working fine
  • The additionnal field on commits is really useful
  • The settings tab is much better integrated now

Back to my way of thincking Code Reviews I think that opening one Issue for each CodeReview is too much and useless, nevertheless having one Issue for a bunch of CodeReviews is fine.

Because one commit is not always covering the whole piece of code we want to review here is my proposal (waiting to get your feelings on that) :
  • One user setup a CodeReview, why not creating an Issue, in a dedicated (or not) tracker
    at this point the review is empty but as an issue it can follows the whole Issue flow
  • This user or anyone else lists the files targeted by the review using your "Wiki like" syntax to get linked to the file diff view (maybe using the common file view syntax is enought).
  • Each user involved in the review uses the links from the Issue to go to each files and "Comment", of course everyone is seeing everyone else Comments.
  • Each comments are listed, along with their answers and their statuses, sorted by files, at the end of the CodeReview Issue.

If the Issue process is not flexible enought why not implementing this into the "Code Review" tab and the Issue will be hand created.

What do you think of that ?

RE: Code Review Plugin 0.2.0 Released. - Added by Haruyuki Iida about 8 years ago

Hi Thomas.

If I found a problem in the code, It is a issue. That's all. It is so simple and easy, isn't it?
I don't understand why it is too much and useless.
Your idea is too much and useless to me. Because there are many steps to reporting problems.

If one issue includes several problems, How can I assign each problem to different members ? and each problem may have a different priority, status, due date or other properties.

And I want to close reviews by commiting fixed code. But several problems are not fixed in one commit.

Setting the same target version to review-issues is same as your proposal, I think.

Anyway, Thank you for your comments and testing my plugin.
I really appreciate you.

Regards.

RE: Code Review Plugin 0.2.0 Released. - Added by Thomas M about 8 years ago

Hi Haru,
thanks for your answer !

First of all and in case you've felt I was critisizing your job : I'm not and I really appreciate your work and the time you're tacking to answer me (see 5-6 previous post to be convinced ;) ).

I understand your concept : reviews are done "at any time by anybody" and everything found is a problem and need to be fixed. Your can assign the fixing job to different folks with several priority with the common issue flow : OK.

In my developping flow (and I hope in someone else ;)) code review is a step, a formal step after (branch) commit and before on target debugging. During this step the developper ask some peers to review a set of files (1 to 25). Each reviewer lists its comments, they may be "issues" (lets say dereferenced pointer) or "typo" (lets say naming convention) or "thoughts" (from splitting a function to trashing everything).
My feeling is that the latter two don't need to be spotted as "Issues", I mean seen by everybody else (including the customer).
Moreover the Issue flow will not be used because all "Comments" from the review need to be closed before going to the next developping step.

Best regards,
Thomas.

RE: Code Review Plugin 0.2.0 Released. - Added by Fred McCann about 8 years ago

This plugin works great in Firefox. I get an error on Safari however. When the code review window pops up, I get the login page, not the code review form.

RE: Code Review Plugin 0.2.0 Released. - Added by Haruyuki Iida about 8 years ago

Hi Fred.

Fred McCann wrote:

This plugin works great in Firefox. I get an error on Safari however. When the code review window pops up, I get the login page, not the code review form.

Hmm. It works on my PC.

safari.jpg (42.4 KB)

RE: Code Review Plugin 0.2.0 Released. - Added by Andrea Campi about 8 years ago

Thomas,

Thomas M wrote:

In my developping flow (and I hope in someone else ;)) code review is a step, a formal step after (branch) commit and before on target debugging. During this step the developper ask some peers to review a set of files (1 to 25). Each reviewer lists its comments, they may be "issues" (lets say dereferenced pointer) or "typo" (lets say naming convention) or "thoughts" (from splitting a function to trashing everything).

that's exactly the kind of workflow I'm trying to set up; however, I am stuck at step 1, since Redmine only really supports the git master branch.
If I may, how did you set things up?

Also, to get back into topic, a feature suggestion for this plugin: what about (optionally) opening a "review needed" issue.
By default the issue would be unassigned, or it could be optionally assigned to a user with a given role. This should be flexible enough to accommodate any workflow (meaning: if you can't do automatic assignment in your company, people will have to assign it manually).
WDYT?

RE: Code Review Plugin 0.2.0 Released. - Added by Thomas M about 8 years ago

Andrea Campi wrote:

If I may, how did you set things up?

Hi Andrea, happy to see that I'm not the only to bother Haru !

In fact my answer may not help you ... I'm using SVN (sorry).
I have almost no idea of the git branching concept.

RE: Code Review Plugin 0.2.0 Released. - Added by Mischa The Evil about 8 years ago

Andrea Campi wrote:

[...] however, I am stuck at step 1, since Redmine only really supports the git master branch. [...]

This actually has been solved (finally :) last sunday with revision r2840 on the source:/trunk for issue #1406.

RE: Code Review Plugin 0.2.0 Released. - Added by Andrea Campi about 8 years ago

Mischa The Evil wrote:

Andrea Campi wrote:

[...] however, I am stuck at step 1, since Redmine only really supports the git master branch. [...]

This actually has been solved (finally :) last sunday with revision r2840 on the source:/trunk for issue #1406.

wow, that's great news! checking out now :)

RE: Code Review Plugin 0.2.0 Released. - Added by Andrea Campi about 8 years ago

Suggestions:

  • in the "Code reviews" tab, the issue number is not linked to the issue, I think it should be.
  • if the revision mentions one or more issues, the Code review issue should Reference the issues--possibly even Block them (that may be configurable).

RE: Code Review Plugin 0.2.0 Released. - Added by Micha Kersloot about 8 years ago

Haru Iida wrote:

Code Review Plugin 0.2.2 was released.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.2.zip

features:
  • You can add the code reviews on the entry view or annotate view. not only on the diff view.

That feature would be nice. Although after upgrading to this 0.2.2 version I get an
NoMethodError (undefined method `changes' for nil:NilClass):
error.

Ehh, Help?

Greets Micha

RE: Code Review Plugin 0.2.0 Released. - Added by Haruyuki Iida about 8 years ago

Thanks for suggestions.

Andrea Campi wrote:

By default the issue would be unassigned, or it could be optionally assigned to a user with a given role. This should be flexible enough to accommodate any workflow (meaning: if you can't do automatic assignment in your company, people will have to assign it manually).
WDYT?

I also had the same idea with you. I will try. But it takes while.

  • in the "Code reviews" tab, the issue number is not linked to the issue, I think it should be.

Very easy. I will release soon.

  • if the revision mentions one or more issues, the Code review issue should Reference the issues--possibly even Block them (that may be configurable).

It seems good idea. I examine it.

Regards.

RE: Code Review Plugin 0.2.0 Released. - Added by Haruyuki Iida about 8 years ago

Micha Kersloot wrote:

That feature would be nice. Although after upgrading to this 0.2.2 version I get an
NoMethodError (undefined method `changes' for nil:NilClass):
error.

Ehh, Help?

Greets Micha

I need more information.
Can you show me stack trace of this error?
What did you do when you find this error?

RE: Code Review Plugin 0.2.0 Released. - Added by Paul H about 8 years ago

For me this happens when I go to view code in the repository that isnt a specific revision(the head) and here's a copy of the stack trace

Processing CodeReviewController#update_diff_view (for 67.250.56.77 at 2009-08-22 21:55:46) [POST]
Session ID: 65488a5c91c4436e8af982fb91c3d545
Parameters: {"rev"=>"", "rev_to"=>"", "action"=>"update_diff_view", "id"=>"top5mcs", "review_id"=>"", "path"=>"/trunk/grails-app/controllers/BattleController.groovy", "action_type"=>"annotate", "controller"=>"code_review"}

NoMethodError (undefined method `changes' for nil:NilClass):
/vendor/plugins/redmine_code_review/app/controllers/code_review_controller.rb:137:in `update_diff_view'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:1166:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:1166:in `perform_action_without_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:579:in `call_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:572:in `perform_action_without_benchmark'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
/usr/lib/ruby/1.8/benchmark.rb:293:in `measure'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/benchmarking.rb:68:in `perform_action_without_rescue'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/rescue.rb:201:in `perform_action_without_caching'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/caching/sql_cache.rb:13:in `perform_action'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/connection_adapters/abstract/query_cache.rb:33:in `cache'
/usr/lib/ruby/gems/1.8/gems/activerecord-2.1.2/lib/active_record/query_cache.rb:8:in `cache'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/caching/sql_cache.rb:12:in `perform_action'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:529:in `send'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:529:in `process_without_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/filters.rb:568:in `process_without_session_management_support'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/session_management.rb:130:in `process'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/base.rb:389:in `process'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:149:in `handle_request'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:107:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:104:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:104:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:120:in `dispatch_cgi'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.1.2/lib/action_controller/dispatcher.rb:35:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel/rails.rb:76:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel/rails.rb:74:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel/rails.rb:74:in `process'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:159:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:158:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:158:in `process_client'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:285:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:285:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:285:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:268:in `initialize'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:268:in `new'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:268:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel/configurator.rb:282:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel/configurator.rb:281:in `each'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel/configurator.rb:281:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/mongrel_rails:128:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel/command.rb:212:in `run'
/usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/mongrel_rails:281
/usr/bin/mongrel_rails:19:in `load'
/usr/bin/mongrel_rails:19

Rendering /home/redmine/redmine-0.8.4/public/500.html (500 Internal Server Error)

RE: Code Review Plugin 0.2.0 Released. - Added by CS Wong about 8 years ago

I'm trying to install Code Review plugin version 0.2.2 into Redmine trunk r2847. Have run the db_migrate rake task. As soon as I enter any page right now, I'm seeing this error below (the error doesn't appear when I remove the plugin). Does anyone else have this problem?

SQL (0.9ms)   SET NAMES 'utf8'
SQL (0.8ms) SET SQL_AUTO_IS_NULL=0
/!\ FAILSAFE /!\ Mon Aug 24 00:36:14 +0800 2009
Status: 500 Internal Server Error
A secret is required to generate an integrity hash for cookie session data. Use config.action_controller.session = { :session_key => "_myapp_session", :secret => "some secret phrase of at least 30 characters" } in config/environment.rb
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/session/cookie_store.rb:91:in `ensure_secret_secure'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/session/cookie_store.rb:59:in `initialize'
/usr/lib/ruby/1.8/cgi/session.rb:273:in `new'
/usr/lib/ruby/1.8/cgi/session.rb:273:in `initialize_without_cgi_reader'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_ext/session.rb:19:in `initialize'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_process.rb:94:in `new'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_process.rb:94:in `session'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_process.rb:130:in `stale_session_check!'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/cgi_process.rb:78:in `session'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/base.rb:1205:in `assign_shortcuts_without_flash'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/flash.rb:166:in `assign_shortcuts'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/base.rb:519:in `process_without_filters'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/filters.rb:606:in `process_without_session_management_support'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/session_management.rb:134:in `process'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/base.rb:392:in `process'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:183:in `handle_request'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:110:in `dispatch_unlocked'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:123:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:122:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:122:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:132:in `dispatch_cgi'
/usr/lib/ruby/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/dispatcher.rb:39:in `dispatch'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/railz/request_handler.rb:45:in `process_request'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_request_handler.rb:203:in `main_loop'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/railz/application_spawner.rb:340:in `start_request_handler'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/railz/application_spawner.rb:298:in `handle_spawn_application'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/utils.rb:181:in `safe_fork'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/railz/application_spawner.rb:296:in `handle_spawn_application'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server.rb:337:in `__send__'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server.rb:337:in `main_loop'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server.rb:187:in `start_synchronously'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server.rb:154:in `start'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/railz/application_spawner.rb:192:in `start'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/spawn_manager.rb:257:in `spawn_rails_application'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server_collection.rb:126:in `lookup_or_add'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/spawn_manager.rb:251:in `spawn_rails_application'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/spawn_manager.rb:250:in `spawn_rails_application'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/spawn_manager.rb:153:in `spawn_application'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/spawn_manager.rb:282:in `handle_spawn_application'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server.rb:337:in `__send__'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server.rb:337:in `main_loop'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/lib/phusion_passenger/abstract_server.rb:187:in `start_synchronously'
/usr/lib/ruby/gems/1.8/gems/passenger-2.2.2/bin/passenger-spawn-server:61

RE: Code Review Plugin 0.2.0 Released. - Added by CS Wong about 8 years ago

ok, the error above was obvious enough to fix. I'm just curious why would a session-related error appear after this plugin was activated.

I've added the configuration needed and Redmine's working again. However, I don't seem to be able to add code reviews.

What I've done is
  1. Enabled plugin
  2. Enabled code review module for my project (I can see the Code Review tab in project settings)
  3. Granted my current role permissions for Code Review

From the screenshots above, I think I'm supposed to see an additional "Pencil" icon at each line which I can click on in order to create a new Code Review. Am I right on this?

Code Review Plugin 0.2.3 Released. - Added by Haruyuki Iida about 8 years ago

Paul H wrote:

For me this happens when I go to view code in the repository that isnt a specific revision(the head) and here's a copy of the stack trace

Thanks.

I released a Code Review Plugin 0.2.3 Released.
http://r-labs.googlecode.com/files/redmine_code_review-0.2.3.zip

Feature:
  • Issue number is linked to the issue in Code Reviews tab.
  • Javascript performance tuning.
Bug fix:
  • Error occurs at code view that isn't specific revision.

1 2 3 (1-25/71)