Patch #11497

Dry up logging in MailHandler class

Added by Alex Shulgin 10 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

The current approach to logging in MailHandler is a bit funny. Instead of checking "if logger" every time, just make sure logger returns non-nil.

Also, extra-checking with "if logger && logger.info" doesn't make much sense. It prints extra blank lines when logger is set and accepts info level, but has no point when level setting is different. It's perfectly safe to just call "logger.info message".

0012-Dry-up-MailHandler-logging.patch Magnifier (5.55 KB) Alex Shulgin, 2012-07-24 14:22

Also available in: Atom PDF