Feature #12251

Custom fields: 'Multiple values' should be able to be checked and then unchecked

Added by Elizabeth Schafer about 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Custom fields
Target version:2.3.0
Resolution:Fixed

Description

In Administration --> Custom Fields --> Issues:

  1. Click on one of the custom fields that you have set up as a list.
  2. Select the "Multiple values" checkbox and click Save.
  3. Click into the same custom field again.

The "Multiple values" checkbox is now disabled, so you can't uncheck it. In my case, I selected "Multiple values" on a custom field that's used by many projects, but changed my mind and now I'm stuck with it.

At the very least, I think there should be a warning that you won't be able to revert to single values.

This is tested on the BitNami Redmine 2.1.2 stack.


Related issues

Related to Redmine - Patch #12819: German translation for #12251 r11168 and #10191 r11173 Closed

Associated revisions

Revision 11167
Added by Jean-Philippe Lang almost 5 years ago

Ability to uncheck "Multiple values" for existing custom fields (#12251).

Revision 11168
Added by Jean-Philippe Lang almost 5 years ago

Adds a message about disabling multiple values on custom field form (#12251).

Revision 11218
Added by Jean-Philippe Lang almost 5 years ago

Adjust warning message (#12251).

History

#1 Updated by Joshua DeClercq about 5 years ago

I realize the risk involved with this, but agree some solution needs to be in place... I'm sure most people who check the box have no idea it's a commitment until after the fact.

You can always, of course, go into the database manually, find the custom fields table, and change that field's value in the 'multiple' column to 0.

#2 Updated by Jean-Philippe Lang almost 5 years ago

  • Subject changed from 'List' custom fields: 'Multiple values' should be able to be checked and then unchecked to Custom fields: 'Multiple values' should be able to be checked and then unchecked
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.3.0
  • Resolution set to Fixed

Fixed in r11167. You are now able to uncheck it. It will remove duplicate values and preserve only one value for each item.

#3 Updated by Daniel Felix almost 5 years ago

Hi there,

is there a reference which values getting lost? Alphabetically sorted or in which order?

#4 Updated by Jean-Philippe Lang almost 5 years ago

As documented at source:/trunk/app/models/custom_field.rb@11167#L340, value with the highest id for each customized object is kept.

#5 Updated by Daniel Felix almost 5 years ago

Jean-Philippe Lang wrote:

As documented at source:/trunk/app/models/custom_field.rb@11167#L340, value with the highest id for each customized object is kept.

Thanks! Haven't seen this comment. :-)

#6 Updated by Nicklas Holm almost 5 years ago

Jean-Philippe Lang wrote:

Fixed in r11167. You are now able to uncheck it. It will remove duplicate values and preserve only one value for each item.

Am I the only one who interprets the warning message as if only values occuring more than once will be removed? I'm not sure they actually can, but that's my idea of 'duplicate'.

#7 Updated by Jean-Philippe Lang almost 5 years ago

Nicklas Holm wrote:

Am I the only one who interprets the warning message as if only values occuring more than once will be removed? I'm not sure they actually can, but that's my idea of 'duplicate'.

Right, r11218 changes 'duplicate' to 'multiple' in the warning message.

Also available in: Atom PDF