Project

General

Profile

Actions

Patch #1286

closed

Adding non-ASCII new issue type in the New Issue page have encoding error using IE

Added by Chaoqun Zou over 16 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
Start date:
2008-05-22
Due date:
% Done:

0%

Estimated time:

Description

I have test firefox3, IE6 and IE7.
In the new issue page, adding ASCII new issue type is correct using all of the three browser.

But when add non-ASCII new issue type, only firefox works fine. IE6 will add mess-up characters to issue types and IE7 will fail to add the new type.

I have resolved this problem by add encodeURIComponent in the promptToRemote function in application.js.
And now both ASCII and non-ASCII new issue type can be added successfully.

Index: application.js
--- application.js Base (BASE)
+++ application.js Locally Modified (Based On LOCAL)
@@ -56,7 +56,7 @@
 function promptToRemote(text, param, url) {
     value = prompt(text + ':');
     if (value) {
-        new Ajax.Request(url + '?' + param + '=' + value, {asynchronous:true, evalScripts:true});
+        new Ajax.Request(url + '?' + param + '=' + encodeURIComponent(value), {asynchronous:true, evalScripts:true});
         return false;
     }
 }

Files

application.js.patch (830 Bytes) application.js.patch Chaoqun Zou, 2008-05-22 15:46
Actions #1

Updated by Jean-Philippe Lang over 16 years ago

  • Status changed from New to Closed
  • Target version set to 0.7.2

Fixed in r1442. Thanks for the patch.

Actions

Also available in: Atom PDF