Project

General

Profile

Actions

Defect #14178

closed

PDF API broken in version 2.3.1

Added by Massimo Rossello almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
PDF export
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The change in number of arguments in issues_to_pdf_draw_borders() in file lib/redmine/export/pdf.rb introduced by #13630 (r11693) breaks some plugins (namely redmine_wktime).

Would it be possible to restore the same arguments, even if id_width argument not used, for API compatibility?

Thanks


Files

pdf.rb.patch (1.4 KB) pdf.rb.patch Massimo Rossello, 2013-05-30 18:01

Related issues

Follows Redmine - Defect #13630: PDF export generates the issue id twiceClosed

Actions
Actions #1

Updated by Massimo Rossello almost 11 years ago

Here is a patch.
Sorry I can't change the tracker to patch

Actions #2

Updated by Toshi MARUYAMA almost 11 years ago

  • Target version set to 2.3.2
Actions #3

Updated by Jan Niggemann (redmine.org team member) almost 11 years ago

  • Tracker changed from Defect to Patch

Thank you for providing the patch!

Actions #4

Updated by Toshi MARUYAMA almost 11 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from PDF API broken to PDF API broken in version 2.3.1
  • Status changed from New to Closed
  • Affected version (unused) set to 2.3.1
  • Resolution set to Fixed
  • Affected version set to 2.3.1

Committed in trunk and 2.3-stable, thanks.

Actions

Also available in: Atom PDF