Defect #14206

Synchronize the lang attribute of the HTML with the display language

Added by Naoya Niwa over 4 years ago. Updated over 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:I18n
Target version:2.4.0
Resolution:Fixed Affected version:

Description

Currently, lang attribute of HTML is specified "en" always regardless of the display language.

patch-14206.diff Magnifier (640 Bytes) Naoya Niwa, 2013-06-08 20:38

lang.diff Magnifier (1.37 KB) Toshi MARUYAMA, 2013-06-09 01:05

lang-V2.diff Magnifier (1.37 KB) Toshi MARUYAMA, 2013-06-09 10:44


Related issues

Duplicated by Redmine - Defect #4009: "html" tag's xml:lang always "en" for all languages Closed 2009-10-09

Associated revisions

Revision 11952
Added by Toshi MARUYAMA over 4 years ago

set html lang by user locale (#14206)

History

#1 Updated by Naoya Niwa over 4 years ago

I made patch.
It gets the value of the lang attribute from I18n.locale.

Just in case, I made ​​sure the existing locales conform to BCP 47 by the following tool.

http://schneegans.de/lv/

#2 Updated by Toshi MARUYAMA over 4 years ago

  • Status changed from Resolved to New

#3 Updated by Toshi MARUYAMA over 4 years ago

Redmine defines wrapper "current_language".
source:tags/2.3.1/lib/redmine/i18n.rb#L111

#4 Updated by Toshi MARUYAMA over 4 years ago

This is a patch with tests.

#5 Updated by Naoya Niwa over 4 years ago

I appreciate all your help.
At the same time, please forgive my ignorance.

However, I think that should put double quotes around the value of the lang attribute.
I made ​​sure no problem otherwise.

#6 Updated by Toshi MARUYAMA over 4 years ago

Sorry, this is a patch with double quotes.

#7 Updated by Naoya Niwa over 4 years ago

  • Status changed from New to Resolved

Thank you very much indeed!

#8 Updated by Toshi MARUYAMA over 4 years ago

  • Status changed from Resolved to New

#9 Updated by Toshi MARUYAMA over 4 years ago

  • Target version set to 2.4.0

#10 Updated by Filou Centrinov over 4 years ago

  • Duplicated by Defect #4009: "html" tag's xml:lang always "en" for all languages added

#11 Updated by Jean-Philippe Lang over 4 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Also available in: Atom PDF