Defect #1589

link to a specific revision of a file doesn't work from revisions/show (fix included)

Added by Lasse Jansen over 9 years ago. Updated over 9 years ago.

Status:ClosedStart date:2008-07-06
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:0.8
Resolution:Fixed Affected version:

Description

Redmine trunk / mysql / svn

The links to a specific revision of a file are escaped (apache2 proxy balancer blocks them and says file does not exist). Example:

http://server/repositories/entry/id/vendor%2Fplugins%2Fhaml%2Finit.rb

instead of

http://server/repositories/entry/id/vendor/plugins/haml/init.rb

--- app/views/repositories/revision.rhtml    (revision 1643)
+++ app/views/repositories/revision.rhtml    (working copy)
@@ -50,7 +50,7 @@
 <% if change.action == "D" -%>
     <%= change.path -%>
 <% else -%>
-    <%= link_to change.path, :action => 'entry', :id => @project, :path => without_leading_slash(change.relative_path), :rev => @changeset.revision -%>
+    <%= link_to change.path, :action => 'entry', :id => @project, :path => to_path_param(without_leading_slash(change.relative_path)), :rev => @changeset.revision -%>
 <% end -%>
 <%= "(#{change.revision})" unless change.revision.blank?  %></td>
 <td align="right">

History

#1 Updated by Jean-Philippe Lang over 9 years ago

  • Category set to SCM
  • Status changed from New to Closed
  • Target version set to 0.8
  • Resolution set to Fixed

Applied in r1648.

Also available in: Atom PDF