Project

General

Profile

Actions
Copy link

Feature #17699

closed

Parse author's name enclosed in parentheses in the From field when creating a user account from an email

Added by Stanislav German-Evtushenko about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Email receiving
Target version:
4.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

Emails header "From" can be not only in angles format, like this: 

From: John Doe <john.doe@company.mail>
but also in parentheses format, like this: 
From: john.doe@company.mail (John Doe)
For example sendmail from postfix does this when using switch -F.
The patch to fix this is attached.

Files

Download all files
email_from_parens_format.diff (671 Bytes) email_from_parens_format.diff Stanislav German-Evtushenko, 2014-08-16 23:51
email_from_parens_format_test.diff (2.11 KB) email_from_parens_format_test.diff Stanislav German-Evtushenko, 2014-08-18 12:53
17699-fix-using-mail-address-object.diff (773 Bytes) 17699-fix-using-mail-address-object.diff Go MAEDA, 2019-02-16 04:38
17699-fix-using-mail-address-object-v2.diff (843 Bytes) 17699-fix-using-mail-address-object-v2.diff Go MAEDA, 2019-02-16 07:48
17699-fix-using-mail-address-object-v3.diff (849 Bytes) 17699-fix-using-mail-address-object-v3.diff Go MAEDA, 2019-02-16 08:00
17699-fix-using-mail-address-object-v4.diff (847 Bytes) 17699-fix-using-mail-address-object-v4.diff Go MAEDA, 2019-02-17 15:52
Actions
Copy link
 #1

Updated by Toshi MARUYAMA about 10 years ago

  • Category set to Email receiving
Actions
Copy link
 #2

Updated by Toshi MARUYAMA about 10 years ago

  • Subject changed from Parse email with header "From" in parens format to Parse email with header "From" in parentheses format
  • Description updated (diff)
Actions
Copy link
 #4

Updated by Go MAEDA over 5 years ago

  • Target version set to Candidate for next major release
Actions
Copy link
 #5

Updated by Go MAEDA over 5 years ago

I wrote a new patch. The code using Mail::Address is shorter and maybe more reliable (I hope) than the code using our regular expressions.

Patches to commit:
Actions
Copy link
 #6

Updated by Go MAEDA over 5 years ago

  • Target version changed from 4.0.2 to 4.1.0
Actions
Copy link
 #7

Updated by Go MAEDA over 5 years ago

  • File 17699-fix-using-mail-address-object-v2.diff added

Updated the patch. email.header['from'] can be nil or Mail::UnstructuredField object (does not have addrs method).

Actions
Copy link
 #8

Updated by Go MAEDA over 5 years ago

  • File deleted (17699-fix-using-mail-address-object-v2.diff)
Actions
Copy link
 #10

Updated by Go MAEDA over 5 years ago

Updated the patch again. from_addr.comments also can be nil.

Actions
Copy link
 #12

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch.

Actions
Copy link
 #13

Updated by Go MAEDA over 5 years ago

  • Subject changed from Parse email with header "From" in parentheses format to Parse author's name enclosed in parentheses in the From field when creating a user account from an email
Actions
Copy link
 #14

Updated by Go MAEDA over 5 years ago

  • Tracker changed from Patch to Feature
Actions
Copy link

Also available in: Atom PDF