Project

General

Profile

Actions

Defect #18781

closed

Redmine::FieldFormat::IntFormat does not accept "real" Integer values

Added by Sascha Hübner almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

I had the Problem of setting the value of a custom field in my code
and therefore validating the new (calculated) value.
The CustomField had the format Redmine::FieldFormat::IntFormat.
The new value was a true Integer: 1
But the value was refused with the message that it's not a Number!

The Reason is, that Redmine::FieldFormat::IntFormat validates the value with RegExp:

value =~ /^[+-]?\d+$/

which will not return true if value is not a String.
I understand, that "normally" values of custom fields will be set via forms
and so usually all values will be Strings.

But I think IntFormat's validation should accept real Integers also!

Actions #1

Updated by Jean-Philippe Lang almost 10 years ago

  • Target version set to 3.0.0
Actions #2

Updated by Jean-Philippe Lang almost 10 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r13863.

Actions

Also available in: Atom PDF