Project

General

Profile

Actions

Defect #1903

closed

Switch order of current and previous revisions in side-by-side diff

Added by Elliot Winkler about 16 years ago. Updated about 16 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
Start date:
2008-09-15
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Right now if you look at the side-by-side diff, the current revision is on the left, the previous revision is on the right. Usually when side-by-side diffs are presented (such as in every diff software I've come across) it's the other way around. This is confusing to newcomers to Redmine -- I just had an instance now where my friend I'm working on this project with thought that I had deleted something, when I'd actually added it, and it took a second for us to realize that the order was misleading (I guess he didn't notice the colors).

Attached is a patch that corrects this (or appears to, as well as I could read the lib/redmine/unified_diff.rb file).


Files

switch_order_of_sbs_diff.diff (1.77 KB) switch_order_of_sbs_diff.diff Elliot Winkler, 2008-09-15 04:14
Actions #1

Updated by Jean-Philippe Lang about 16 years ago

  • Category set to SCM
  • Status changed from New to Closed
  • Target version set to 0.8
  • Resolution set to Fixed

Agreed and committed in r1895.

Actions

Also available in: Atom PDF