Defect #19323

Incorrect links generated in emails if host setup uses other port (":" symbol)

Added by Eugene B almost 3 years ago. Updated almost 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Email notifications
Target version:3.0.1
Resolution:Fixed Affected version:3.0.0

Description

We were using 2.4.1 Bitnami installation for about a year with no problems. After 3.0.0 release we have switched to this new version to be sure we are using current Redmine branch, and our installation is not so outdated. We are using Bitnami 3.0.0 installer for windows platforms.

We have found a problem, that email links to task, that redmine provides within email body are broken. Our Redmine installation is availble on the address: http://10.0.0.1:81/redmine/ and according to this, at redmine settings, host is set as "10.0.0.1:81/redmine/"

But at the e-mail, link is the following: "http://10.0.0.1/issues/2460" while it should be "http://10.0.0.1:81/redmine/issues/2460" we have double checked, and we have found, that after ":" symbol at the host line, the rest is cut off and not included at the hyperlink.

When host setting was "10.0.0.1/redmine" the hyptrlink was "http://10.0.0.1/redmine/issues/2460" the only missing thing was the port. after we set host again with port, we got the link "http://10.0.0.1/issues/2460" again. So it seems redmine ignores the rest of the host address string after ":" symbol.


Related issues

Related to Redmine - Defect #20192: IssueLink in email notification contains SUB-URI part twice Needs feedback
Duplicated by Redmine - Defect #19611: Hostname with port via colon gets shrinked in e-mail noti... Closed

Associated revisions

Revision 14081
Added by Jean-Philippe Lang almost 3 years ago

Incorrect links generated in emails if host setup uses other port (#19323).

History

#1 Updated by Eugene B almost 3 years ago

Confirmed on 2 different PC (Server 2008R2 and Win 8.1)

Windows 8.1 details:

Host PC Win 8.1

c:\Redmine\3.0.0\apps\redmine\htdocs>ruby script/about
script/about no longer exists, please use bin/about instead.

c:\Redmine\3.0.0\apps\redmine\htdocs>ruby bin/about
DL is deprecated, please use Fiddle

Environment:
Redmine version 3.0.0.stable
Ruby version 2.0.0-p594 (2014-10-27) [i386-mingw32]
Rails version 4.2.0
Environment production
Database adapter Mysql2
SCM:
Subversion 1.8.10
Git 1.9.5
Filesystem
Redmine plugins:
no plugin installed

c:\Redmine\3.0.0\apps\redmine\htdocs>

The bug is very easy to observe, just >>>get<<< latest 3-0-0 installation from bitnami, install it. At Administration > Settings > General

setup Host name and path as: "10.0.0.1:81/redmine"

after that setup any mail (gmail or what else is faster) and update any tasks
with email notification. You will see that hyperlink to redmine task is broken at notify email.

#2 Updated by Jean-Philippe Lang almost 3 years ago

  • Status changed from New to Confirmed
  • Target version set to 3.0.1

#3 Updated by Jean-Philippe Lang almost 3 years ago

  • Subject changed from Incorrect hyperlink to task generated at email, if host setup uses other port (":" symbol) to Incorrect links generated in emails if host setup uses other port (":" symbol)
  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r14081, thanks for pointing this out.

#4 Updated by Jean-Philippe Lang almost 3 years ago

  • Status changed from Resolved to Closed

#5 Updated by Toshi MARUYAMA almost 3 years ago

  • Duplicated by Defect #19611: Hostname with port via colon gets shrinked in e-mail notifications added

#6 Updated by Toshi MARUYAMA over 2 years ago

  • Related to Defect #20192: IssueLink in email notification contains SUB-URI part twice added

Also available in: Atom PDF